More code review tools

#1

Post by Oompa » Tue, Mar 15, 2016, 6:09 PM UTC

Re: More code review tools

#2

Post by danpalmer » Tue, Mar 15, 2016, 6:21 PM UTC

This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. These changes look great, I just hope that we get some sort of checking-off of review points, and accept/reject functionality.

Re: More code review tools

#3

Post by avolcano » Tue, Mar 15, 2016, 6:28 PM UTC

danpalmer wrote: post #2

This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. These changes look great, I just hope that we get some sort of checking-off of review points, and accept/reject functionality.

I wonder if there's a set of API hooks they could expose to allow third party applications to handle more advanced code review techniques? I would totally understand GitHub not wanting to implement a full Phabricator/Gerrit review feature set, but maybe they could make it easier to integrate other services for it.

Re: More code review tools

#4

Post by numbsafari » Tue, Mar 15, 2016, 6:29 PM UTC

I'd love it if there was a way for me to queue my comments before submitting. I often keep my comments in a separate textedit/nv window and then go back to put them in since I want to keep track of questions that arise as I'm reading, but I don't want to pepper someone with comments that would be resolved 200 lines later in the diff.

Re: More code review tools

#5

Post by pearlsteinj » Tue, Mar 15, 2016, 6:32 PM UTC

I've been pleasantly surprised at how fast Github has been moving since that critical open letter came out. For a giant company like Github they've been releasing developer tools very quickly.

Re: More code review tools

#6

Post by willchen » Tue, Mar 15, 2016, 6:32 PM UTC

Does anybody else feel like GitHub has released more features in the last month than the last 6 months? I'm not sure if it's just a coincidence with all the attention they've gotten on HN, but these improvements are much appreciated!

Re: More code review tools

#7

Post by erichurkman » Tue, Mar 15, 2016, 6:35 PM UTC

danpalmer wrote: post #2

This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. These changes look great, I just hope that we get some sort of checking-off of review points, and accept/reject functionality.

I'd love a UI way to enable `?w=1` whitespace mode, especially for html/json/yaml files. I have a feeling a lot of reviewers don't know about it and spend an inordinate amount of time squinting to see what changes when it was a whitespace-only change.

Re: More code review tools

#8

Post by vdnkh » Tue, Mar 15, 2016, 6:36 PM UTC

pearlsteinj wrote: post #5

I've been pleasantly surprised at how fast Github has been moving since that critical open letter came out. For a giant company like Github they've been releasing developer tools very quickly.

Makes you question what exactly they were doing before the letter came out.

Re: More code review tools

#9

Post by faitswulff » Tue, Mar 15, 2016, 6:36 PM UTC

danpalmer wrote: post #2

This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. These changes look great, I just hope that we get some sort of checking-off of review points, and accept/reject functionality.

It's interesting that you mention checking off of review points. I had begun to do that in an informal fashion by updating my pull request with notes in the form of a checklist:

- [x] Refactor _

- [ ] Rename variable x

- [ ] ...

Now that you mention it, it would be very nice to have something like Google Docs's ability to mark comments as resolved.

Re: More code review tools

#10

Post by alexwebb2 » Tue, Mar 15, 2016, 6:37 PM UTC

Did they kill commit-level comments?

I can no longer make comments on a given commit - the entry box at the bottom is gone. Looks like you have to scroll all the way back up to the top, switch to the "Conversation" tab, and then make a PR-level comment instead of a commit-level comment.

I hope I'm missing something here, because as it stands now it's a big step backwards.