Live data from Hacker News

Stacked PRs are now live on GitHub

github.blog

91–100 of 308 posts

Re: Stacked PRs are now live on GitHub

#91

Is that why the menu toggle is the stack of pancakes emoji (U+1F95E)? Whimsy is fine but that change made me super suspicious about what I was looking at.

We've been using the pancake emoji internally so we thought it was a fun easter egg. It'll only be up for a few hours and then will go back to the regular icons :)

I was so happy when I saw that! There is joy and silliness left in GitHub! Thank you!

Re: Stacked PRs are now live on GitHub

#92
It's good to have this feature, but it is still up to the individual developers to separate the PR work in a way that can be merged "all or some and in which order". It can make organizing, reviewing and rebasing easier but a PR with repeat, broken or overriding code can screw up just the same. I guess what I mean is, don't expect it to just sort out multiple PRs that wouldn't have worked together without it.

Re: Stacked PRs are now live on GitHub

#93

Is that why the menu toggle is the stack of pancakes emoji (U+1F95E)? Whimsy is fine but that change made me super suspicious about what I was looking at.

We've been using the pancake emoji internally so we thought it was a fun easter egg. It'll only be up for a few hours and then will go back to the regular icons :)

I liked it. It’s nice to have little fleeting moments of what I call “Classic Web” feel.

Re: Stacked PRs are now live on GitHub

#94

I don't like this. The case where I need stacked PRs is when I have a ton of changes and I want to upstream them. I have so many changes that I have probably written code in this order: 1. feature1 work 2. feature2 work 3. architecture rework 4. docs 5. feature3 work 6. optimization 7. docs 8. feature4 work 9. security fixes 10. optimization 11. docs 12. last pass security fixes By the time I want to upstream, I prob…

> it adds very little on top of what I was already able to do by saying "this is PR 1 out of 7, this is PR2 out of 7 and build on top of the branch that I used for PR1/7, etc".

That's literally all it's supposed to do. Make that dev flow less awful so you don't have to say "by the way this PR depends on #123, I will change the target branch when that is merged" and nonsense like that.

Re: Stacked PRs are now live on GitHub

#95

Rejoice, finally a new feature that isn't AI related.

I get your point, but it kind of is AI related. The size of PRs since AI has made it much harder to review a diff. Stacking the PRs seems like a response to this problem.

It definitely isn't. People have wanted this for many years. It's an obvious workflow. There's been a feature request since at least 2020 and I'm sure there were earlier ones: https://github.com/cli/cli/issues/2693

Re: Stacked PRs are now live on GitHub

#96

Hey from the GitHub Stacked PRs team! Excited to release this more broadly so anyone can start stacking: https://gh.io/stacks Would love to hear any feedback, especially with the UI and CLI. We've got a lot more updates to the PR experience in store! Also happy to answer questions about the design decisions we made. There's a bunch happening behind the scenes, and it's one of the largest launches in GitHub history co…

Your team did an awesome job - I’ve been wanting this feature for years and what you guys delivered is exactly what I had in mind.

Re: Stacked PRs are now live on GitHub

#97
post #72

Earlier quoted context omitted.

Good. This change was unexpected and so unprofessional I though my browser was compromised.

My lord people accept a little bit of whimsey in your lives.

Remember when the Internet was a culture? Now you attempt the most tame possible attempt at that culture and people go into the Issue tracker to throw their little fit.

Re: Stacked PRs are now live on GitHub

#99

Hey from the GitHub Stacked PRs team! Excited to release this more broadly so anyone can start stacking: https://gh.io/stacks Would love to hear any feedback, especially with the UI and CLI. We've got a lot more updates to the PR experience in store! Also happy to answer questions about the design decisions we made. There's a bunch happening behind the scenes, and it's one of the largest launches in GitHub history co…

I needed this feature! Thank you

Re: Stacked PRs are now live on GitHub

#100

Earlier quoted context omitted.

I also don't get it. > With stacks, you can independently review and check each pull request, then merge everything together in one click. Consider: "With pull requests, you can independently review and check each commit inside the pull request, and then merge the entire pull request in one click." Pull requests are stacked commits. This does not have to recurse; you don't need stacked pull requests, not to mention s…

> With pull requests, you can independently review and check each commit inside the pull request, and then merge the entire pull request in one click Except you can’t really do that on GitHub, the “unit if review” is the PR so reviewing commits is adhoc, inconsistent, and awkward, and tracking their changes as they get fixed up is a pain. “Splatting” that as PRs is not the nicest way to do it green field, but it’s an…

Right; so maybe that's the thing to fix.
Post reply on HN