No post body was provided.
Reddit's photo albums broke due to Integer overflow of Signed Int32
91–100 of 142 posts
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#92Earlier quoted context omitted.
Take a 3-bit counter: 0->A 1->B 2->C 3->A 4->B 5->C 6->A 7->B A and B get hit three times while C only twice, so it will see 66% utilization compared to A and B EDITED s/once/twice/ thanks CyberDildonics
while C only once You listed C twice
Edited, thanks
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#93Happened a few years ago to YouTube[0]. I don’t know why counters that start at zero and only increment are stored as signed integers.
0: https://arstechnica.com/information-technology/2014/12/gangn...
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#94I'm just curious, I know it's a long running joke about how we're so stupid to think that we would never run out of unique digits with 2^32 possible values, but is this also the case with 64 bit values? Every new bit doubles the amount of information, so if 32 bits lasted reddit 10 years, presumably 33 bits would last them 20 years, 34 would last 40 and so on. Eventually, 64 bits would last them 10×2^32 years, which…
if everyone on earth shared a memory space and every person had 4 gigabytes of byte addressable storage, we'd be at 65 bits.
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#95Earlier quoted context omitted.
Someone probably joked they would never reach that scale when they wrote that code
Thinking "if that ever gets anywhere close to a problem we'll have vast resources and plenty of time to fix it" and then, I'm guessing, that person left a few months later and nobody owned that part of the code because it worked. Then 10 or so years went by... Whenever I write code like that which may break in say, 5 years, I'll sign it in the comments and put my personal email and phone number inviting future people…
Probably sufficient to write a test that will break in 5 years - X [days|months] with notes in the test about the problem and how to fix
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#96Earlier quoted context omitted.
Thinking "if that ever gets anywhere close to a problem we'll have vast resources and plenty of time to fix it" and then, I'm guessing, that person left a few months later and nobody owned that part of the code because it worked. Then 10 or so years went by... Whenever I write code like that which may break in say, 5 years, I'll sign it in the comments and put my personal email and phone number inviting future people…
Hm. I wonder why no one ever called you.
Because there's a dumb culture of treating people who left like they're from beyond the grave where you have to divine their intentions like some programming ouija board.
I broke that unspoken rule and got a really intractable problem that held us up for days finally fixed by making a short phone call early in my career and told myself if I was ever causing what we were going through I'd want to make it clear that I'm open to that rule being broken as well.
Apparently even suggesting such a rule should be questioned and to try human solutions to human problems is met with mockery and disdain. Alright, cool.
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#97I'm just curious, I know it's a long running joke about how we're so stupid to think that we would never run out of unique digits with 2^32 possible values, but is this also the case with 64 bit values? Every new bit doubles the amount of information, so if 32 bits lasted reddit 10 years, presumably 33 bits would last them 20 years, 34 would last 40 and so on. Eventually, 64 bits would last them 10×2^32 years, which…
I think it is a horrible assumption to think that Reddit won't grow and will take exactly the same length of time to double the number of unique ids required. But still 64 bits should be plenty for a while. And presumably if it comes closer to using that many they'll have enough time to switch to 128
Doubling the number of bits does not double the number of values, but squares it.
2^31 seconds is 68 years, a middling human lifetime.
2^63 seconds is 290 billion years.
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#98unique identifiers are so passé.
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#99Reminds me of a similar Chess.com iPad app issue from a few years back https://news.ycombinator.com/item?id=14539770
Re: Reddit's photo albums broke due to Integer overflow of Signed Int32
#100Earlier quoted context omitted.
If it’s round robin then it should be an even load, how does the modulo change that exactly? Also what number are they using to modulo and where is that happening? Because at that point don’t they already have an incrementing ID before generating another one?
Take a 3-bit counter: 0->A 1->B 2->C 3->A 4->B 5->C 6->A 7->B A and B get hit three times while C only twice, so it will see 66% utilization compared to A and B EDITED s/once/twice/ thanks CyberDildonics
That doesn't change anything... it's still round robin. You just stopped at an arbitrary number of 8 integers instead of 9.