Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

github.com

Post reply on HN
Print view View original

871–880 of 917 posts

Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

#871

Post by dang »

LandoCalrissian wrote: post #470
dmitriv wrote: post #268

I am the person who approved this PR and would like to acknowledge and apologize for the mistake of turning this feature on by default without sufficient upfront validation. There was no ill intent by evil corporation, but rather a desire to support functionality that some customers expect of VS Code w.r.t. AI-generated code. As folks mentioned here - many similar tools do this as well. Obviously, it should not be on…

[flagged]

"Please don't fulminate."

Not saying you owe $BigCo better, but you owe this community better if you're participating in it.

https://news.ycombinator.com/newsguidelines.html

Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

#872

Post by croemer »

tuetuopay wrote: post #742
croemer wrote: post #724

The "regardless of usage" in the HN title isn't correct. If you dig into the source you see that the attribution line is only added when some changes in the commit come from Copilot, either inline completion or agent. @dang

That is the crux of the issue: the detection of whether the changes came from copilot or not is buggy, thus all changes are flagged as coming from copilot, thus the title is correct.

That's not what the Pull Request intends, though. There's a difference between "This PR is buggy and enables attribution on everything" vs "VS Code enables attribution on everything".

The title is fuzzy on intent, making people believe it's intentional when one shouldn't assume intention (Hanlon).

Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

#873

Post by dang »

wswope wrote: post #855
dang wrote: post #827

Earlier quoted context omitted.

This is seriously not ok on HN. You can't attack others like this, regardless of how justified you are or feel you are, and we ban accounts that do. https://news.ycombinator.com/newsguidelines.html Edit: your account has unfortunately done this before (e.g. https://news.ycombinator.com/item?id=47548889 ). I don't want to ban you, so if you'd please review the site rules and not do anything like this again on HN, we'd…

Fair play; I got too personal here. Apologies.

Appreciated.

Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

#876

Post by fastasucan »

dmitriv wrote: post #531
p-e-w wrote: post #333

Earlier quoted context omitted.

I appreciate you acknowledging that this was a mistake, but as you surely know from your own experience with other people’s mistakes, some mistakes are so egregious that they cast doubt on the intentions of the people involved even if they are corrected later. To me, “let’s add false attribution to every commit by default without informing the user” falls squarely into that category. I don’t think I’ve ever worked in…

If what you described would make it to our PR queue, it would definitely not pass the gates. The idea was to track AI-only changes and add the trailer when such changes were detected AND the setting was enabled. Obviously, we didn't want to attribute all changes to AI. There is a bug in change detection (which slipped through testing), which led to even non-AI changes being tracked. And thus we have this problem. The…

>If what you described would make it to our PR queue, it would definitely not pass the gates

It just did though. Did you approve the PR without actually looking at the code?

Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

#877

Post by fastasucan »

dmitriv wrote: post #643
sandeepkd wrote: post #589

Earlier quoted context omitted.

Thanks for jumping in the conversation. Logically it does makes sense to attribute the authors correctly, however in this context it might be helpful if you can provide any details about the users complaining that their PR's are being marked as co-authored even when they have not used the copilot? Is that intentional or a missed check in the implementation. Also for layman readers like me who might not be actively in…

The fact that non-AI changes are attributed to Copilot is a bug. The intent was to allow customers to add attribution of AI-generated code. As with any bug, it was not intetional.

>The fact that non-AI changes are attributed to Copilot is a bug.

But sneaking in the attribution to Copilot without approval was the feature?

Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

#878

Post by fastasucan »

croemer wrote: post #872
tuetuopay wrote: post #742

Earlier quoted context omitted.

That is the crux of the issue: the detection of whether the changes came from copilot or not is buggy, thus all changes are flagged as coming from copilot, thus the title is correct.

That's not what the Pull Request intends, though. There's a difference between "This PR is buggy and enables attribution on everything" vs "VS Code enables attribution on everything". The title is fuzzy on intent, making people believe it's intentional when one shouldn't assume intention (Hanlon).

Who cares what it intends when they approve it and put into production?

Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

#879

Post by fastasucan »

dmitriv wrote: post #572
KyleBerezin wrote: post #253

quote: "Thank you all for your feedback, professional or otherwise. Sorry about the regression. I will work on fixing this in 1.119. There is a number of issues with the Co-Author functionality: It should never have been enabled when disableAIFeatures is on. It should not add attribution to changes that were not done by AI. We need to make sure it receives a more test coverage before change the default. If you have a…

Agreed, fixed disableAiFeatures in my PR: https://github.com/microsoft/vscode/pull/313931 Will work on making it better later.

But it should still add the tagline when copilot has been used, without direct approval by the user?

Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage

#880

Post by adastra22 »

b40d-48b2-979e wrote: post #870
adastra22 wrote: post #618

Earlier quoted context omitted.

Thank you for being upfront and engaging with us on this. This was a breach of trust, but your engagement here is commendable.

You're giving a lot of credit to a one day old anonymous account.

I have no reason to assume this is not Dmitriy Vasyura.
Post reply on HN