Earlier quoted context omitted.
I think the constructive criticism is best directed at whatever process you are following. That process allowed a very visible user facing change in a widely used piece of software. How did this change make it to production without some process catching the impact of this change? Was there really no internal discussion from a code review at least? This seems hard for me to believe. I expect more from Microsoft.
Fair point. We did catch it internally in testing (as we use VS Code for all our work, so some folks did stumble on it), but I think we underestimated the impact and should do a better job at that.
VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
831–840 of 917 posts
Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#832Earlier quoted context omitted.
I think the constructive criticism is best directed at whatever process you are following. That process allowed a very visible user facing change in a widely used piece of software. How did this change make it to production without some process catching the impact of this change? Was there really no internal discussion from a code review at least? This seems hard for me to believe. I expect more from Microsoft.
> Was there really no internal discussion from a code review at least? This seems hard for me to believe. The outlined story feels unfortunately very believable to me. Teams need to push out the most number of features, and nobody stops even for a second to think about how a feature might affect other flows or other users not in the feature request. It might have been quickly reviewed to check if the code does what i…
>The outlined story feels unfortunately very believable to me.
100% agree here - we seem to forget that most developers hate code reviews. I actually laughed out loud at the use of the word "discussion," it's so rare people want to get together and talk about changes. By the time the PR is up anything that stands in the way of merging and shipping is seen as a nuisance.
To my mind this whole debacle is not really the individuals fault or even the team's fault but the economic pressures that drive people into situations like this.
Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#833I am the person who approved this PR and would like to acknowledge and apologize for the mistake of turning this feature on by default without sufficient upfront validation. There was no ill intent by evil corporation, but rather a desire to support functionality that some customers expect of VS Code w.r.t. AI-generated code. As folks mentioned here - many similar tools do this as well. Obviously, it should not be on…
This goes beyond incompetence. Either you do not understand what important information a commit holds or what seems way more plausible to me is that Microsoft simply decided to try this out and see how people would react.
> There was no ill intent by evil corporation...
I will ever in my life buy that from Microsoft.
Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#834I am the person who approved this PR and would like to acknowledge and apologize for the mistake of turning this feature on by default without sufficient upfront validation. There was no ill intent by evil corporation, but rather a desire to support functionality that some customers expect of VS Code w.r.t. AI-generated code. As folks mentioned here - many similar tools do this as well. Obviously, it should not be on…
Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#835Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#836Earlier quoted context omitted.
First comment does not sound constructive - are you interested in my opinion on (n)vim? I am not a legal, so can't comment on legal things. However, I have already responded elsewhere here that this feature has nothing to do with licensing or ownership and was added for those that want the attribution. I understand the desire to see anything Microsoft as bad and evil, but we are really just trying to make a better ex…
Perhaps next time you should consult with legal before asserting co-authorship on end users’ code. The appended comment was not “edited with VS code” or “sent from VS code”, it was “co-authored by Copilot”. You do understand that there are legal implications to claims of authorship, right?
> cwebster-99 / Courtney Webster / Product Manager at @microsoft working on VS Code and GitHub Copilot!
>> No description provided.
Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#837Earlier quoted context omitted.
I think there’s a few of us who appreciate you being up front. I’d question the intent and why it was a mistake, especially when the commit[0] message reverting said functionality states “widespread criticism” citing this very HN article makes it look seemingly like the revert is due to negative PR opposed to a mistake. [0] https://github.com/microsoft/vscode/pull/313725/commits/1e70...
I am reverting it because there are bug in the feature and it obviously does not work as expected. Any feedback is important, HN or not.
Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#838Earlier quoted context omitted.
I'm not him, but it was pretty obvious that the comments section was going to be attracting more and more people saying the same thing that had already been said before, and that no useful discussion was going to be had. At some point the value of spamming everyone who commented on the issue with a notification (which puts an email in your inbox if you haven't changed the default setting) becomes lower and lower. I'v…
Thank you so much for explaining the exact reason I did it! I am reading all pings from GitHub on VS Code and this was just turning into a stream of spam that wasn't adding much new information.
Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#839Re: VS Code inserting 'Co-Authored-by Copilot' into commits regardless of usage
#840Earlier quoted context omitted.
I think there’s a few of us who appreciate you being up front. I’d question the intent and why it was a mistake, especially when the commit[0] message reverting said functionality states “widespread criticism” citing this very HN article makes it look seemingly like the revert is due to negative PR opposed to a mistake. [0] https://github.com/microsoft/vscode/pull/313725/commits/1e70...
I am reverting it because there are bug in the feature and it obviously does not work as expected. Any feedback is important, HN or not.