Amazon CodeGuru – Preview • Hacker News Board

Re: Amazon CodeGuru – Preview

#81

Post by cosmodisk » Tue, Dec 03, 2019, 9:06 PM UTC

scblock wrote: post #26

Please do us a favor and consolidate all these Amazon announcements into a single announcement page link. This is ridiculous.

I love Salesforce for this.Every release, there's one place with all the changes and new features.No need to play a detective trying to figure out

Re: Amazon CodeGuru – Preview

#82

Post by mping » Tue, Dec 03, 2019, 9:06 PM UTC

I'm wondering did anyone actually tried it? It's not impossible for an automated tool to give valuable feedback over a PR guys. Should be easier than a self driving car I guess

Re: Amazon CodeGuru – Preview

#83

Post by ecuaflo » Tue, Dec 03, 2019, 9:09 PM UTC

Why do this in the code review stage as opposed to in the code editor linting stage? I'd wanna have these suggestions before pushing.

Re: Amazon CodeGuru – Preview

#84

Post by udkl » Tue, Dec 03, 2019, 9:13 PM UTC

Reminds me of the security analysis tool from FB

https://engineering.fb.com/security/zoncolan/

https://www-wired-com.cdn.ampproject.org/c/s/www.wired.com/s...

Also reminds me of sonatype or findbugs which does something similar but works on a set of rules instead of on ML.

Re: Amazon CodeGuru – Preview

#85

Post by TheOperator » Tue, Dec 03, 2019, 9:14 PM UTC

mping wrote: post #82

I'm wondering did anyone actually tried it? It's not impossible for an automated tool to give valuable feedback over a PR guys. Should be easier than a self driving car I guess

Chess masters have long been combining human and computer analysis... even before computers were able to actually beat humans at chess.

Re: Amazon CodeGuru – Preview

#86

Post by eigenvalue » Tue, Dec 03, 2019, 9:14 PM UTC

They should compute the SHA512 hash of lines of code or code blocks from well-known open source projects and then just give you pre-computed "reviews" for those lines/blocks, and then only charge for "novel" code. Otherwise you would need to waste time segregating your original code from the various packages you use. And it seems unfair to charge customers for canned results that can be cached and served at very low cost.

Re: Amazon CodeGuru – Preview

#87

Post by stefano » Tue, Dec 03, 2019, 9:15 PM UTC

ehsankia wrote: post #70

james_s_tayler wrote: post #45

Earlier quoted context omitted.

Or a 35,000 line XML configuration file.

Now that I think of it, if it's paid by lines of code, it perversely incentives people to minimize the lines of code, no? Does it count white space and comments? Can I minify my code before passing it to this, then unminify it?

Can you just remove newlines from files? In most languages they're optional.

Re: Amazon CodeGuru – Preview

#88

Post by gcbw3 » Tue, Dec 03, 2019, 9:16 PM UTC

If it was minimally not garbage, they would have run it on any high profile open source project and promoted the results.

Hence, it is pure garbage.

Re: Amazon CodeGuru – Preview

#89

Post by millstone » Tue, Dec 03, 2019, 9:18 PM UTC

gcbw3 wrote: post #88

If it was minimally not garbage, they would have run it on any high profile open source project and promoted the results. Hence, it is pure garbage.

Many (most?) of the checks appear to be specific to Amazon libraries.

Re: Amazon CodeGuru – Preview

#90

Post by conwy » Tue, Dec 03, 2019, 9:22 PM UTC

It seems good for performance, and probably only that. I don't see anything in the pitch about readability, maintainability, extendability, security, usability/accessibility or portability.