Pull Request File Tree Feedback • Hacker News Board

Re: Pull Request File Tree Feedback

#71

Post by jacobegold » Sat, Mar 12, 2022, 5:10 PM UTC

radicality wrote: post #70

After many years at Facebook I’ve recently switched jobs and have to use GitHub now for work. Compared to Phabricator (FB’s code review tool), the GitHub code review (and code merge) processes seems extremely basic and clunky.

Try out Graphite! Half of us are ex-FB, so we get it.

https://graphite.dev/

Re: Pull Request File Tree Feedback

#72

Post by radicality » Sat, Mar 12, 2022, 5:44 PM UTC

jacobegold wrote: post #71

radicality wrote: post #70

After many years at Facebook I’ve recently switched jobs and have to use GitHub now for work. Compared to Phabricator (FB’s code review tool), the GitHub code review (and code merge) processes seems extremely basic and clunky.

Try out Graphite! Half of us are ex-FB, so we get it. https://graphite.dev/

That looks cool, I put my work and personal emails on the waitlist! GitHub review is just… awful

Side-note: I took a look at the ‘About’ page thinking ‘Hey, they said ex-FB, extremely unlikely but maybe i know someone’. Looking at your username I’m guessing you’re jacob gold and worked on messaging infra in NY. I used to work on Iris! Small world.

Re: Pull Request File Tree Feedback

#73

Post by jameslao » Sat, Mar 12, 2022, 7:20 PM UTC

radicality wrote: post #70

After many years at Facebook I’ve recently switched jobs and have to use GitHub now for work. Compared to Phabricator (FB’s code review tool), the GitHub code review (and code merge) processes seems extremely basic and clunky.

I'm also working on a code review app called Crocodile that addresses GitHub's shortcomings. Signups are open and feedback is always appreciated.

https://www.crocodile.dev

Re: Pull Request File Tree Feedback

#74

Post by jameslao » Sat, Mar 12, 2022, 7:56 PM UTC

eloisius wrote: post #57

jameslao wrote: post #36

If anyone is interested, I've been building a code review tool called Crocodile[0] that lets you review GitHub PRs. It has a similar file browser to the left plus floating comments, threaded discussions, and more. [0] https://www.crocodile.dev/

Just casually following this thread, this is the third SaaS I've seen offering an alternative code review tool to supplement GitHub. It's either sorely needed to make up for how bad GitHub is, or it's true that we engineers can't help but makes tools for people exactly like ourselves.

Probably a mix of both. Many of the founders of code review tools came from companies that had internal code review tools (Microsoft has CodeFlow, Google has Critique, Facebook has Phabricator) and they missed those tools after leaving those companies.

Re: Pull Request File Tree Feedback

#75

Post by eloisius » Sun, Mar 13, 2022, 6:49 AM UTC

iovrthoughtthis wrote: post #60

petepete wrote: post #59

Earlier quoted context omitted.

For the stuff I work on I prefer the big diffs to be hidden. It's nearly always yarn.lock and I have no desire to see that monstrosity in all its glory.

i have no idea why we include these in code reviews tbh

Not saying I review dependency locks as well as I should, but one reason to is to prevent supply chain attacks. E.g. making a typo that installs a malicious package. I recently saw a $60k beast of a machine with 64 cores get pwnd. We all wondered why “-bash” was burning 48 cores of CPU until I attached strace to it and we saw JSON RPC messages indicative of crypto mining. Everyone with access to the machine is trustworthy, but someone may have typo’d a pip install or something like that.

Re: Pull Request File Tree Feedback

#76

Post by marceloabsousa » Mon, Mar 14, 2022, 9:25 AM UTC

If you don't want just a tree but also a semantic diff that tells you what types and methods where actually changed check out Reviewpad (http://reviewpad.com).

Re: Pull Request File Tree Feedback

#77

Post by jacobegold » Mon, Mar 14, 2022, 3:46 PM UTC

radicality wrote: post #72

jacobegold wrote: post #71

Earlier quoted context omitted.

Try out Graphite! Half of us are ex-FB, so we get it. https://graphite.dev/

That looks cool, I put my work and personal emails on the waitlist! GitHub review is just… awful Side-note: I took a look at the ‘About’ page thinking ‘Hey, they said ex-FB, extremely unlikely but maybe i know someone’. Looking at your username I’m guessing you’re jacob gold and worked on messaging infra in NY. I used to work on Iris! Small world.

So funny :) I was on storage but was "moonlighting" on Iris for my last couple months at FB — what a small world!

Feel free to shoot me an email if you don't want to wait, although the list moves fairly quickly these days.