Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Fetch API has landed into Node.js

github.com

Post reply on HN
Print view View original

71–80 of 210 posts

Re: Fetch API has landed into Node.js

#71

Post by wruza »

sealthedeal wrote: post #66

Ive used Fetch in the past, great lib. I'm curious why Node core has decided to make this an official part of Node? From one perspective there could be a hard argument that this should never be a part of Node as it is an external library and not a building block of the language? Almost feels like feature creep for the core language? I know that's not the intent, but wanting to understand the logic behind this decisio…

I second this, since fetch is a wrapper around xhr (though doesn’t have to be because node is a non-restricted runtime), and it diverged already for redirect semantics. It’s news, but is it big?

Re: Fetch API has landed into Node.js

#72

Post by neves »

inglor wrote: post #4

Hey, Node core person here (and the person who triggered the land) - we're super excited for this and would love help and feedback. This is still experimental and we'd love to hear from the community what you'd like to see.

Where can I find an explanation about what is Fetch and why it should be in Node.js?

Re: Fetch API has landed into Node.js

#73

Post by inglor »

neves wrote: post #72
inglor wrote: post #4

Hey, Node core person here (and the person who triggered the land) - we're super excited for this and would love help and feedback. This is still experimental and we'd love to hear from the community what you'd like to see.

Where can I find an explanation about what is Fetch and why it should be in Node.js?

This is fetch: https://github.com/whatwg/fetch https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API

Here is discussion about it in Node with some (pretty old) discussion https://docs.google.com/document/d/1tn_-0S_FG_sla81wFohi8Sc8...

Re: Fetch API has landed into Node.js

#74

Post by inglor »

songzme wrote: post #37
inglor wrote: post #36

Earlier quoted context omitted.

First: not a stupid question - the release cadence, multiple release lines and other minutia of a project like Node are not something I'd expect users to be intimately familiar with! This _just landed today_. You can get it by building from master: ``` # there is more details in building.md git clone https://github.com/nodejs/node cd node # may need to pass --openssl-no-asm ./configure make -j12 ./out/Release/node --…

oh I see so when node v17.4.1 is released, I would be able to run node server.js --experimental-fetch

v17.5 but yeah

Re: Fetch API has landed into Node.js

#75

Post by neves »

neves wrote: post #72
inglor wrote: post #4

Hey, Node core person here (and the person who triggered the land) - we're super excited for this and would love help and feedback. This is still experimental and we'd love to hear from the community what you'd like to see.

Where can I find an explanation about what is Fetch and why it should be in Node.js?

It looks like it is a new standard: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API

I thought it was a Node popular library.

Re: Fetch API has landed into Node.js

#76

Post by wruza »

pitaj wrote: post #67
sealthedeal wrote: post #66

Ive used Fetch in the past, great lib. I'm curious why Node core has decided to make this an official part of Node? From one perspective there could be a hard argument that this should never be a part of Node as it is an external library and not a building block of the language? Almost feels like feature creep for the core language? I know that's not the intent, but wanting to understand the logic behind this decisio…

Fetch is a standard browser API.

And so are navigator, localStorage and classes under window, like EventTarget.

Re: Fetch API has landed into Node.js

#77

Post by sealthedeal »

sealthedeal wrote: post #66

Ive used Fetch in the past, great lib. I'm curious why Node core has decided to make this an official part of Node? From one perspective there could be a hard argument that this should never be a part of Node as it is an external library and not a building block of the language? Almost feels like feature creep for the core language? I know that's not the intent, but wanting to understand the logic behind this decisio…

FWIW, this was the answer I was hoping to get, grabbed from a separate comment :)

"With fetch available in node, we have a single, standardised, promise-based HTTP client Interface available on all (more or less common) JavaScript platforms.

This is great news for an ecosystem traditionally extremely fragmented and may lead the way to more consolidation in the JS library space. "

Re: Fetch API has landed into Node.js

#78

Post by inglor »

mschuetz wrote: post #65
inglor wrote: post #18

Earlier quoted context omitted.

Those have been supported for several years now :) You need to tell Node to use the format by either naming your file `.mjs` or setting `"type": "module"` in your `package.json` file. > Also why do so many libraries have this strange 5 line header code for this umd, amd, business. Is that to make their packages work with nodejs? That's just old for "adapt the module system" from the old days and libraries just didn't…

> either naming your file `.mjs` But why? This makes it much harder to ensure that identical code works in browser and nodejs, to the point where I sometimes just can't use nodejs. And I don't use package.json, so having to name files ".mjs" is a really painfull restriction.

Browsers will happily accept `.mjs` files they don't actually care about file extensions only about `Content-Type` and type=module on the script tag :]

Re: Fetch API has landed into Node.js

#79

Post by tshaddox »

zebracanevra wrote: post #45
inglor wrote: post #4

Hey, Node core person here (and the person who triggered the land) - we're super excited for this and would love help and feedback. This is still experimental and we'd love to hear from the community what you'd like to see.

Is there any chance to break spec and allow manual redirect handling? the fetch API makes a lot of sense in a browser, but imo this is a pretty crucial feature that undici's implementation lacks. [0] Deno decided to break spec [1][2] so the following code works fine: fetch('https://httpbin.org/status/302', {redirect: 'manual'}) .then(res => console.log(res.status, res.headers)) In undici this will succeed but with re…

Is this not what redirect: “manual” is in the MDN fetch docs?

https://developer.mozilla.org/en-US/docs/Web/API/fetch

Re: Fetch API has landed into Node.js

#80

Post by inglor »

bachmeier wrote: post #61

Good that some people are happy about this, but it really is pointless to post a link to "lib: add fetch" followed by code diffs. HN should have a requirement that there be an actual post, rather than a discussion starter for those in a particular community. All you'd have to do is type in a brief text post with an explanation and then link to the code diffs for those interested.

There will be a blog post on this in the Node.js blog and official media communication. This _just_ landed today and I suspect the HN crowd are more in the "get news early" camp and not "wait for the official press release" camp.
Post reply on HN