Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Vuejs rejects close to 75% of outside contributions

merge-chance.info

Post reply on HN
Print view View original

71–80 of 92 posts

Re: Vuejs rejects close to 75% of outside contributions

#71

Post by TiccyRobby »

judge2020 wrote: post #5
BugsJustFindMe wrote: post #2

Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.

Ya, here's some examples of spam: https://github.com/vuejs/vue/pull/11847/files https://github.com/vuejs/vue/pull/11853/files https://github.com/vuejs/vue/pull/11820/files https://github.com/vuejs/vue/pull/11818/files All within the last month. Maybe there's some tutorial for 'how to submit a PR on GitHub' that links to Vue.js and people are following that?

Damn. They need to somehow discourage that. Do they blacklist those people?

Re: Vuejs rejects close to 75% of outside contributions

#72

Post by ng12 »

mlthoughts2018 wrote: post #47
ng12 wrote: post #33

Earlier quoted context omitted.

I think the opposite: it's a sign that your API is too wide and users expect more special cases and edge features to solve their needs.

If a user felt that way, it would make no sense for them to choose Vue. Vue’s up-front, stated design goal is omit special cases or edge features intentionally and directly assert that’s not a good way to design a framework. Vue may be right or wrong, but nobody wishing for special case features can claim to be surprised. If you picked Vue knowing you need a bunch of special case features, that’s on you.

Right, I think this is evidence that they're not doing as well at that stated goal as they could be.

Re: Vuejs rejects close to 75% of outside contributions

#73

Post by feoren »

elygre wrote: post #69
feoren wrote: post #63

Earlier quoted context omitted.

Everyone always needs a bunch of "special case features". Always. If you're not doing something new, why are you bothering to write code?

That's like saying that if you don't need to invent new words, why are you bothering to write books.

The abstractions a framework makes available are not analogous to words, but rather ideas. Indeed you should not bother writing a book if you have no new ideas.

Re: Vuejs rejects close to 75% of outside contributions

#74

Post by remram »

zinekeller wrote: post #46
gieksosz wrote: post #25

Earlier quoted context omitted.

On top of that some repos, like Bazel for instance close all PRs and import them via a process which happens outside GitHub. Some repositories do not use GitHub organisations at all, other do it a lot - those factors make merge-chance.info analysis more difficult, but I still think it is interesting. I hope it might even help someone chose what project to contribute to.

I think that if you want to contribute, they should at least be upfront on the processes, or even the absence of it. Some do not accept at all, some do only accept on bugfixes, and some are happy to extend the project. The chance of merging of course is a decent barometer for contributors who wants to work on projects who are allegedly open to contributions, but I will not use it as a barometer of the quality of the…

This might be on GitHub more than maintainers, as there is no option to disable the pull requests feature right now (or to replace it with a link to what you actually use).

Re: Vuejs rejects close to 75% of outside contributions

#75

Post by mlthoughts2018 »

feoren wrote: post #63
mlthoughts2018 wrote: post #47

Earlier quoted context omitted.

If a user felt that way, it would make no sense for them to choose Vue. Vue’s up-front, stated design goal is omit special cases or edge features intentionally and directly assert that’s not a good way to design a framework. Vue may be right or wrong, but nobody wishing for special case features can claim to be surprised. If you picked Vue knowing you need a bunch of special case features, that’s on you.

Everyone always needs a bunch of "special case features". Always. If you're not doing something new, why are you bothering to write code?

I use Vue and haven’t found it hinders me from doing this myself. Are you suggesting Vue should not just release a framework but also solve every user’s special case? Your comment isn’t making sense to me.

Re: Vuejs rejects close to 75% of outside contributions

#76

Post by mlthoughts2018 »

ng12 wrote: post #72
mlthoughts2018 wrote: post #47

Earlier quoted context omitted.

If a user felt that way, it would make no sense for them to choose Vue. Vue’s up-front, stated design goal is omit special cases or edge features intentionally and directly assert that’s not a good way to design a framework. Vue may be right or wrong, but nobody wishing for special case features can claim to be surprised. If you picked Vue knowing you need a bunch of special case features, that’s on you.

Right, I think this is evidence that they're not doing as well at that stated goal as they could be.

Exactly, the users are not doing well because they’re expecting to be able to misuse Vue and demand special case features, while Vue itself is doing good by resisting this and sticking to the plan in terms of framework design.

Re: Vuejs rejects close to 75% of outside contributions

#78

Post by sdfhbdf »

zhirzh wrote: post #53

not sure if there's a point to checking this stat this is interesting, though checkout vim. it has 0% acceptance: https://merge-chance.info/target?repo=vim/vim

Yeah looking at the PRs they're improperly marked as closed instead of merged because the contributors seems to merge manually.

Re: Vuejs rejects close to 75% of outside contributions

#79

Post by mcosta »

devdas wrote: post #57
ipsocannibal wrote: post #36

Earlier quoted context omitted.

You could at least post a link or say why this is a good book to read. While we are suggesting books I think "The Making of the Atomic Bomb" is a great work highlighting the political motives behind the making of the 20th centuries most important "tool".

The book is pretty much a thesis on why code is law, and therefore very political.

I can't put police at your door, whatever code I write.

Re: Vuejs rejects close to 75% of outside contributions

#80

Post by mcosta »

jdieiueejjene wrote: post #13

The best part about Vue is it isn’t sponsored by giant evil corporation like Facebook who have enabled violence and racism for the past 4 years. We as developers need to do better and support people like Evan out there. Eventually, we should also hold individual engineers who work at Facebook/similar accountable to a higher standard and reject their software even if it’s open source or wonderful (React).

Is that racism as defined by Luther King or as defined by anti-racism?

https://www.vanderbilt.edu/oacs/wp-content/uploads/sites/140...

Post reply on HN