Live data from Hacker News

Angular 1.x Banned from Firefox Addons

github.com

71–80 of 222 posts

Re: Angular 1.x Banned from Firefox Addons

#71

Earlier quoted context omitted.

Curious, do you use a password wallet/manager application, and if so how do you get passwords out of it and into the browser? I'd like to know if there's a better solution. (I use a browser extension.)

I think his point is that running the entire Angular 1.x framework to power a browser extension gives a large attack surface.

Thanks for the clarification.

Re: Angular 1.x Banned from Firefox Addons

#72
post #39

That doesn't make much sense. If there's a vulnerability in Angular, doesn't it mean that there's a vulnerability in the JS engine that runs the Firefox addons? And in that case, can't an attacker replicates whatever Angular is doing to make an exploit? Basically it sounds like it's something for Mozilla to fix, not the Angular team.

Angular runs eval-like functions on HTML in the DOM. The DOM can be controlled by the webpage. When Angular runs in an extension (which has more permissions than the page) using the DOM controlled by the webpage, then the webpage can write code into the DOM that Angular executes from within the extension's security context. It's not the browser's fault that Angular trusts the webpage's DOM like that; Angular just isn…

But Angular only reads HTML that it's told to read, specified by the "ng-app" attribute/directive.

Re: Angular 1.x Banned from Firefox Addons

#73
post #46
post #35

Earlier quoted context omitted.

I'd agree if I actually framed it as a legitimate theory. But I didn't.

What do you mean by claiming to not have framed it as a legitimate theory; you're saying it's an illegitimate theory, as in, you yourself don't believe it's true?

His statement was literally correct, and useful in highlighting a different perspective on what is known to be known. The negativity seems to stem from not taking it literally.

Re: Angular 1.x Banned from Firefox Addons

#74
post #64

Earlier quoted context omitted.

Which is referring to the possibility that the application may not be using some feature that is affected by this supposed top secret vulnerability.

If you're the engineer in question (since your comment history suggests you work at Bitwarden), you should explicitly state that and explain that ignoring any vulnerability was not the intent of your comment.

Thanks. I updated the comment.

Re: Angular 1.x Banned from Firefox Addons

#75
post #47

Earlier quoted context omitted.

Mozilla is probably unable to disclose not just the vulnerability, but other surrounding info they may have been provided, including which other parties have received that info. They are not saying the Angular team is unaware of the problem, right? Only that they themselves are not the ones reporting it. If you don't honor such request without a VERY STRONG reason, nobody in their right mind will ever disclose anythi…

"They are not saying the Angular team is unaware of the problem, right?" Are we just going to assume the folks at Mozilla are clairvoyants? How would they know what the Angular team knows? If it's known in general that the Angular team knows about this issue already, perhaps through other means, then the statement that they haven't disclosed this to the Angular team makes no sense. The statement is, "Mozilla is choos…

Well, there's https://github.com/mozilla/addons-linter/issues/1000#issueco... ...

Re: Angular 1.x Banned from Firefox Addons

#76
post #63

Ugh, this kind of thing gets my blood boiling. It was clearly said that _a security researcher_ disallowed Mozilla from reporting the vulnerability forward. It's the individual to blame, not Mozilla. In any case Personally I wouldn't want to run a large priviledged application as a browser extension when it's interacting with random webpages AND handling my security credentials. Too much attack surface.

Curious, do you use a password wallet/manager application, and if so how do you get passwords out of it and into the browser? I'd like to know if there's a better solution. (I use a browser extension.)

GNU password manager for me, which interacts with the clipboard (or lets you do so on your own if you prefer).

The same is true of Keepass for windows, although IIRC you can also let Keepass actually alt-tab to the last window and do the typing for you.

Re: Angular 1.x Banned from Firefox Addons

#77
post #6

So someone found some sort of vulnerability in Angular 1, told Mozilla about it, but told them not to tell the Angular team? What is going on here?

It's not the "some sort of vulnerability", it's a critical vulnerability in the design of the Angular v1, a long known vulnerability in fact.

Re: Angular 1.x Banned from Firefox Addons

#79
Note that the Angular team is working with Mozilla and the researcher on this (see https://github.com/mozilla/addons-linter/issues/1000#issueco...) and that NDAs are a real, if insane, thing still to this day, and there is literally no way to legally compel any party to admit to being under NDA except in a court of law.

Should the researcher have told the Angular team? Yes. Should they have told the entire world? Probably no. Should Mozilla tell the world? Probably even less no. As long as the parties are talking (which they are), this is an unfinished security review on lock-down to prevent exploitation in the interrim.

Re: Angular 1.x Banned from Firefox Addons

#80
post #63

Ugh, this kind of thing gets my blood boiling. It was clearly said that _a security researcher_ disallowed Mozilla from reporting the vulnerability forward. It's the individual to blame, not Mozilla. In any case Personally I wouldn't want to run a large priviledged application as a browser extension when it's interacting with random webpages AND handling my security credentials. Too much attack surface.

The issue with Angular in extensions has to do with the fact it uses eval on the page DOM, which is controlled by the webpage. The webpage can put code into the DOM, and then let Angular execute it from within the higher-privileged extension.

Angular http://angularjs.blogspot.com/2016/09/angular-16-expression-...

I'm not going to fault someone for not reporting a specific vulnerability with a specifically not-security feature that has already been removed.

Post reply on HN