Don't use -Werror • Hacker News Board

Re: Don't use -Werror

#71

Post by Retric » Mon, Jul 25, 2016, 11:40 AM UTC

raverbashing wrote: post #70

Retric wrote: post #69

Earlier quoted context omitted.

If writing idiomatic code is causing readability problems your doing it wrong. Successful code is read far more than it's written and even machine generated code needs to be well written to locate bugs etc. iF YoR CodE LoOks lIKe tHIs, yOu FaIl.

> If writing idiomatic code is causing readability problems your doing it wrong. Sure, because breaking a 82 char line in python in 2 lines (because pep8) is much more readable than leaving it at 82 chars.

A 65+ character line is already ugly. 80 is an arbitrary but sensible cutoff.

Re: Don't use -Werror

#72

Post by raverbashing » Mon, Jul 25, 2016, 11:52 AM UTC

Retric wrote: post #71

raverbashing wrote: post #70

Earlier quoted context omitted.

> If writing idiomatic code is causing readability problems your doing it wrong. Sure, because breaking a 82 char line in python in 2 lines (because pep8) is much more readable than leaving it at 82 chars.

A 65+ character line is already ugly. 80 is an arbitrary but sensible cutoff.

Speak for yourself

a = "a long message with 70 chars..."

vs

a = ("a long message..."

     " with 70 chars...")

Re: Don't use -Werror

#73

Post by Retric » Mon, Jul 25, 2016, 12:20 PM UTC

raverbashing wrote: post #72

Retric wrote: post #71

Earlier quoted context omitted.

A 65+ character line is already ugly. 80 is an arbitrary but sensible cutoff.

Speak for yourself a = "a long message with 70 chars..." vs a = ("a long message..." " with 70 chars...")

You should not be using long messages in code, for one thing you can't localize them across multiple languages. You can do:

  A = \
  "A really long string"

But, the odds are really good you are making a mistake.

Re: Don't use -Werror

#74

Post by raverbashing » Mon, Jul 25, 2016, 2:21 PM UTC

Retric wrote: post #73

raverbashing wrote: post #72

Earlier quoted context omitted.

Speak for yourself a = "a long message with 70 chars..." vs a = ("a long message..." " with 70 chars...")

You should not be using long messages in code, for one thing you can't localize them across multiple languages. You can do: A = \ "A really long string" But, the odds are really good you are making a mistake.

Readability is still bad in your example, and not all projects require localization (not to mention usage of \ is not encouraged)