Live data from Hacker News

We are ruthless on code reviews

techblog.workiva.com

71–72 of 72 posts

Re: We are ruthless on code reviews

#71
post #49

Earlier quoted context omitted.

Reading it again, I can see that. However, I personally am a fan of rigorous - not ruthless - code review, the purpose and level of which has previously been explained to a new employee. Obviously being an asshole is out of line, and if someone is being a dick in code review, that's a problem with the reviewer. But I think that being rigorous about maintaining consistency and quality is important.

Decent positions dont usually need disclaimers. Theres a difference between preaching, teaching, and coaching. Its not obvious that being an asshole is out of line. You make it sound like this mystery of pure "collaboration" is all about giving raw feedback. Raw feedback is inferior to polished feedback. Its just as important to communicate in positive ways instead of throwing this ruthless word around. Honestly, you…

Haha ok dude. I didn't write the article. And that wasn't a disclaimer; I was empathising with your point.

Re: We are ruthless on code reviews

#72
post #71

Earlier quoted context omitted.

Decent positions dont usually need disclaimers. Theres a difference between preaching, teaching, and coaching. Its not obvious that being an asshole is out of line. You make it sound like this mystery of pure "collaboration" is all about giving raw feedback. Raw feedback is inferior to polished feedback. Its just as important to communicate in positive ways instead of throwing this ruthless word around. Honestly, you…

Haha ok dude. I didn't write the article. And that wasn't a disclaimer; I was empathising with your point.

Oh, well carry on then, my bad ;-)
Post reply on HN