For those who aren't tempted to click through, the buried lede for this (and why I'm glad it's being linked to again today) is that "99% of the code in this PR [for llama.cpp] is written by DeekSeek-R1" as conducted by Xuan-Son Nguyen. That seems like a notable milestone.
>99% of the code in this PR [for llama.cpp] is written by DeekSeek-R1 Yes, but: "For the qX_K it's more complicated, I would say most of the time I need to re-prompt it 4 to 8 more times. The most difficult was q6_K, the code never works until I ask it to only optimize one specific part, while leaving the rest intact (so it does not mess up everything)" [0] And also there: "You must start your code with #elif defined…
I do not understand why GGML is written this way, though. So much duplication, one variant per instruction set. Our Gemma.cpp only requires a single backend written using Highway's portable intrinsics, and last I checked for decode on SKX+Zen4, is also faster.