Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

NPM website was down

status.npmjs.org

Post reply on HN
Print view View original

61–65 of 65 posts

Re: NPM website was down

#61

Post by justinclift »

skullone wrote: post #58
justinclift wrote: post #46

Earlier quoted context omitted.

Not sure about that "million characters", but we've been bitten by it in our production systems. :( Thus, we're moving off GitLab.

What use case does a million character PR have?

When an automated system creates a PR for merging from an existing dev branch (that's been extensively tested) to "master" (or "main").

The "surprise, you can't review all the files in your PR" using GitLabs standard web based tooling makes it a no-go.

Re: NPM website was down

#63

Post by sofixa »

justinclift wrote: post #61
skullone wrote: post #58

Earlier quoted context omitted.

What use case does a million character PR have?

When an automated system creates a PR for merging from an existing dev branch (that's been extensively tested) to "master" (or "main"). The "surprise, you can't review all the files in your PR" using GitLabs standard web based tooling makes it a no-go.

That's interesting because GitHub's web UI craps out at much less than 1 million lines. It refuses to open even low thousand line diffs.

Re: NPM website was down

#64

Post by justinclift »

sofixa wrote: post #63
justinclift wrote: post #61

Earlier quoted context omitted.

When an automated system creates a PR for merging from an existing dev branch (that's been extensively tested) to "master" (or "main"). The "surprise, you can't review all the files in your PR" using GitLabs standard web based tooling makes it a no-go.

That's interesting because GitHub's web UI craps out at much less than 1 million lines. It refuses to open even low thousand line diffs.

Yeah, agreed it's not great for that. I'm not real happy with GitHub's worsening UX either, but it'll at least show the _names_ of all the files in the PR.

With GitLab, when you hit the rate limit, any file "past" that limit doesn't even show that it exists in the MR. It just looks like the MR is missing a bunch of stuff, with no workaround available. :( :( :(

Re: NPM website was down

#65

Post by xp84 »

sofixa wrote: post #63
justinclift wrote: post #61

Earlier quoted context omitted.

When an automated system creates a PR for merging from an existing dev branch (that's been extensively tested) to "master" (or "main"). The "surprise, you can't review all the files in your PR" using GitLabs standard web based tooling makes it a no-go.

That's interesting because GitHub's web UI craps out at much less than 1 million lines. It refuses to open even low thousand line diffs.

I’ve personally been deeply unappreciated of Github’s changes in the last few years to automatically not show diffs to “large files” without having to click to open them - which seems to be a threshold that continues to shrink. Maybe like 3 screenfuls of content is the limit now per file. It’s crazy.
Post reply on HN