GitLab 8.9 released • Hacker News Board

Re: GitLab 8.9 released

#61

Post by superuser2 » Mon, Jun 27, 2016, 11:51 PM UTC

sytse wrote: post #57

superuser2 wrote: post #53

Earlier quoted context omitted.

This is nice, but does not solve the problem of giving a user the power to approve merge requests but not accidentally "git push origin master."

With protected branches you can prevent force pushes to master. You would have to do a manual merge and then git push origin master to cause a problem I think.

I don't generally use feature branches on solo projects. Working directly on master (and pushing origin master at arbitrary moments to back up my work) is a deeply ingrained habit.

A code review tool that's off by default and trivial to bypass in your sleep is a poor code review tool.

This is easy to prevent in Phabricator, which will block pushes to master if they contain changes not also present in an approved unit of code review. I run into that wall a few times a week, and am reminded to move my commits into a branch.

Re: GitLab 8.9 released

#62

Post by sytse » Tue, Jun 28, 2016, 12:02 AM UTC

superuser2 wrote: post #61

sytse wrote: post #57

Earlier quoted context omitted.

With protected branches you can prevent force pushes to master. You would have to do a manual merge and then git push origin master to cause a problem I think.

I don't generally use feature branches on solo projects. Working directly on master (and pushing origin master at arbitrary moments to back up my work) is a deeply ingrained habit. A code review tool that's off by default and trivial to bypass in your sleep is a poor code review tool. This is easy to prevent in Phabricator, which will block pushes to master if they contain changes not also present in an approved unit…

Thanks, good point. We're extending protected branches so all code will have to undergo a code review, see https://gitlab.com/gitlab-org/gitlab-ce/issues/18193

Re: GitLab 8.9 released

#63

Post by juandazapata » Wed, Jun 29, 2016, 1:37 PM UTC

connorshea wrote: post #33

juandazapata wrote: post #10

It's fantastic for us that Gitlab keeps putting pressure on Github. I hope they keep this strike for a long time. Having said that, they really must improve the performance. I tried to make the switch from Github to Gitlab a couple of months ago, but the general speed and responsiveness is just below the line. Keep up the good work.

Try again in a few months and it should be a lot better, lots of work has been going into improving performance across the board, e.g. this week we've had two pretty big changes: https://www.scribd.com/doc/316471059/GitLab-Infrastructure-2... and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4802 :)

I'm afraid users don't have the time/opportunity to try the same service over and over again. If a service didn't work for them, it's mostly sure that they're not coming back.