Live data from Hacker News

When hiring developers, have the candidate read existing code

freakingrectangle.wordpress.com

561–565 of 565 posts

Re: When hiring developers, have the candidate read existing code

#561

Earlier quoted context omitted.

Bad code + time allowed to clean it up = perfectly well-defined business requirements + a license to think about code craftsmanship. That's a lot of people's dream job.

Not sure if it's my "dream job". But yeah, when you think about -- a sufficiently fecal-encrusted, lost-cause codebase is almost indistinguishable from an actual greenfield opportunity.

The Strangler: did someone call me?!

Re: When hiring developers, have the candidate read existing code

#562

Earlier quoted context omitted.

In my professional experience there is a lot of poorly writtem, convoluted spaghetti code, that is extremely hard to follow. Im not sure why people seem think reading code is easier than writing code... this is often not the case.

And OO spaghetti ("lasagna") can be the worst. Class hierarchies 6 levels deep. Some methods overridden. Needless abstract classes with single implementations. "Logic" spread out all over the code base.

100% why I prefer avoiding languages that fall into the OO+Inheritance trap, if I can help it.

Re: When hiring developers, have the candidate read existing code

#563

I like this approach. Far to often I’ve interviewed at places and been grilled by the interviewer only to find out when you start the quality isn’t great, what you where grilled on you won’t be working on “as that’s to hard” or “we don’t do that” despite being grilled on it and the level of skill not to great they just want senior people. It’s the bait and switch. At least being taken through existing code you know w…

> Bonus points for no PR’s and trunk driven development as that shows a very mature team. Ugh, pass. Trunk development is fine. Skipping PRs just brings back nightmares of SVN. Even if 90% of PRs are approved without comment, it's extremely helpful for everyone to have a second set of eyes on work before it is merged in.

It really seems like this "no PR" idea is having a moment on HN. I can't tell if it's just engagement bait contrarianism or genuine. That any developer would trust themselves even to just not make simple typo's is baffling to me.

Maybe the kernel of a good idea in the comment: A team that prioritizes reviews, such that PR's are not a significant hurdle, is indeed a sign of a mature team.

Re: When hiring developers, have the candidate read existing code

#564

Earlier quoted context omitted.

Large companies can and often do afford sizeable percentage of workforce making zero to negative contributions. This would be devastating for a small team with a finite runway

Indeed! But it's generally much harder to reach consensus and actually remove someone at large companies. Especially for a startup with limited runway it's existential, whereas at a large company there is far more to lose from a lawsuit than from eating a high salary as a net negative.

> But it's generally much harder to reach consensus and actually remove someone at large companies

Disagree. Big corps have well established processes for this and deep pockets to pay lawyers out of in case of any wrongful termination claims against them

Re: When hiring developers, have the candidate read existing code

#565

Earlier quoted context omitted.

I honestly can't tell if this is satire or an interesting look into an alien (to me) work culture.

Gotta tap into their primal instincts. I would also sound a fire alarm, to see how they react to working under stress, and measure how much their pupils dilate.

Imagine how valuable pupil dilation would be to a giant tech company pushing infinite scrolling with advertisements to a user base capturing most of America.

...Anyone know if Oculus has been bought yet?

Post reply on HN