Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Bug 1202858 – Restarting squid results in deleting all files in hard-drive

bugzilla.redhat.com

Post reply on HN
Print view View original

51–60 of 179 posts

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#51

Post by thaumaturgy »

ato wrote: post #45
rachelbythebay wrote: post #36

Earlier quoted context omitted.

squid-3.1.10-29.el6.src.rpm (from ftp.redhat.com, buried where they keep SRPMs) has squid.init within, and that file has no mention of SQUID_PIDFILE_DIR. A few other spot-checked versions are the same way. https://github.com/mozilla-services/squid-rpm/blob/master/SO... ... however ... whatever that is, does. Did they take this upstream init script somehow?

This looks like it: https://bugzilla.redhat.com/show_bug.cgi?id=1102343 I guess they applied that change which was obviously written against a very different init script where the variable is actually defined, got QA to test it and immediately backed it out.

Oh, good call. Yeah, you found it.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#52

Post by lambeosaurus »

jedisct1 wrote: post #47

My good old trick to mitigate that is: touch /-@ I also always do it in my home directory: touch ~/-@ That's the first thing I do on a new host. When accidentally running rm -f *, the command expands to -@ first, which is not a valid option and makes the command fail before doing any harm rm: illegal option -- @ usage: rm [-f | -i] [-dPRrvW] file ...

As someone who uses the commandline a lot but isn't exactly a wizard, why does this work?

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#53

Post by lsb »

lambeosaurus wrote: post #52
jedisct1 wrote: post #47

My good old trick to mitigate that is: touch /-@ I also always do it in my home directory: touch ~/-@ That's the first thing I do on a new host. When accidentally running rm -f *, the command expands to -@ first, which is not a valid option and makes the command fail before doing any harm rm: illegal option -- @ usage: rm [-f | -i] [-dPRrvW] file ...

As someone who uses the commandline a lot but isn't exactly a wizard, why does this work?

globbing expression expand to all the files that match.

if a directory has 1.txt, 2.txt, and 3.txt then > expands to "rm 1.txt 2.txt 3.txt" and is then executed.

if you have -@, 1.txt, 2.txt, and 3.txt, that expands to >, and that can't execute.

(if you really wanted to remove your -@ you'd do > because a double-dash signals the end of command-line options.)

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#54

Post by ulrikrasmussen »

lambeosaurus wrote: post #52
jedisct1 wrote: post #47

My good old trick to mitigate that is: touch /-@ I also always do it in my home directory: touch ~/-@ That's the first thing I do on a new host. When accidentally running rm -f *, the command expands to -@ first, which is not a valid option and makes the command fail before doing any harm rm: illegal option -- @ usage: rm [-f | -i] [-dPRrvW] file ...

As someone who uses the commandline a lot but isn't exactly a wizard, why does this work?

The * is expanded by the shell to a space-delimited list of filenames, but the shell does not adequately escape filenames that can be misinterpreted as arguments to 'rm'.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#55

Post by JoshTriplett »

jedisct1 wrote: post #47

My good old trick to mitigate that is: touch /-@ I also always do it in my home directory: touch ~/-@ That's the first thing I do on a new host. When accidentally running rm -f *, the command expands to -@ first, which is not a valid option and makes the command fail before doing any harm rm: illegal option -- @ usage: rm [-f | -i] [-dPRrvW] file ...

That won't actually help with rm -rf /* , only with rm -rf * in / or $HOME.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#56

Post by ioquatix »

jedisct1 wrote: post #47

My good old trick to mitigate that is: touch /-@ I also always do it in my home directory: touch ~/-@ That's the first thing I do on a new host. When accidentally running rm -f *, the command expands to -@ first, which is not a valid option and makes the command fail before doing any harm rm: illegal option -- @ usage: rm [-f | -i] [-dPRrvW] file ...

Or just use zsh.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#57

Post by ulrikrasmussen »

jedisct1 wrote: post #47

My good old trick to mitigate that is: touch /-@ I also always do it in my home directory: touch ~/-@ That's the first thing I do on a new host. When accidentally running rm -f *, the command expands to -@ first, which is not a valid option and makes the command fail before doing any harm rm: illegal option -- @ usage: rm [-f | -i] [-dPRrvW] file ...

While this is a really nice hack, stuff like this is also the reason I feel really uneasy when writing shell scripts. What works now may suddenly break in the future due to inadequate escaping of filenames.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#59

Post by miles »

jedisct1 wrote: post #47

My good old trick to mitigate that is: touch /-@ I also always do it in my home directory: touch ~/-@ That's the first thing I do on a new host. When accidentally running rm -f *, the command expands to -@ first, which is not a valid option and makes the command fail before doing any harm rm: illegal option -- @ usage: rm [-f | -i] [-dPRrvW] file ...

Neat idea! Just tested that in an OS X 10.8 virtual machine; while it works nicely against "rm -rf *", sadly it does not help stop an accidental sudo rm -rf / or ~/. Also, "touch ~-@" created a file in the home directory called "~-@"; in order to set the correct filename, I cd'd into ~ and then ran "touch ./-@".

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#60

Post by amadvance »

jedisct1 wrote: post #47

My good old trick to mitigate that is: touch /-@ I also always do it in my home directory: touch ~/-@ That's the first thing I do on a new host. When accidentally running rm -f *, the command expands to -@ first, which is not a valid option and makes the command fail before doing any harm rm: illegal option -- @ usage: rm [-f | -i] [-dPRrvW] file ...

Likely you mean: touch ~/-@
Post reply on HN