Live data from Hacker News

Carrot Disclosure: Forgejo

dustri.org

51–60 of 60 posts

Re: Carrot Disclosure: Forgejo

#51
post #43

Earlier quoted context omitted.

Maybe one showing that the change doesn't make it worse. Here's the code change: - + I know zero about this code path, but suppose it's expected that `${$(this).data('href')}` is already a properly quoted value, like `" https://example.com "`. Then the first line expands to: and the second expands to: which would have all kinds of room for mischief. Or suppose the template engine auto-quotes values that it injects, s…

I wonder why they didn't change it to use DOM APIs instead. Related comment: https://news.ycombinator.com/item?id=47945472

Not sure. Are those APIs widely supported now? This is far outside my expertise and I don't know the current state of the art.

Re: Carrot Disclosure: Forgejo

#52

There’s an old cryptography story. A cryptographer friend tells the story of an amateur who kept bothering him with the cipher he invented. The cryptographer would break the cipher, the amateur would make a change to “fix” it, and the cryptographer would break it again. This exchange went on a few times until the cryptographer became fed up. When the amateur visited him to hear what the cryptographer thought, the cry…

And who in the OP's post is the cryptographer, and who's the amateur, in this allegory?

Re: Carrot Disclosure: Forgejo

#53
Forgejo has responded:

> The author of the recent 'Carrot disclosure' blog post has contacted the Forgejo Security team with their findings. The issues raised concern defence-in-depth improvements and denial-of-service risks. There is no known RCE exploit possible without internal server credentials.

> We believe these findings can be addressed publicly. The security team will open issues where approaches to implement new defensive measurements will be discussed, we believe there's no single answer and as such appreciate the opinion of other Forgejo contributors on this matter.

https://floss.social/@forgejo/116494295922963052

Re: Carrot Disclosure: Forgejo

#54
post #28

This entire post reads as rage bait. They’re mad because Forgejo has … a process? And what are these vulnerabilities, concretely? > But given the sorry state of the codebase I honesty want a refund on the 10 minutes I wasted reading this.

I cracked at the last statement, lol. Really encapsulates my overall feeling reading some HN submissions lately.

Re: Carrot Disclosure: Forgejo

#55

Forgejo has responded: > The author of the recent 'Carrot disclosure' blog post has contacted the Forgejo Security team with their findings. The issues raised concern defence-in-depth improvements and denial-of-service risks. There is no known RCE exploit possible without internal server credentials. > We believe these findings can be addressed publicly. The security team will open issues where approaches to implemen…

Okay, this sounds familiar.

If you run Claude Opus 4.6 at max settings on forgejo repo, it will give you a bunch of RCE's ... that need prior knowledge of the server internal token :) You have to tell the stupid LLM that these attacks doesn’t make sense.

The author seem to be a experienced security researcher. I am surprised he didn't catch this.

Re: Carrot Disclosure: Forgejo

#56

Earlier quoted context omitted.

The author quite clearly outlines their reasoning for this in the article: > Carrot Disclosure, dangling a metaphorical carrot in front of the vendor to incentivise change. The main idea is to only publish the (redacted) output of the exploit for a critical vulnerability, to showcase that the software is exploitable. Now the vendor has two choices: either perform a holistic audit of its software, fixing as many issue…

Seems like grandstanding bad faith to me. They didn't even bother to follow the established disclosure policy for this project because the author feels this quality of the code is so crap, so instead does this...

Maybe, but I can see why people don't want to deal with red tape to do someone a favour.

Once I tried to help an open source project with a bug and was rejected because I didn't agree to support the Ukraine, that all sexual orientations are equal, or whatever else the long winded contributor rules were.

The issue isn't that I don't support those things, it's more that it's like someone handing me a 3 page form to fill out for picking their keys up for them.

There also may be conventions on disclosure and exploits, but they're not based on the law or rules of society.

Re: Carrot Disclosure: Forgejo

#57
Let's go one step further and think about why OSS maintainers generally approach security vulnerabilities the way they do (even pre-AI), and why some people has a significant negative reaction to this type of bug/security/issue reporting approach.

What happens if they treat every single report with the same effort and seriousness regardless of how it is reported? What happens if they dedicate too much effort in wild goose hunts while disregarding the more mundane/concrete security and maintenance work? How would an attacker take advantage of this process?

If you work in software, maybe you've encountered this yourself, in orgs where they don't have good processes around reporting bugs/issues. You essentially get DoSed by noise. You get tons of issues from customers (or internal stakeholders representing them), some barely describing stuff like "hey X can access Y, don't think they should" without any context (or even refusing to provide further information even after you ask), forcing you/CS to prune down all possible paths based on audit logs and their permission settings and so on.

Customers (in this case I'd say OSS users are customers too) can say "yeah this is the responsibility of the maintainers/vendors, why should I even care to report things a certain way, be glad I even told you at all" but IME this social posture is terrible for both parties. Even in commercial relationships, the best customers I've had were ones that reported issues that were concrete and reproducible. The chances I can fix it almost immediately goes up in orders of magnitude. The customer gets what they want and my job is simpler.

Even the core claim of the article, "this is a systemic issue", isn't fixed by a carrot disclosure. They don't imply an organizational/structural issue, merely a legacy one (inheriting stuff from gitea/gogs). What do you gain more by putting social-political pressure on an OSS project, if it's not a social-political problem?

The post reads more like an emotional response (frustration) rather than a productive one.

Re: Carrot Disclosure: Forgejo

#59

There’s an old cryptography story. A cryptographer friend tells the story of an amateur who kept bothering him with the cipher he invented. The cryptographer would break the cipher, the amateur would make a change to “fix” it, and the cryptographer would break it again. This exchange went on a few times until the cryptographer became fed up. When the amateur visited him to hear what the cryptographer thought, the cry…

And who in the OP's post is the cryptographer, and who's the amateur, in this allegory?

I think the OP is presenting themselves as the cryptographer, and the authors behind Forgejo as the amateur. At this point they've only filled one envelope but believe there is many more to find, and are hoping that in the process of tracking down this one they'll find more.

Re: Carrot Disclosure: Forgejo

#60
post #43

Earlier quoted context omitted.

I wonder why they didn't change it to use DOM APIs instead. Related comment: https://news.ycombinator.com/item?id=47945472

Not sure. Are those APIs widely supported now? This is far outside my expertise and I don't know the current state of the art.

Yes, document.createElement is widely supported.
Post reply on HN