Earlier quoted context omitted.
> Discussion regarding a commit (is: review) and acknowledgment of a commit cannot happen before the commit has been made. It can't happen before the commit on a feature branch, but it can happen before merging the commit back to the main development branch. Given that a rebase or merge commit is already frequently necessary to integrate changes from a feature branch after review is finished, I don't see why this typ…
The history-destroying problems of rebasing are a rant on their own.
Git Notes: Git's coolest, most unloved feature (2022)
51–60 of 147 posts
Re: Git Notes: Git's coolest, most unloved feature (2022)
#52I think it would be interesting to add the prompt (or a summary of the prompt) as a note for each commit. This would allow the LLM to later reason about each line of code by going back and checking the notes to mine for requirements, and take those into account when changing the code again.
Re: Git Notes: Git's coolest, most unloved feature (2022)
#53(They stopped tracking these changes a few years ago, probably because the pace of changes to Apache OpenOffice slowed down to a trickle, and there's no longer much to be gained by cherry-picking these few changes.)
Re: Git Notes: Git's coolest, most unloved feature (2022)
#54Earlier quoted context omitted.
Because you would not want to write the whole git history starting from the commit you want to stash this info one everytime you want to stash additional info … Appending information to the commit itself creates a new commit and all the commits that are based on the commit will also have to change consequently.
Ah; so notes don't impact the commit hash? That is a solid reason.
Re: Git Notes: Git's coolest, most unloved feature (2022)
#55Another little-known feature is git trailers: https://alchemists.io/articles/git_trailers These are key-value structures data that can be included on a commit when it is created. These are used by some systems for attaching metadata. For example, Gerrit uses this for attaching its Change-Id.
Is there anything equivalent -- that handles tracking changes over commits etc better than GH -- that is more actively developed and friendly for integration with GH? I hate GH's code review tools with the heat of 10,000 suns.
Re: Git Notes: Git's coolest, most unloved feature (2022)
#56Earlier quoted context omitted.
Shouldn’t that be the commit message ? Or is the goal to also link forward in time, such as “we realised this commit introduced bug #123” ?
haha wait do you actually read long commit messages( more than a line) all the way through? like line-by-line, imo commit msg = tweet, git note = blog post.
Re: Git Notes: Git's coolest, most unloved feature (2022)
#57Earlier quoted context omitted.
Shouldn’t that be the commit message ? Or is the goal to also link forward in time, such as “we realised this commit introduced bug #123” ?
haha wait do you actually read long commit messages( more than a line) all the way through? like line-by-line, imo commit msg = tweet, git note = blog post.
Re: Git Notes: Git's coolest, most unloved feature (2022)
#58There are many "Git's coolest, most unloved feature", e.g.: bisect, pickaxe, reflog, range-diff, archive, annotated tags, etc. Sadly they are often forgotten as many people thing of Git only as a glorified Google Drive...
Re: Git Notes: Git's coolest, most unloved feature (2022)
#59Another little-known feature is git trailers: https://alchemists.io/articles/git_trailers These are key-value structures data that can be included on a commit when it is created. These are used by some systems for attaching metadata. For example, Gerrit uses this for attaching its Change-Id.
It seems git trailers would now be the better place to put that information.
Regarding change ids: I wish git itself had those, as then also the tooling would understand them. Identifying commits by their commit messages is fragile, in particular when you may update those for an MR. While commit id truly identifies the commit in a unique way, it is not a useful identifier when the same changes could be moved on top of some other commit.
edit: Oh it looks like they are actually part of the commit, whereas notes aren't, so it wouldn't be a good replacement for my use.
Re: Git Notes: Git's coolest, most unloved feature (2022)
#60Earlier quoted context omitted.
Ah; so notes don't impact the commit hash? That is a solid reason.
Yeah, git notes are AFAIK stashed into their own hidden branch, referencing the original commit by its hash. That is, the git note points to the commit, not the opposite.