Don't use booleans (2019)

Post by edflsafoiewq » Mon, Jul 08, 2024, 11:39 PM UTC

kerkeslager wrote: post #22

gary_0 wrote: post #14

Earlier quoted context omitted.

Which is far more realistic than defining single-use enums all over the place. I don't know why more languages don't have named parameters...

Why is defining an enum "unrealistic"? It's at most 4 lines of very simple code to define an enum that replaces a boolean.

  // Booleans + Named Parameters
  foo(should_scrub=not options.scrubbing_disabled)

  // Single-Use Enum
  import ScrubbingOption, ShouldScrub;
  foo(
    if options.scrubbing == ScrubbingOption::Disabled {
      ShouldScrub::No
    } else {
      ShouldScrub::Yes
    }
  )

Post by edflsafoiewq » Mon, Jul 08, 2024, 11:43 PM UTC

wrs wrote: post #47

edflsafoiewq wrote: post #24

Earlier quoted context omitted.

If you don't have named parameters, you can fall back to variables var taxInvoice = false var sendEmail = true RaiseInvoice(taxInvoice, sendEmail) It's obvious, but people tend not to do it.

Sadly there is nothing that can tell you that you got those arguments backwards.

Post by someoneontenet » Tue, Jul 09, 2024, 12:00 AM UTC

presentation wrote: post #25

_fat_santa wrote: post #7

Tangential but coding in JS/TS, I often will go for object arguments to make things more readable. If you have a function like: foo(arg1: boolean, arg2: boolean, arg3: boolean) Then when you call it it will look like foo(true, false, true) which is not great for readability. Instead I move all the arguments into an object which makes each field explicit. Ie. foo({ arg1: true, arg2: false, arg3: true }) This also carr…

You can actually set up VSCode and probably other editors to show the parameter names inline with the values.

Post by lolinder » Tue, Jul 09, 2024, 12:10 AM UTC

asddubs wrote: post #33

bluefirebrand wrote: post #23

Earlier quoted context omitted.

Named parameters are easy enough to mimic in JS using objects and the spread operation function foo({bar, baz}) { ... } foo({bar: 1, baz: false})

that's its own kind of horrible though. now either all your functions just take single object parameters or you have to remember which ones. and I get javascript is light on checking what was passed is actually what was expected but this seems to somehow make that situation even worse still

Post by thamer » Tue, Jul 09, 2024, 12:45 AM UTC

someoneontenet wrote: post #55

presentation wrote: post #25

Earlier quoted context omitted.

You can actually set up VSCode and probably other editors to show the parameter names inline with the values.

How is this done for js?