Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Visual Studio Code 1.7 overloaded npmjs.org, release reverted

code.visualstudio.com

Post reply on HN
Print view View original

51–60 of 94 posts

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#51

Post by poizan42 »

raisedadead wrote: post #39
BenjaminCoe wrote: post #24

As one of the folks on the front-lines helping patch this, I certainly have no hard feelings; and I'm excited to be able to support this feature properly ... also ... not going to lie, this was the first time we've gotten to test several of the checks and balances we have in the npm registry which I was jazzed about :)

Thanks, Benjamin, Laurie and everyone else for mitigating this, it feels great to know when the community chimes in together for such highly unanticipated scenarios. On that note, however, respectfully I believe that features which have the potential of hitting the registry so bad should first be beta tested on a private registry and moved on to the high traffic serving CDNs of npm. And 10% of the daily traffic is fr…

> And 10% of the daily traffic is from India??? Whoa, every day is a school day.

Well, 17% of the world's population lives in India, so doesn't seems surprising.

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#53

Post by jug »

oridecon wrote: post #32
ec109685 wrote: post #31

Earlier quoted context omitted.

"Many requests to the registry as the entire nation of India" per what time unit?

Approximately 3 new JS frameworks per hour.

Funny. Sounds like the expansion rate of the Javascript ecosystem.

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#54

Post by PudgePacket »

eugeneionesco wrote: post #46
manojlds wrote: post #35

Would yarn help here? (since FB have their own CDN and registry for it?)

They do? yarn uses the npm registry not something else.

It does, but it also goes though cloudflare as far as I know (which does caching).

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#55

Post by [deleted] »

sctb wrote: post #20
meira wrote: post #4

Damn it, M$! Keep your shit closed. Not everybody wants you messing around.

We've asked you twice before not to do this, so we have to ban this account. We're happy to unban accounts if you email us at hn@ycombinator.com and we believe you'll not do this in the future.

[deleted]

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#56

Post by pdpi »

ec109685 wrote: post #31
seldo wrote: post #13

I'd just like to say on behalf of npm that Microsoft's handling of this incident was A+. As soon as we alerted them to the issue they were all hands on deck and did a rollback. We've been really pleased that Microsoft chose to put their @types packages into the npm registry rather than a separate, closed system, and in general happy with Microsoft's support of node and npm. We're confident we can make the new feature…

"Many requests to the registry as the entire nation of India" per what time unit?

Doesn't matter, it's a comparison of request rates.

Requests over time where user in India ~= requests over time where user is a vs code user

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#57

Post by tankenmate »

seldo wrote: post #16
sync wrote: post #9

Shouldn't all these requests be cached by a CDN? What exactly is overloading?

CDNs don't usually cache 404s. VSCode was looking for @types packages for any and every npm package its users were using. Packages that had a type description caused no issue, but most packages don't, so we had a > 1000% spike in 404s. Our workaround before MS did the rollback was to cache 404s for @types packages specifically, and it was effective enough that the registry never really went down.

It's a pity, DNS handles negative lookup caching / TTLs (in fact that is exactly what the TTL field in DNS zones are!). So negative lookups can be cached, but you need to do thinking about it ahead of time and set sensible TTLs (preferably configurable) for those negative caches.

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#58

Post by thedaniel »

seldo wrote: post #13

I'd just like to say on behalf of npm that Microsoft's handling of this incident was A+. As soon as we alerted them to the issue they were all hands on deck and did a rollback. We've been really pleased that Microsoft chose to put their @types packages into the npm registry rather than a separate, closed system, and in general happy with Microsoft's support of node and npm. We're confident we can make the new feature…

> This was an honest mistake on their part

From my outside perspective, it doesn't seem like a mistake on their part at all. Later in the thread you say this accounted for 10% of traffic, mostly 404s. This is (i assume) a hell of a lot of requests, but given npm's position as developer infrastructure, I don't think they could have reasonably expected to melt it. It would have been good of them to give a heads up, but I don't think I'd start assigning blame to the Code team.

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#59

Post by winsome »

gremlinsinc wrote: post #36

I'd love to use VSCode but can't until they or someone else rolls out a dockblockr extension that works for php as I'm mostly tied to Laravel right now, and my company requires docblocks and they are not fun to write by hand.

They have a great extension ecosystem. Why not give writing the extensions a shot yourself?

Re: Visual Studio Code 1.7 overloaded npmjs.org, release reverted

#60

Post by JohnDeHope »

seldo wrote: post #22
Arnavion wrote: post #14

Earlier quoted context omitted.

Can you elaborate on what the issue is and how you want it to be fixed? Is it just something like rate-limiting requests or something more fundamental? Edit: Answered at https://news.ycombinator.com/item?id=12861118

A VSCode person can (and probably will) answer in more detail, but at heart it's simple: if you want to add type-checking goodness to a library that isn't itself written in TypeScript, you can create a thing called a declaration file: https://github.com/DefinitelyTyped/DefinitelyTyped Microsoft publishes a list of known good declaration files for popular npm packages to npm, under the scope @types: https://www.npmjs.…

"There are any number of ways to fix this, and we'll work with Microsoft to find the best one..."

It's refreshing to read actual engineers' writing. After this, going back to tear-jerking snark-filled twitter and medium gnashing of teeth will be hard.

Post reply on HN