Encryptr – Free, open-source password manager and e-wallet • Hacker News Board

Re: Encryptr – Free, open-source password manager and e-wallet

#41

Post by sarciszewski » Thu, Jul 30, 2015, 8:54 PM UTC

homakov wrote: post #39

sarciszewski wrote: post #18

Earlier quoted context omitted.

Correct, that's the edge case where it actually falls together neatly. If you're starting with a random byte and charset.length is an even power of 2, you end up with no bias. It's better to design functions like this to discard values outside of an acceptable range and try again until they generate a safe value (also, apply a & bit mask to reduce the number of retries). This allows you to accept any arbitrary charse…

In theory, haha. In practice it gives me some numbers twice more. [2001954, 1000322, 998546, 1001551, 999105, 2000886, 998760, 998705, 1000001, 998424, 1000978, 2000907, 1002097, 998786, 1000101, 998818, 1000381, 1999818, 999662, 1001260, 999531, 1000076,

Your RNG is not cryptographically secure, I'd wager.

http://3v4l.org/DC0RM

Re: Encryptr – Free, open-source password manager and e-wallet

#42

Post by gingerlime » Thu, Jul 30, 2015, 9:01 PM UTC

tptacek wrote: post #20

sarciszewski wrote: post #4

https://github.com/devgeeks/Encryptr/blob/64223f0cb4adba80c8... I'm a bit concerned that their random number generator might produce biased output. This is usually a red flag that there are other issues in the code that haven't been examined by a crypto person. Just a word of caution from a casual glance. For all I know the rest of the code is fine. For all I know, the rest of the code is clunky swiss cheese. Further…

There doesn't appear to be much crypto in this project; it's a small application built on SpiderOak's Crypton.io. I'm not a fan of Crypton, but it's not clownshoes crypto. Just to be clear to everyone on the thread: it's very unlikely that there's anything practical an attacker can do with the modulus bias in a situation like this.

> I'm not a fan of Crypton

Just curious - is this to do with using javascript crypto[0]? or something that goes beyond that?

[0] https://www.nccgroup.trust/us/about-us/newsroom-and-events/b...

Re: Encryptr – Free, open-source password manager and e-wallet

#43

Post by homakov » Thu, Jul 30, 2015, 9:03 PM UTC

sarciszewski wrote: post #41

homakov wrote: post #39

Earlier quoted context omitted.

In theory, haha. In practice it gives me some numbers twice more. [2001954, 1000322, 998546, 1001551, 999105, 2000886, 998760, 998705, 1000001, 998424, 1000978, 2000907, 1002097, 998786, 1000101, 998818, 1000381, 1999818, 999662, 1001260, 999531, 1000076,

Your RNG is not cryptographically secure, I'd wager. http://3v4l.org/DC0RM

I thought instead of cutting off out of range results we could num*85/4294967296 and round it. But now realized buckets for rounding won't be of equal size and it's wrong.

Re: Encryptr – Free, open-source password manager and e-wallet

#44

Post by vanous » Thu, Jul 30, 2015, 9:14 PM UTC

This looks like very nice, lightweight interface, great work! Hopefully it will get browser support as per https://github.com/devgeeks/Encryptr/issues/169

Re: Encryptr – Free, open-source password manager and e-wallet

#45

Post by Ruud-v-A » Thu, Jul 30, 2015, 9:18 PM UTC

vetrom wrote: post #30

Ruud-v-A wrote: post #22

The site is using a startcom certificate … how ironic.

How is StartCom as a cert provider ironic?

It is a rogue CA that does not revoke compromised certificates even when presented with a proof of such compromise, unless the customer pays a revocation fee. If the customer does not pay the fee, StartCom provides trust (which is what CAs do; they say “we guarantee to the best of our knowledge that this server is the server it claims to be”) for websites which are known (by StartCom) to be compromised, defeating the purpose of having CAs in the first place.

After Heartbleed many certificates had to be revoked, and one person who did not want to pay the revocation fee had the idea of publishing his private key so that the certificate was compromised without doubt. StartCom refused to revoke it, and the page that explained the story has since disappeared mysteriously. The HN thread about it is here: https://news.ycombinator.com/item?id=7577290

Re: Encryptr – Free, open-source password manager and e-wallet

#46

Post by cmrx64 » Thu, Jul 30, 2015, 9:33 PM UTC

shuzchen wrote: post #26

sarciszewski wrote: post #4

https://github.com/devgeeks/Encryptr/blob/64223f0cb4adba80c8... I'm a bit concerned that their random number generator might produce biased output. This is usually a red flag that there are other issues in the code that haven't been examined by a crypto person. Just a word of caution from a casual glance. For all I know the rest of the code is fine. For all I know, the rest of the code is clunky swiss cheese. Further…

Encryptr's security bits are likely all implemented in the crypton framework. If you search the repo for that function (randomString), you'll see that it's only used in one place: to propose a new password ( https://github.com/devgeeks/Encryptr/search?utf8=%E2%9C%93&q... ). While it'd be best to not have any bias at all, this low bias only assists people trying to brute force passwords created by encryptr. Crypton it…

The contents of the second audit in particular deeply troubled me. Lots of simple but grevious mistakes. It's nice that they got the audit though.

Re: Encryptr – Free, open-source password manager and e-wallet

#47

Post by sarciszewski » Thu, Jul 30, 2015, 9:38 PM UTC

gingerlime wrote: post #42

tptacek wrote: post #20

Earlier quoted context omitted.

There doesn't appear to be much crypto in this project; it's a small application built on SpiderOak's Crypton.io. I'm not a fan of Crypton, but it's not clownshoes crypto. Just to be clear to everyone on the thread: it's very unlikely that there's anything practical an attacker can do with the modulus bias in a situation like this.

> I'm not a fan of Crypton Just curious - is this to do with using javascript crypto[0]? or something that goes beyond that? [0] https://www.nccgroup.trust/us/about-us/newsroom-and-events/b...

JavaScript is only a real issue when you have an insecure code delivery mechanism. The article spells that out pretty well.

Re: Encryptr – Free, open-source password manager and e-wallet

#48

Post by cmrx64 » Thu, Jul 30, 2015, 9:38 PM UTC

dbmikus wrote: post #32

I like this for my password manager: http://www.passwordstore.org/ It's all UNIX based and takes advantage of GPG and Git for encryption and versioning, respectively. Super lightweight, and there are various front-ends for it, including an Android app. It's not a cloud-based solution by default, but it wouldn't be hard to set it up to git push to a central location on each update and to pull from that location down t…

I dislike pass because it doesn't encrypt all information in the typical configuration. Its simplicity is nice.

Re: Encryptr – Free, open-source password manager and e-wallet

#49

Post by sarciszewski » Thu, Jul 30, 2015, 9:41 PM UTC

Ruud-v-A wrote: post #45

vetrom wrote: post #30

Earlier quoted context omitted.

How is StartCom as a cert provider ironic?

It is a rogue CA that does not revoke compromised certificates even when presented with a proof of such compromise, unless the customer pays a revocation fee. If the customer does not pay the fee, StartCom provides trust (which is what CAs do; they say “we guarantee to the best of our knowledge that this server is the server it claims to be”) for websites which are known (by StartCom) to be compromised, defeating the…

Sorry, accidentally downvoted. Meant to upvote.

Re: Encryptr – Free, open-source password manager and e-wallet

#50

Post by bitskits » Thu, Jul 30, 2015, 9:42 PM UTC

Does Encryptr support 2FA? I don't see any mention on the landing page or on Github.

EDIT: After more digging, it looks like it does not, but may in the future. https://github.com/devgeeks/Encryptr/issues/123