41–50 of 111 posts
And keep your rose-colored glasses on at all times. You shall see no evil, hear no evil, speak no evil and never grow out of childhood.
Fabian Sanglard's exploration[1] of Doom3 is much more in depth than this article, though the author does quote Sanglard's analysis albeit with a small source link [1] http://fabiensanglard.net/doom3_bfg/index.php
http://fabiensanglard.net/doom3/index.php
The vanilla code review goes into the app structure first, and (what little I've read of) the BFG review compares that codebase against the vanilla one.
No one have issues with source code files 5100 lines long? https://github.com/dhewm/dhewm3/blob/master/neo/game/ai/AI.c...
If you're using any kind of IDE then this wouldn't bug you as you can just jump to the point in the file you need.
> The game was a commercial success for id Software; with more than 3.5 million copies of the game were sold. Wrong/Cheated. It was such a success that they had to sell the company - they sold ID-Software...
Earlier quoted context omitted.
I was seated at the restroom at work yesterday morning when I noticed a strip of plastic had been added to the gap between the metal stall and the metal stall door. It was branded Privacy Cover (patent pending). Welcome to the future where everything is branded and everyone is an Avon lady, endorsing some set of pet products :) [a] http://www.rbahelp.com/toilet-partition-privacy-strip-instal... [b] http://www.partiti…
I didn't realize people peeking through the slim slit was an issue.
Earlier quoted context omitted.
I was seated at the restroom at work yesterday morning when I noticed a strip of plastic had been added to the gap between the metal stall and the metal stall door. It was branded Privacy Cover (patent pending). Welcome to the future where everything is branded and everyone is an Avon lady, endorsing some set of pet products :) [a] http://www.rbahelp.com/toilet-partition-privacy-strip-instal... [b] http://www.partiti…
I didn't realize people peeking through the slim slit was an issue.
> The game was a commercial success for id Software; with more than 3.5 million copies of the game were sold. Wrong/Cheated. It was such a success that they had to sell the company - they sold ID-Software...
ZeniMax - 2009
It seemed to do well enough to slow the need to sale for five years or so.
Or maybe, just maybe, it was so successful of a company that another company bought it to share in the success.
https://github.com/dhewm/dhewm3/blob/master/neo/game/Target.... This is the "nicest looking code [you] have ever seen" ?
What's wrong with this?
C-style declaration of all the variables in the beginning? (Yes, I know what Carmack said about how he written the project; this explains it, but doesn't make it good C++ code.)
Unclear flow with just one comment, which doesn't really explain anything?
Not to brag but https://github.com/dhewm/dhewm3/blob/master/neo/idlib/Heap.c... (from line 154 down) that seems like another point against using tabs.
I always heard "Tabs for indenting, spaces for aligning."
Earlier quoted context omitted.
What's wrong with this?
Over 150 lines of code in a simple method? C-style declaration of all the variables in the beginning? (Yes, I know what Carmack said about how he written the project; this explains it, but doesn't make it good C++ code.) Unclear flow with just one comment, which doesn't really explain anything?