Looks like someone disabled garbage collection on that comment thread as well :)
Composer – Disable GC when computing deps and refs
41–50 of 135 posts
Re: Composer – Disable GC when computing deps and refs
#42Re: Composer – Disable GC when computing deps and refs
#43Looks like someone disabled garbage collection on that comment thread as well :)
The truth is, I don't understand the point on having to download MBs of stupid animated images I will not even look at when I expect to see a commit diff.
Re: Composer – Disable GC when computing deps and refs
#44Never have I seen so many gifs on a commit page.
https://github.com/MrMEEE/bumblebee-Old-and-abbandoned/commi...
Re: Composer – Disable GC when computing deps and refs
#45Looks like someone disabled garbage collection on that comment thread as well :)
It would be nice if Chrome let you disable animated gifs, without disabling all images.
Re: Composer – Disable GC when computing deps and refs
#46Could someone more versed with PHP, and this project explain why turning off garbage collection helped so much? and why they didn't turn it back on at the end of the function?
The cycle collector is relatively recent, I expect it's not very performant (since most PHP applications don't need it) and composer's dependency resolution may be hitting a pathological case (create lots of objects without cycles, triggering lots of collections but no actually useful work)
> and why they didn't turn it back on at the end of the function?
Since it's a package manager, I'd guess the expectation is the process will die soon-ish afterwards (once it's installed whatever it's resolved). There's a discussion of re-enabling it after dependency resolution (so postinstall hooks run with GC enabled) though.
Re: Composer – Disable GC when computing deps and refs
#47Earlier quoted context omitted.
Please try and keep your attitude in check. Your tone is not helping.
[deleted]
Do you find you have much success motivating people when you use this tone of voice?
I reported this issue in February. Others have reported it before I did. What is Composer's response? Silence and negligence while its maintainers go to cons and drink beer.
Their priorities are totally fucking backwards.
I would strongly advise using less inflammatory titles than Horrendously Stupid and Ill-Advised Install Instructions if you wish people to not ignore you.
You might not want to do this, and that's fine and your prerogative.
If you do want to see a significant increase in cooperation, dropping the attitude will be a quick and effective way of doing so.
Re: Composer – Disable GC when computing deps and refs
#48Earlier quoted context omitted.
So, did they exchange a 70% reduction in execution time for a 100% increment in memory usage?
1324 -> 232. If you say 70% reduction VS 100% increment sounds like you are talking the same stuff and it is possible to compare 70 with 100. The reality is even in the above edge case: 2x memory, 6x speed.
Re: Composer – Disable GC when computing deps and refs
#49Re: Composer – Disable GC when computing deps and refs
#50Could someone more versed with PHP, and this project explain why turning off garbage collection helped so much? and why they didn't turn it back on at the end of the function?
Garbage collection is slow, but reduces memory usage. So disabling it costs memory. Also, Composer does not keep running, once the job is done, the script terminates, so you don't have to enable GC back again (it's only disabled in the context of the current execution).
Note that it's only reducing memory usage if there are cycles. The rest will be collected when the refcount falls to 0.