41–50 of 114 posts
I think this just goes to show that you can have a lot of popularity even if your code is just sorta glued together. Don't they get a few million users? I'd say it's definitely nothing to scoff at. It makes me wonder how many big profile websites might look like this or worse.
As if OpenSSL didn't prove this already.
Earlier quoted context omitted.
this makes it even more likely that it's the real code. Let's face it, no one is expecting a shining example of software design and architectural brilliance here
The original 4chan code was in Japanese and moot used Babelfish to try figure out what did what. From what I remember, the original Futaba code is just as bad ( http://www.2chan.net/script/ ). It's no secret that 4chan is cobbled together with glue and string, moot has said this several times before.
Earlier quoted context omitted.
Aren't you able to hijack sessions on most webpages if you stole session cookies?
The real problem is: "extract($_POST); extract($_GET); extract($_COOKIE);" For more information on extract: http://www.php.net/extract
Description
Import variables from an array into the current symbol table.
If flags is not specified, it is assumed to be EXTR_OVERWRITE.
EXTR_OVERWRITE
If there is a collision, overwrite the existing variable.
if(isset($_COOKIE['4chan_auser'])&&isset($_COOKIE['4chan_apass'])){ $user = mysql_real_escape_string($_COOKIE['4chan_auser']); $pass = mysql_real_escape_string($_COOKIE['4chan_apass']); } HAHAHAHAAHAHAHAHAA Steal a cookie, gain access.. WTF
F* me. No wonder PHP has a bad rap..
Redeveloping the site in Go, Dart, Python or Node, or whatever language you like best, wouldn't increase 4Chan's value in any discernible way.
At the end of the day, it works.
I think this just goes to show that you can have a lot of popularity even if your code is just sorta glued together. Don't they get a few million users? I'd say it's definitely nothing to scoff at. It makes me wonder how many big profile websites might look like this or worse.
Things are different today though,people tend to use native apps, users want realtime features,hard to do that in pure PHP and scale.You often need 3rd party techs,mostly java based...
I think this just goes to show that you can have a lot of popularity even if your code is just sorta glued together. Don't they get a few million users? I'd say it's definitely nothing to scoff at. It makes me wonder how many big profile websites might look like this or worse.
I still remember a week into the first job fresh-from-college me marching into the VPs office to tell him the source code was terrible and they were only still running due to luck. It was not well received (or right)
Earlier quoted context omitted.
> It seems that it's too terrible to be the true code. 1. It's written in PHP. Finding a good PHP developer is nigh impossible (there are exceptions, like always). 2. I expected worse, to be honest.
No serious, modern PHP developer writes code like this. If it were a code sample for any respectable PHP job, it would be a massive "do not hire" flag.
Right tool for the right job. You can use qualifiers like "serious" and "modern" but you're deluding yourself if you think they mean anything when the pool of PHP developers is so staggeringly high.