Live data from Hacker News

Reinventing the pull request

lubeno.dev

41–50 of 96 posts

Re: Reinventing the pull request

#41

It blows my mind that Github still doesn't support stacked PRs. Do they never do work that depends on an open PR? Like, as soon as they open a PR they're like "right, better stop doing anything until it's merged"? The file priority thing is a great idea too. That would be even more useful for search. The number of times I'm searching for something on Github and it just shows me a gazillion tests.... Yeah you can look…

GitHub is putting stacked PRs into private beta around now, actually.

Re: Reinventing the pull request

#42
There’s an interesting nugget of an idea in this ad. But the current implementation leaves a lot to be desired. What I want out of the PR interface is to be able to ask an agent questions and get back supported answers and to be able to easily see the changes live in a system so I can test them. That requires solving a huge problem of iterative deployments but if you could do that the value of stacked PRs would be immense. If someone doesn’t do this then PRs will just be abandoned.

Re: Reinventing the pull request

#44
post #42

There’s an interesting nugget of an idea in this ad. But the current implementation leaves a lot to be desired. What I want out of the PR interface is to be able to ask an agent questions and get back supported answers and to be able to easily see the changes live in a system so I can test them. That requires solving a huge problem of iterative deployments but if you could do that the value of stacked PRs would be im…

There's a much more interesting idea that I'm waiting for somebody to do, which is just have AI break down a PR into digestible chunks for me. Stacked PRs are a nice idea but they require the developer to follow the pattern. I'd rather be able to get a big 50+ file PR, and have it be broken down into bite size areas I can review and check along as I go.

This would be especially helpful for mobile, where reading a traditional diff is basically impossible.

Re: Reinventing the pull request

#45
post #2

On my first load of this page, it took 4.85 seconds to get meaningful content and the whole page took 8.09s. The vast majority of the delay seems to be from assets like the PNG images and the fonts, which don't seem to be on a CDN. I am located in Tokyo, Japan, with a 1Gbps symmetric connection, so while I am regionally quite distant from the site, I assume, I still think there are ample CDNs available that would spe…

Sorry about that! Performance is really important to me, I just didn't get around to configuring CDN caching and optimizing the assets. All the HN traffic hitting our server also didn't help.

I signed up and I'm finding browsing a repo quite snappy. Good job.

Re: Reinventing the pull request

#46

It blows my mind that Github still doesn't support stacked PRs. Do they never do work that depends on an open PR? Like, as soon as they open a PR they're like "right, better stop doing anything until it's merged"? The file priority thing is a great idea too. That would be even more useful for search. The number of times I'm searching for something on Github and it just shows me a gazillion tests.... Yeah you can look…

GitHub is putting stacked PRs into private beta around now, actually.

link?

Re: Reinventing the pull request

#47
Regarding PRs. I have a an opinion which has become very unpopular since the rise of github.

The way github does PRs is great for open source projects where you have submissions from a very diverse set of developers. You need to evaluate the whole PR as whole and accept it or reject it.

But it is not ideal where you have a small team working on single product. The PR review becomes a gate and it has been my experience as a developer that you spend a LOT of time trying to get your PR reviewed.

My preferred approach is to do smaller and more frequent commits that are merged directly to the main branch. Developers learn to break a problem into very small changes which is a skill by itself. It is the responsibility of a lead or Sr engineer to check the commits as they come so they can provide feedback as soon as possible. This was the spirit of the original continuous integration ideas back in the day.

Re: Reinventing the pull request

#48
post #44
post #42

There’s an interesting nugget of an idea in this ad. But the current implementation leaves a lot to be desired. What I want out of the PR interface is to be able to ask an agent questions and get back supported answers and to be able to easily see the changes live in a system so I can test them. That requires solving a huge problem of iterative deployments but if you could do that the value of stacked PRs would be im…

There's a much more interesting idea that I'm waiting for somebody to do, which is just have AI break down a PR into digestible chunks for me. Stacked PRs are a nice idea but they require the developer to follow the pattern. I'd rather be able to get a big 50+ file PR, and have it be broken down into bite size areas I can review and check along as I go. This would be especially helpful for mobile, where reading a tra…

This is a really good idea. Especially if the chunks are marked as read as you are guided through them and you can validate you've seen all the code by the end

Re: Reinventing the pull request

#49
post #46

Earlier quoted context omitted.

GitHub is putting stacked PRs into private beta around now, actually.

link?

https://x.com/jaredpalmer/status/2019817235163074881

(this was a follow-up to the initial announcement months ago, also made via X)

Re: Reinventing the pull request

#50

Regarding PRs. I have a an opinion which has become very unpopular since the rise of github. The way github does PRs is great for open source projects where you have submissions from a very diverse set of developers. You need to evaluate the whole PR as whole and accept it or reject it. But it is not ideal where you have a small team working on single product. The PR review becomes a gate and it has been my experienc…

Modern software engineering culture is a treadmill ever in search of the next best practice that must be applied to a field made up of bespoke scenarios.
Post reply on HN