Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Get an AI code review in 10 seconds

oldmanrahul.com

Post reply on HN
Print view View original

41–50 of 69 posts

Re: Get an AI code review in 10 seconds

#41

Post by wakawaka28 »

aidanlister wrote: post #40
mvanbaak wrote: post #32

Earlier quoted context omitted.

those AI checks, if you insist in getting them, should be part of your pre-commit, not part of your PR review flow. they are at best (if they even reach this level) as good as a local run of a linter or static type checker If you are running them as a PR check, the PR is out there. So people will spend time on that PR. no matter if you are fixing the AI comments or not. Best to fix those things BEFORE you provide you…

This just sounds like you haven’t worked in a team environment in the last 12 months. The ergonomics of doing this in pre-commit make no sense. Spin up a PR in GitHub and get Cursor and/or Claude to do a code review — it’s amazing. It’ll often spot bugs (not only obvious ones), it’ll utilise your agent.md to spot mismatched coding style, missing documentation, it’ll check sentry to see if this part of the code touche…

It makes as much sense to use AI in pre-commit as it does to use a linter.

Re: Get an AI code review in 10 seconds

#42

Post by mvanbaak »

aidanlister wrote: post #40
mvanbaak wrote: post #32

Earlier quoted context omitted.

those AI checks, if you insist in getting them, should be part of your pre-commit, not part of your PR review flow. they are at best (if they even reach this level) as good as a local run of a linter or static type checker If you are running them as a PR check, the PR is out there. So people will spend time on that PR. no matter if you are fixing the AI comments or not. Best to fix those things BEFORE you provide you…

This just sounds like you haven’t worked in a team environment in the last 12 months. The ergonomics of doing this in pre-commit make no sense. Spin up a PR in GitHub and get Cursor and/or Claude to do a code review — it’s amazing. It’ll often spot bugs (not only obvious ones), it’ll utilise your agent.md to spot mismatched coding style, missing documentation, it’ll check sentry to see if this part of the code touche…

why not have AI review your code BEFORE you share it with the team ? that shows so much more respect to the rest of the team then just throwing your code into the wild, only to change it because some robot tells you that X could be Y

Re: Get an AI code review in 10 seconds

#43

Post by Sharlin »

aidanlister wrote: post #40
mvanbaak wrote: post #32

Earlier quoted context omitted.

those AI checks, if you insist in getting them, should be part of your pre-commit, not part of your PR review flow. they are at best (if they even reach this level) as good as a local run of a linter or static type checker If you are running them as a PR check, the PR is out there. So people will spend time on that PR. no matter if you are fixing the AI comments or not. Best to fix those things BEFORE you provide you…

This just sounds like you haven’t worked in a team environment in the last 12 months. The ergonomics of doing this in pre-commit make no sense. Spin up a PR in GitHub and get Cursor and/or Claude to do a code review — it’s amazing. It’ll often spot bugs (not only obvious ones), it’ll utilise your agent.md to spot mismatched coding style, missing documentation, it’ll check sentry to see if this part of the code touche…

Stuff like coding style and missing documentation is what your basic dumb formatter and linter are supposed to do, using a LLM for such things is hilarious overkill and waste of electricity.

Re: Get an AI code review in 10 seconds

#44

Post by emeraldd »

simonw wrote: post #31
mvanbaak wrote: post #30

I still dont get the idea about AI code reviews. A code review (at least in my opinion) is for your peers to check if the changes will have a positive or negative effect on the overall code + architecture. I have yet to see an LLM being good at this. Sure, they will leave comments about common made errors (your editor should already warn about this before you even commit it) etc. But to notify about this weird thing…

Sure, AI code reviews aren't a replacement for an architecture review on a larger team project. But they're fantastic at spotting dumb mistakes or low-hanging fruit for improvements! And having the AI spot those for you first means you don't waste your team's valuable reviewing time on the simple stuff that you could have caught early.

My experience with AI code reviews has been very mixed and more on the negative side than the positive one. In particular, I've had to disable the AI reviewer on some projects my team manages because it was so chatty that it caused meaningful notifications from team members to be missed.

In most of the repos I work with, it tends to make a large number of false positive or inappropriate suggestions that are just plain wrong for the code base in question. Sometimes these might be ok in some settings, but are generally just wrong. About 1 in every 10~20 comments is actually useful or something novel that hasn't been caught elsewhere etc. The net effect is that the AI reviewer we're effectively forced to use is just noise that get's ignored because it's so wrong so often.

Re: Get an AI code review in 10 seconds

#45

Post by Yeask »

porise wrote: post #24
zedascouves wrote: post #12

Hum? I just tell claude to review pr #123 and it uses 'gh' to do everything, including responding to human comments! Feedback from coleagues has been awesome. We are sooo gonna get replaced soon...

Good thing I work on an old C++ code base where it's impossible for AI to go through the millions of lines that all interact horribly in unpredictable ways.

Is all marketing, it does not even work with js frontend frameworks.

Re: Get an AI code review in 10 seconds

#46

Post by syntheticcdo »

emeraldd wrote: post #44
simonw wrote: post #31

Earlier quoted context omitted.

Sure, AI code reviews aren't a replacement for an architecture review on a larger team project. But they're fantastic at spotting dumb mistakes or low-hanging fruit for improvements! And having the AI spot those for you first means you don't waste your team's valuable reviewing time on the simple stuff that you could have caught early.

My experience with AI code reviews has been very mixed and more on the negative side than the positive one. In particular, I've had to disable the AI reviewer on some projects my team manages because it was so chatty that it caused meaningful notifications from team members to be missed. In most of the repos I work with, it tends to make a large number of false positive or inappropriate suggestions that are just plai…

Sometimes the only review a PR needs is "LGTM" - something today's LLMs are structurally incapable of.

Re: Get an AI code review in 10 seconds

#47

Post by fusslo »

emeraldd wrote: post #44
simonw wrote: post #31

Earlier quoted context omitted.

Sure, AI code reviews aren't a replacement for an architecture review on a larger team project. But they're fantastic at spotting dumb mistakes or low-hanging fruit for improvements! And having the AI spot those for you first means you don't waste your team's valuable reviewing time on the simple stuff that you could have caught early.

My experience with AI code reviews has been very mixed and more on the negative side than the positive one. In particular, I've had to disable the AI reviewer on some projects my team manages because it was so chatty that it caused meaningful notifications from team members to be missed. In most of the repos I work with, it tends to make a large number of false positive or inappropriate suggestions that are just plai…

one person proved the uselessness of ai reviews for our entire company.

He'd make giant, 100+ file changes, 1000+ worded PRs. Impossible to review. eventually he just modified the permissions to require a single approval, approves his changes and merges. This is still going on, but he's isolated to repos he made himself

He'd copy/paste the output from AI on other people's reviews. Often they were false positives or open ended questions. So he automated his side, but doubled or tripled the work of the person requesting the review. not to mention the ai's comments were 100-300 words with formatting and emojis.

The contractors refused to address any comments made by him. Some felt it was massively disrespectful as they put tons of time and effort into their changes and he can't even bother to read it himself.

It got to the CTO. And AI reviews have been banned.

But it HAS helped the one Jr guy on the team prepare for reviews and understand review comments better. It's also helped us write better comments, since I and some others can be really bad at explaining something

Re: Get an AI code review in 10 seconds

#48

Post by bilalq »

mvanbaak wrote: post #30

I still dont get the idea about AI code reviews. A code review (at least in my opinion) is for your peers to check if the changes will have a positive or negative effect on the overall code + architecture. I have yet to see an LLM being good at this. Sure, they will leave comments about common made errors (your editor should already warn about this before you even commit it) etc. But to notify about this weird thing…

This question is surprising to me, because I consider AI code review the single most valuable aspect of AI-assisted software development today. It's ahead of line/next-edit tab completion, agentic task completion, etc.

AI code review does not replace human review. But AI reviewers will often notice little things that a human may miss. Sometimes the things they flag are false positives, but it's still worth checking in on them. If even one logical error or edge case gets caught by an AI reviewer that would've otherwise made it to production with just human review, it's a win.

Some AI reviewers will also factor in context of related files not visible in the diff. Humans can do this, but it's time consuming, and many don't.

AI reviews are also a great place to put "lint" like rules that would be complicated to express in standard linting tools like Eslint.

We currently run 3-4 AI reviewers on our PRs. The biggest problem I run into is outdated knowledge. We've had AI reviewers leave comments based on limitations of DynamoDB or whatever that haven't been true for the last year or two. And of course it feels tedious when 3 bots all leave similar comments on the same line, but even that is useful as reinforcement of a signal.

Re: Get an AI code review in 10 seconds

#50

Post by insin »

emeraldd wrote: post #44
simonw wrote: post #31

Earlier quoted context omitted.

Sure, AI code reviews aren't a replacement for an architecture review on a larger team project. But they're fantastic at spotting dumb mistakes or low-hanging fruit for improvements! And having the AI spot those for you first means you don't waste your team's valuable reviewing time on the simple stuff that you could have caught early.

My experience with AI code reviews has been very mixed and more on the negative side than the positive one. In particular, I've had to disable the AI reviewer on some projects my team manages because it was so chatty that it caused meaningful notifications from team members to be missed. In most of the repos I work with, it tends to make a large number of false positive or inappropriate suggestions that are just plai…

I love having to hit Resolve Conversation umpteen times before I can merge because somebody added Copilot and it added that many dumb questions/suggestions
Post reply on HN