Live data from Hacker News

How VSCode made bracket pair colorization faster (2021)

code.visualstudio.com

41–50 of 247 posts

Re: How VSCode made bracket pair colorization faster (2021)

#41

But these "micro optimizations" aren't going to win anything! Just keep everything slow and then everything will be alright. https://news.ycombinator.com/item?id=36401488

This is not micro optimization. This is fixing a known performance issue.

Re: How VSCode made bracket pair colorization faster (2021)

#42

Earlier quoted context omitted.

Seems like a fundamentally unsolvable problem. These techinques use a spectrum of colours for deeply nested brackets. (If you only have one or two levels of brackets then you don't need the colourisation in the first place.) But colourblind users fundamentally don't have that many choices of colours to pick from in the first place.

It's not unsolvable. Colorblind people are missing one axis of color (such as the red-green axis). It is perfectly mathematically possible to pick colors that do not only differentiate along this axis, hence this option in many AAA games. Here's an online simulator to see what colorblind people of various types see. Note that if you yourself try this and the colors for one of the examples don't seem to change from th…

[deleted]

Re: How VSCode made bracket pair colorization faster (2021)

#43
post #2

And yet, somehow, no one has done anything to address the inherent issues for colorblind developers. All of these colorization add-ons are woefully inadequate in that regard.

Seems like a fundamentally unsolvable problem. These techinques use a spectrum of colours for deeply nested brackets. (If you only have one or two levels of brackets then you don't need the colourisation in the first place.) But colourblind users fundamentally don't have that many choices of colours to pick from in the first place.

Maybe they could use a superscript or subscript number instead?

Re: How VSCode made bracket pair colorization faster (2021)

#45
post #8

If you can make something 10k x faster you didn’t so much fix it as just switch it to working correctly as it should have in the first place. VSCode is a good tool, but it’s unbearably slow, and it breaks my heart that so much development has converged on something written in electron with such a low regard for performance by any measure.

Intellij does this in constant time because it has AST functionality built in.

Re: How VSCode made bracket pair colorization faster (2021)

#46

Earlier quoted context omitted.

That's surprising to hear, because I use vscode every day and its performance is miles away of any JS apps I've ever used. It truly feels like a native app when it comes to performance, at the same time keeping some "fluidity" of web app (like scale the entire UI with single key press or reloading the entire app like a web page). I'd say I never had issues with vscode performance and actually its performance is a maj…

VSCode was essentially unusable for me on large projects. We're talking thousands of source files and god knows how many node_modules entries. Things like Go to Definition would regularly take 15+ seconds! Switched to WebStorm recently and have been very happy with the performance.

Weird, i often opened files with hundreds of thousands of code lines without any problem. We do have very modern Workstations at work though.

Re: How VSCode made bracket pair colorization faster (2021)

#47
post #8

If you can make something 10k x faster you didn’t so much fix it as just switch it to working correctly as it should have in the first place. VSCode is a good tool, but it’s unbearably slow, and it breaks my heart that so much development has converged on something written in electron with such a low regard for performance by any measure.

[deleted]

Re: How VSCode made bracket pair colorization faster (2021)

#48
post #8

If you can make something 10k x faster you didn’t so much fix it as just switch it to working correctly as it should have in the first place. VSCode is a good tool, but it’s unbearably slow, and it breaks my heart that so much development has converged on something written in electron with such a low regard for performance by any measure.

    > look, I'm sorry, but the rule is simple:
    > if you made something 2x faster, you might have done something smart
    > if you made something 100x faster, you definitely just stopped doing something stupid
https://twitter.com/rygorous/status/1271296834439282690?lang...>

Re: How VSCode made bracket pair colorization faster (2021)

#49
post #8

If you can make something 10k x faster you didn’t so much fix it as just switch it to working correctly as it should have in the first place. VSCode is a good tool, but it’s unbearably slow, and it breaks my heart that so much development has converged on something written in electron with such a low regard for performance by any measure.

It's unfortunate that oni2 development stopped.

It had the promise of all the benefits of VS Code, but performance of a native app.

https://v2.onivim.io

Post reply on HN