Live data from Hacker News

Move Fast and Migrate Things: How We Automated Migrations in Postgres

benchling.engineering

41–50 of 55 posts

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#41
post #8

I am convinced that data migration is definitely one of the hardest problems in data management and systems engineering. There are basically no solutions today that satisfy fundamental requirements such as minimizing downtime and guaranteeing correctness. It is _such_ a huge problem that most inexperienced developers see kicking the problem down the line with NoSQL document storage as a viable alternative (it isn't;…

I think DB's could definitely do more to expose what the cost of various operations are, it would be great if you could "explain" a migration before you run it like you can with a query and it would calculate a rough cost, how many rows need to be touched, what resources need to be locked, even how likely the required locks are to cause contention with other frequently-taken locks based on system statistics, etc. But…

> I think DB's could definitely do more to expose what the cost of various operations are, it would be great if you could "explain" a migration before you run it like you can with a query and it would calculate a rough cost, how many rows need to be touched, what resources need to be locked, even how likely the required locks are to cause contention with other frequently-taken locks based on system statistics, etc.

As part of my development process for a project I am working on currently I have spent quite a bit of time writing a Python 3 program to generate sample data.

It's nothing groundbreaking but I haven't seen anyone talk about this so I think it might be of interest to others maybe?

I'll explain how that is relevant to the comment I am replying to in a moment but first I would like to talk a little about said program.

So first of all you have other existing tools for generating sample data. For example in DBeaver (https://dbeaver.io/) you have functionality for generating mock data. However, while DBeaver as a whole is a nice tool that I am happy to have learned about, the mock data generating functionality is from what I have seen severely limited.

In particular, what I wanted to do was to generate data that would adhere to arbitrary statistical distribution of my liking.

In the first version of my program it took about 50 minutes (unacceptable!) to generate and insert 10,000,000 records on my laptop, and I was consuming so much RAM that my laptop started swapping which hurt the performance as well (to be fair my laptop only has 8GB of RAM but still). That however was just the initial starting point -- it was even only doing statistical distribution for one property (age), a few were assigned random values and all of the other were assigned a single value common to all.

After a bit of thinking I decided that the next step would be to construct a tree structure with frequencies for the different values. This tree is cheap for memory and fast to build.

First I specify a set of "distribution templates" that instruct the frequencies for values or groups of values of each of the properties that will have a desired statistical distribution.

For example, I create a demographics model (simplified here for brevity):

    distribution_templates = \
    {
      'age':
      {
        '18-24': 150,
        '25-34': 206,
        '35-44': 185,
        '45-54': 177,
        '55-64': 175,
        '65+':   106,
      },
      'gender':
      {
        'female':         80,
        'male':           15,
        'other':           3,
        'rather not say':  2,
      },
    }
From this I create at runtime what I refer to as a "combinatorial tree" with calculated target frequencies, and then I distribute a population count over it that is specified at runtime as well. Let's say that we want to generate 10,000,000 sample users. The resulting tree looks like this:

    -- root -- 'all' (10000000) -- age -- '18-24' (1501501) -- gender -- 'female' (1201201)
                                       |                              |- 'male' (225225)
                                       |                              |- 'other' (45045)
                                       |                              `- 'rather not say' (30030)
                                       |- '25-34' (2062062) -- gender -- 'female' (1649650)
                                       |                              |- 'male' (309309)
                                       |                              |- 'other' (61862)
                                       |                              `- 'rather not say' (41241)
                                       |- '35-44' (1851852) -- gender -- 'female' (1481482)
                                       |                              |- 'male' (277778)
                                       |                              |- 'other' (55555)
                                       |                              `- 'rather not say' (37037)
                                       |- '45-54' (1771772) -- gender -- 'female' (1417418)
                                       |                              |- 'male' (265766)
                                       |                              |- 'other' (53153)
                                       |                              `- 'rather not say' (35435)
                                       |- '55-64' (1751752) -- gender -- 'female' (1401402)
                                       |                              |- 'male' (262763)
                                       |                              |- 'other' (52552)
                                       |                              `- 'rather not say' (35035)
                                       `- '65+' (1061061) ---- gender -- 'female' (848849)
                                                                      |- 'male' (159159)
                                                                      |- 'other' (31832)
                                                                      `- 'rather not say' (21221)
In addition to that I have created functions for things like algorithmically generating unique usernames.

Then I have a tree walker that yields all of the combinations represented by the tree. From the tree above we would yield { 'age': '18-24', 'gender': 'female' } a total of 1,201,201 times, { 'age': '18-24', 'gender': 'male' } a total of 225,225 times and so on. (Again, the real tree is deeper than this -- there's more than just age and gender in the actual model. Also, age is specified at a more fine-grained level but the concept is the same.)

I retrieve these values from the generator function in batches and generate sample user profiles based on that.

So within a span like '18-24' I linearly distribute dates of birth by calculating (upper date bound - lower date bound) / count and using that as the delta to step the date of births by within the span starting from the lower date bound. (And of course the more fine-grained your spans are, the lesser the impact of linearly distributing values within each span.)

And I generate additional properties that are pseudo-random like usernames.

The script execution time is presently down to about 6 and a half minutes for generating and copying (using copy instead of insert was another optimization I made to the script along with a few others from https://www.postgresql.org/docs/current/populate.html after meticulously measuring that said optimizations had a significant positive impact on the time it took to put the data into the db), memory usage is very reasonable, and with the most recent commit I made which makes the generated usernames guaranteed to be unique (for up to a set number of generated user above the 10,000,000 I am doing), the stage is set for running the script on as many cores as your computer has to offer, further cutting down the script execution time.

Anyway, now on to how any of this is relevant to your comment.

I wrote this tool as part of my development process because a lot of the value that the project will offer to its users is tied directly to segmenting the users by various facets, and so I need sample data that allows me to explore the user experience while developing the project.

But I also think that this sort of tool could be useful in the situation that you guys are talking about here.

So when you are doing a migration you could generate a smaller test set of data that realistically reflects the real data of your users and you could then run the migration on that test set to get a very good idea about the cost of the various operations like you wanted. Agree?

Also, if anyone else knows of similar tools to mine I am always interested in knowing about them. Discovering what exists already can be hard and I have gotten to learn about many interesting and useful tools through discussions with others.

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#42
post #39

Earlier quoted context omitted.

I can't tell you how many times over 20 years I've heard a DBA tell me "the statistics weren't updated" after an incident.

I've written cron jobs to update mysql statistics to prevent it from choosing bad query plans. It's as terrible as it sounds.

How come it's not automatic and built-in? Why is a script terrible? (Does it have to enumerate all tables and piecewise run the stat update?)

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#43

I am convinced that data migration is definitely one of the hardest problems in data management and systems engineering. There are basically no solutions today that satisfy fundamental requirements such as minimizing downtime and guaranteeing correctness. It is _such_ a huge problem that most inexperienced developers see kicking the problem down the line with NoSQL document storage as a viable alternative (it isn't;…

> NoSQL document storage as a viable alternative (it isn't; you'll be either dealing with migrating all data forever and special-casing every old version of your documents, or writing even more convoluted migration logic). In practice (with Mongo at least) you end up with migrations being from arbitrary JSON to different arbitrary JSON, and come to rely on the Javascript runtime for anything even a bit complex. It's…

You are not barred from using a schema in your upper layer. And it is very much advised to do so to maintain sanity.

It just means that the migration can be done on-the-fly as data is touched / read / written, without downtime, but with support for both new-and-old versions in your backend. (Or if you want the SQL style migration, then yes, you need to write a script. And perform a flag day style backend update. Which is not advised.)

In reality, usually best migration strategies - sql or no - use a two phase process. First expansive changes run, which remain backward compatible with the old schema/structure, the backend is updated, then later when the new version of the backend is sort of verified to work well with the new schema/structure, a contraction can be run which removes the old structures/columns/tables/etc. This is especially helpful for providing blue-green automated deployment (which is great for continuous deployments).

And what is missing is usually a tool to verify that your expansive changes are truly backward compatible, and that the contractive changes don't contract too much (don't delete any of the new structures). - And this is easier if you simply manage this as part of "the backend". (Or it can be simply extracted into a service, which wraps the backing/data store.)

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#44
post #42
post #39

Earlier quoted context omitted.

I've written cron jobs to update mysql statistics to prevent it from choosing bad query plans. It's as terrible as it sounds.

How come it's not automatic and built-in? Why is a script terrible? (Does it have to enumerate all tables and piecewise run the stat update?)

Yes, the stats update is per table. We only updated it for a few tables we really cared about.

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#45
post #31

This covers a lot of ground that I've recently had to learn the hard way. One item I've been considering; under Downtime, a reason for flakes in migrations is "long running transactions". I've seen this too, and wonder if the correct fix is actually to forbid long-running transactions. Typically if the naive long-running transaction does something like: with transaction.atomic(): for user in User.objects.all(): user.…

No,

  with transaction.atomic():
    for user in db.users.all():
      user.do()
is not the same as

  for user in db.users.all():
    with transaction.atomic():
      user.do()
If the first fails, the entire data rolls back, if the second fails, half your db might be in an inconsistent state.

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#46
post #19

Earlier quoted context omitted.

Because when you change the representation of data at rest, you need to "migrate" that data to the new representation. I agree that schema changes are not migration, but I think the author correctly uses the word "migration" to mean migrating their data in the database to some new schema representation.

This is true, but it's a bit of an implementation detail. All I'm doing is a schema change; a migration is what the database does under the hood to facilitate it.

The database doesn't know how to perform a data migration for you, however. Sometimes it's possible to do it in SQL as part of the schema upgrade but that isn't always possible, in which case you need to implement it in the application. But regardless of how you implement it, it's still "data migration" because you're migrating data from one representation to another and your database won't always know how to do that "under the hood" for you.

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#47

Earlier quoted context omitted.

I don't know, at my current job I've been introduced to DACPACs[1] and I really like it. The ability to do schema/data compares between arbitrary environments and generate the migrations in real time is awesome. [1] - https://docs.microsoft.com/en-us/sql/relational-databases/da...

Doesn't Django already do this?

Skimming through the page, it looks like there's a lot more functionality there than Django has.

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#48
post #45
post #31

This covers a lot of ground that I've recently had to learn the hard way. One item I've been considering; under Downtime, a reason for flakes in migrations is "long running transactions". I've seen this too, and wonder if the correct fix is actually to forbid long-running transactions. Typically if the naive long-running transaction does something like: with transaction.atomic(): for user in User.objects.all(): user.…

No, with transaction.atomic(): for user in db.users.all(): user.do() is not the same as for user in db.users.all(): with transaction.atomic(): user.do() If the first fails, the entire data rolls back, if the second fails, half your db might be in an inconsistent state.

Yes, of course, they are not the same. I did not claim they were. I said:

> You can often recast that migration to something more like

By which I mean, in my experience you can usually write your migrations so that your code can work with the old AND the new version of the data, in which case you don't need to have a transaction around the whole operation.

This takes more work but is safer:

https://martinfowler.com/bliki/ParallelChange.html

https://www.amazon.com/Refactoring-Databases-Evolutionary-pa...

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#49
post #31

This covers a lot of ground that I've recently had to learn the hard way. One item I've been considering; under Downtime, a reason for flakes in migrations is "long running transactions". I've seen this too, and wonder if the correct fix is actually to forbid long-running transactions. Typically if the naive long-running transaction does something like: with transaction.atomic(): for user in User.objects.all(): user.…

> But how do we test that our migrations behave correctly in the face of long-running transactions? I.e. what's the failing test case for that bug?

Isn't it enough to simply make sure the migration transaction successfully finished? Even if there is a long running transaction, if the migration finished, that long tx will get aborted and rolled back.

Or if the migration stalls because the long running tx, then you'll presumably get a timeout error.

Is there something I'm missing?

Re: Move Fast and Migrate Things: How We Automated Migrations in Postgres

#50

In postgresql if you are using prepared statements and are doing a 'select star' and drop or add a column then the prepared statement will start failing. This is kind of bad when you are doing transactions because the bad statement will taint your transaction and you will need to restart from the beginning. Select star is incompatible with prepared statements and postgresql which might also explain why SQL Alchemy ex…

> This is kind of bad when you are doing transactions because the bad statement will taint your transaction and you will need to restart from the beginning.

Why is this bad? Can you handle this on the application side somehow? Even if it just means restarting Rails when the migration has finished.

Or the problem is that you want 0 downtime and 0 UX impact migration?

Post reply on HN