Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Sqlfmt: an opinionated online SQL formatter

cockroachlabs.com

Post reply on HN
Print view View original

41–50 of 94 posts

Re: Sqlfmt: an opinionated online SQL formatter

#41

Post by vbezhenar »

justin_oaks wrote: post #26

Tangentially related. I'm of the opinion that SQL shouldn't be uppercased. I don't want to hit shift or caps lock and I find lowercase easier to read. Are there others out there like me? I assume I'm in the minority, but I don't understand why. People stopped uppercasing HTML tags, why can't we do the same with SQL?

I never understood why people want to uppercase anything. It's like source code from 1970, when even bold highlight was something unavailable and developers used uppercase for keywords. I don't uppercase SQL, I prefer software which does proper highlighting.

Re: Sqlfmt: an opinionated online SQL formatter

#42

Post by egorfine »

mjibson wrote: post #17

Author here. Based on feedback I am going to make a sqlfmt binary for easy editor integration. You can currently already do this by using the CockroachDB binary ( https://www.cockroachlabs.com/docs/releases/v2.1.0-beta.2018... ) but understandably people want a more minimal solution.

Hey, thank you for the formatter! I really like the way it formats statements. Although I have found two issues:

1. It lowercases table and field names, rendering the formatted statement useless for a project with not exclusively lowercased names. Could you please fix this?

2. I'd appreciate accepting common placeholder "?" as a valid part of the SQL statement so that we can format queries with placeholders. Would that be possible?

Re: Sqlfmt: an opinionated online SQL formatter

#43

Post by mjibson »

egorfine wrote: post #42
mjibson wrote: post #17

Author here. Based on feedback I am going to make a sqlfmt binary for easy editor integration. You can currently already do this by using the CockroachDB binary ( https://www.cockroachlabs.com/docs/releases/v2.1.0-beta.2018... ) but understandably people want a more minimal solution.

Hey, thank you for the formatter! I really like the way it formats statements. Although I have found two issues: 1. It lowercases table and field names, rendering the formatted statement useless for a project with not exclusively lowercased names. Could you please fix this? 2. I'd appreciate accepting common placeholder "?" as a valid part of the SQL statement so that we can format queries with placeholders. Would th…

The formatter adheres to CockroachDB rules which is why it acts like you describe. Case is insensitive in names unless you double quote it. Postgres-style (CockroachDB is one) uses "$1" for placeholders instead of "?". Adding "?" would complicate our grammar enough that it's not worth adding it.

sqlfmt is not super useful for non-postgres grammars.

Re: Sqlfmt: an opinionated online SQL formatter

#45

Post by yebyen »

justin_oaks wrote: post #26

Tangentially related. I'm of the opinion that SQL shouldn't be uppercased. I don't want to hit shift or caps lock and I find lowercase easier to read. Are there others out there like me? I assume I'm in the minority, but I don't understand why. People stopped uppercasing HTML tags, why can't we do the same with SQL?

I'm with you, I prefer to uppercase the keywords only, but most SQL formatters are more liberal with their uppercasing.

Re: Sqlfmt: an opinionated online SQL formatter

#46

Post by Groxx »

justin_oaks wrote: post #26

Tangentially related. I'm of the opinion that SQL shouldn't be uppercased. I don't want to hit shift or caps lock and I find lowercase easier to read. Are there others out there like me? I assume I'm in the minority, but I don't understand why. People stopped uppercasing HTML tags, why can't we do the same with SQL?

I do the same. hand-cased words don't uniquely identify keywords or not, and more than once I've seen keywords not-upcased or column names that shadow keywords (with inconsistent upcasing), so they're inherently untrustworthy anyway.

Just use syntax highlighting, which can make it unambiguous what's a keyword vs func vs name.

Re: Sqlfmt: an opinionated online SQL formatter

#48

Post by gregwebs »

ianmcgowan wrote: post #25

The problem with opinions is everyone has a different one. I like https://www.sqlinform.com/ - keep a copy of notepad around just so I can use it. Wish there was a VSCode extension. The free version was good enough for my needs, but it's so handy I upgraded to the pro version just to show appreciation. The best part is the ability to really customize the layout and save the settings. It's always step #1 when someone…

works for the mentioned case of SELECT 1, 2

Web site is kind of horrible.

Re: Sqlfmt: an opinionated online SQL formatter

#49

Post by pletnes »

justin_oaks wrote: post #26

Tangentially related. I'm of the opinion that SQL shouldn't be uppercased. I don't want to hit shift or caps lock and I find lowercase easier to read. Are there others out there like me? I assume I'm in the minority, but I don't understand why. People stopped uppercasing HTML tags, why can't we do the same with SQL?

The same can be seen in the fortran community. The common factor is that both languages are case insensitive. All upper case makes no sense whatsoever.

Re: Sqlfmt: an opinionated online SQL formatter

#50

Post by JelteF »

Looks really cool, but I have one suggestion. Have you considered using leading commas? It makes big SQL statements much easier to edit and it improves diffs. I normally use trailing commas for my code, but most sql dialects don't support it so I fallback to leading ones there.
Post reply on HN