41–50 of 55 posts
I'd really like a code review tool that is code aware. That is, it treats the diff as code instead of plain text. I'd like to be able to figure out where a method is called from, go to definition and so on. Basically the same stuff I can do in my editor, but without having to clone the branch.
Here you go poor fella https://www.jetbrains.com/upsource/
It runs off a server inside your company, but you can try it out on open-source code on GitHub with the Sourcegraph Chrome extension: https://chrome.google.com/webstore/detail/sourcegraph-for-gi....
My personal best tool for a Git branch's code review is `git lfo`, where the alias expands to: git log --pretty=full --reverse --show-notes=* -p --abbrev-commit origin/master.. Coupled with a "good diff highlighter", i.e. `diff-highlight | less --tabs=4 -RFX`… I'm set. I've yet to see a tool that allows me to review all commits as well as code, as easily. I don't only review a branch as a whole, i.e. `git diff master…
https://www.reviewboard.org/ is nice, imo.
I'd really like a code review tool that is code aware. That is, it treats the diff as code instead of plain text. I'd like to be able to figure out where a method is called from, go to definition and so on. Basically the same stuff I can do in my editor, but without having to clone the branch.
Moved from gitlab to Gerrit . It was awkward in the starts but I like this more now. Functionality over pretty .
Can you elaborate? Which functionality?
Gerrit: https://www.gerritcodereview.com . Hands-down.
I have only used the installed version, not the hosted online version.
The basic PR structure is simple. Very much the same as in github.
In detail the implementation has several nasty defincies. They do not distinguish author and committer at all, which can lead to very misleading info on the screen if they are different
There are PR comments and line comments. Sometimes a file comment might be appropriate, but that does not exist.
The code viewer has limitations so I find myself using git difftool with meld or something like that in more difficult cases. Of course the difficult cases is where review and tool support would be needed most.
IMHO the biggest problem is that line comments are a one time thing lost in space afterwards. You need to know in which PR to look, actually even in which file version of the PR if the file has been updated during the review. There is no direct way to access previous review comments relating to certain code. Not sure if anybody else handles that better.
The languages are wide and varied, the questions and answers are actively curated and moderated, the solutions range from the simple to the overtly complex. The support for code markdown is more than adequate, and of course, the StackExchange voting system helps bring the best questions and answers to the fore.
There's even an integrated chat system as part of the network, where mods, reviewers and questioners can collaborate and discuss issues.