Douane personal firewall for GNU/Linux • Hacker News Board

Re: Douane personal firewall for GNU/Linux

#41

Post by ori_b » Sun, Jan 22, 2017, 5:59 AM UTC

iMerNibor wrote: post #38

ori_b wrote: post #36

Earlier quoted context omitted.

And it's still wrong, since strncpy() doesn't null terminate: it null pads. That means that if the string is longer than the buffer, it will not be correctly terminated.

They do check the string size before using strncpy though, so it should be fine

The check is off by one. If it's equal in length to the buffer, then the buffer will not be nul terminated.

Re: Douane personal firewall for GNU/Linux

#42

Post by epse » Sun, Jan 22, 2017, 8:41 AM UTC

Ugh, grammar error on the first page. "did not expected"

Re: Douane personal firewall for GNU/Linux

#43

Post by BozeWolf » Sun, Jan 22, 2017, 8:48 AM UTC

cammio wrote: post #19

dimitar wrote: post #12

Douane is "Customs" (as on a border between countries) in French. Clever name!

and in dutch

Who got it from the French, like many words in Dutch :)

Re: Douane personal firewall for GNU/Linux

#44

Post by ramchip » Sun, Jan 22, 2017, 9:00 AM UTC

awordnot wrote: post #15

I would be careful, a critical buffer overflow vulnerability was just found in the Douane kernel module: https://github.com/Douane/douane-dkms/commit/61023b91fbafab8...

Comments like this never fail to make me smile:

    +  // Don't do anything if the process_path length is > PATH_LENGTH
    +  if (strlen(process_path) > PATH_LENGTH)
    +    return;

Re: Douane personal firewall for GNU/Linux

#45

Post by vetinari » Sun, Jan 22, 2017, 12:36 PM UTC

notalaser wrote: post #32

oneplane wrote: post #31

Earlier quoted context omitted.

I'm not entirely sure what GTK or GTK point releases have to do with it. Isn't it just a programming framework with a GUI?

It's a very popular one. However, for the last couple of years, minor releases of a supposedly stable branch included backwards-incompatible changes that broke applications and themes. Basically, upgrading from 3.8 to 3.10 resulted in applications looking funny and some of them crashing. Quite a few application and theme developers ended up calling quits -- stopped maintaining their applications, kept on using GTK 2…

> minor releases of a supposedly stable branch included backwards-incompatible changes that broke applications and themes.

No, the releases broke only themes and exactly that was communicated - that the CSS engine was work in progress and that themes were going to be broken.

Those, who didn't want to listen complained afterwards. Color me surprised.

Re: Douane personal firewall for GNU/Linux

#46

Post by notalaser » Sun, Jan 22, 2017, 7:02 PM UTC

vetinari wrote: post #45

notalaser wrote: post #32

Earlier quoted context omitted.

It's a very popular one. However, for the last couple of years, minor releases of a supposedly stable branch included backwards-incompatible changes that broke applications and themes. Basically, upgrading from 3.8 to 3.10 resulted in applications looking funny and some of them crashing. Quite a few application and theme developers ended up calling quits -- stopped maintaining their applications, kept on using GTK 2…

> minor releases of a supposedly stable branch included backwards-incompatible changes that broke applications and themes. No, the releases broke only themes and exactly that was communicated - that the CSS engine was work in progress and that themes were going to be broken. Those, who didn't want to listen complained afterwards. Color me surprised.

Just from memory, changes in the way GTK handles geometry hints broke stuff in a bunch of applications, such as ROX Terminal. I think that was in 3.20. I haven't really followed development after 3.16 or so, I try to avoid GTK 3 applications when I can.

The decision to include "work in progress" code in stable releases is also a little questionable.