The Single Piece of JavaScript on HN • Hacker News Board

Re: The Single Piece of JavaScript on HN

#41

Post by percept » Thu, Mar 17, 2016, 10:42 PM UTC

aaronbrethorst wrote: post #25

gordonzhu wrote: post #11

Earlier quoted context omitted.

What's most fascinating to me about this isn't the simplicity, it's that this code has lived for so long with almost no changes. It's a great counter-example to all the recent articles about JavaScript fatigue. It's good for us to see real examples of sites that aren't caught up in the framework of the week hype. At the end of the day we're trying to make stuff that works. ES5 vs ES6, React vs Angular vs. Ember vs. A…

For the majority of cases that I've seen, these arguments are simply excuses to avoid doing real work. It's way more fun to decide whether your amazingly awesome Unicorn startup is going to use React or Angular, or Express vs. Rails, or whatever than it is to actually go through the hard work of building a customer base and making money.

The problem (from my perspective) is that the job market follows. It's good at that--always following.

Re: The Single Piece of JavaScript on HN

#42

Post by raldi » Thu, Mar 17, 2016, 10:42 PM UTC

mwcampbell wrote: post #38

The HTTP request for voting should be a POST request, not a GET request, since it changes state. So both the JS hack involving an image and the non-JS fallback are broken. The JS function should use XHR, and I guess the non-JS fallback should be a form with an image button, not a link.

"However, this is not completely true. It means: it won't change the resource representation. It is still possible, that safe methods do change things on a server or resource, but this should not reflect in a different representation."

http://restcookbook.com/HTTP%20Methods/idempotency/

Re: The Single Piece of JavaScript on HN

#43

Post by xupybd » Thu, Mar 17, 2016, 10:44 PM UTC

aaronbrethorst wrote: post #25

gordonzhu wrote: post #11

Earlier quoted context omitted.

What's most fascinating to me about this isn't the simplicity, it's that this code has lived for so long with almost no changes. It's a great counter-example to all the recent articles about JavaScript fatigue. It's good for us to see real examples of sites that aren't caught up in the framework of the week hype. At the end of the day we're trying to make stuff that works. ES5 vs ES6, React vs Angular vs. Ember vs. A…

For the majority of cases that I've seen, these arguments are simply excuses to avoid doing real work. It's way more fun to decide whether your amazingly awesome Unicorn startup is going to use React or Angular, or Express vs. Rails, or whatever than it is to actually go through the hard work of building a customer base and making money.

Totally agree. One problem I find arises from this is that there are no boring workhorses. Time and time again I need boring crud screens, for the admin side of applications, but there is no easy default to choose. ExtJS tends to do the trick, but it's not cheap.

Re: The Single Piece of JavaScript on HN

#44

Post by [deleted] » Thu, Mar 17, 2016, 10:46 PM UTC

lurker2015 wrote: post #6

seanalltogether wrote: post #3

If we ever make it around to a second piece of javascript on here, can I request that it be a collapse comment function? I promise i won't ask for anything else.

Is there anything like Reddit Enhancement Suite for HN? Any recommendations out there?

[deleted]

Re: The Single Piece of JavaScript on HN

#45

Post by olavgg » Thu, Mar 17, 2016, 10:46 PM UTC

mwcampbell wrote: post #38

The HTTP request for voting should be a POST request, not a GET request, since it changes state. So both the JS hack involving an image and the non-JS fallback are broken. The JS function should use XHR, and I guess the non-JS fallback should be a form with an image button, not a link.

Actually, another way to do this is to create a form with the POST method that respond with status 204(which will not refresh the page). There is still no need to involve the XHR. I still think this solution is neat though.

Re: The Single Piece of JavaScript on HN

#46

Post by gordonzhu » Thu, Mar 17, 2016, 10:47 PM UTC

wrigby wrote: post #26

When you're not logged in, the `onclick` attributes aren't present in the anchor tags.

When you try to vote it will ask you to log in.

Re: The Single Piece of JavaScript on HN

#47

Post by marknadal » Thu, Mar 17, 2016, 10:48 PM UTC

Why was this post taken off the homepage? EDIT: Now it has been restored, odd.

Re: The Single Piece of JavaScript on HN

#48

Post by olavgg » Thu, Mar 17, 2016, 10:49 PM UTC

harlanlewis wrote: post #28

BowBun wrote: post #8

Not much to say, really. Just some simple code. What I'm curious is if someone can reiimplement this without and javascript.

This won't save any votes, but: input, input:checked ~ label { display: none; } --- Up Down

And if you wrap that inside a form that submit this to a url that respond with status 204, this will work without any js :-)

Re: The Single Piece of JavaScript on HN

#49

Post by podgib » Thu, Mar 17, 2016, 10:50 PM UTC

mwcampbell wrote: post #38

The HTTP request for voting should be a POST request, not a GET request, since it changes state. So both the JS hack involving an image and the non-JS fallback are broken. The JS function should use XHR, and I guess the non-JS fallback should be a form with an image button, not a link.

This code is simple, works reliably and has done so for a long time with no changes. That seems like the opposite of broken to me

Re: The Single Piece of JavaScript on HN

#50

Post by [deleted] » Thu, Mar 17, 2016, 10:50 PM UTC

mwcampbell wrote: post #38

The HTTP request for voting should be a POST request, not a GET request, since it changes state. So both the JS hack involving an image and the non-JS fallback are broken. The JS function should use XHR, and I guess the non-JS fallback should be a form with an image button, not a link.

[deleted]