Live data from Hacker News

My Favourite Git Commit

fatbusinessman.com

371–380 of 389 posts

Re: My Favourite Git Commit

#371

Earlier quoted context omitted.

Every commit message must start with JIRA ticket number

I find that awful, because now half your subject line is burned by completely useless information: the JIRA ticket number doesn't provide any useful information when reading a git log / summary.

Yeah and if you no long use JIRA it's not useful. Whatever bug tracking software you use should allow for commits to be attached to bugs. But that should stay in the bug tracking software, not the VCS.

Re: My Favourite Git Commit

#372

Earlier quoted context omitted.

...you're going to want me...kept away from others due to HR cringing at my presence.

You're not filtering him out of the hiring pool, he's filtering you. ;)

Yeah, my own resume isn't (or wasn't, it has been years since i updated it) that flair-y, but it does have a sidebar with screenshots of stuff i worked on (with my face doing a weird look at the top) and is in mostly prose style with bold text for each of the projects i worked on (bold helps to scan for stuff, at least that was the idea). I've been told a few times (by friends) that this isn't how resumes are supposed to look like but my line of thinking is that if you are so stuck up that you want a specific format for a resume, then you're most likely too stuck up for me to want to work with you :-P.

Re: My Favourite Git Commit

#373

I think my favorite (in terms of humor) is a commit from mpv complaining about locales and encodings. You can practically feel the committer's sheer frustration. [1] https://github.com/mpv-player/mpv/commit/1e70e82baa9193f6f02...

This is why i stick with ASCII :-P.

Re: My Favourite Git Commit

#375

Earlier quoted context omitted.

Every commit message must start with JIRA ticket number

I work at a place that used to prescribe this. I dislike it because it adds too much repetitive noise to the abridged git log. (It occurs to me that you may be making this point in a tongue-in-cheek way.) Originally I suggested we put the JIRA number/link in the commit body, but then I learned about git-notes to add metadata to commits and now I kinda want to do this with the semantic labels suggested by the thread O…

And I've used git nearly every day for more than a decade and written a git client, and this is the first time I've heard of notes. Thanks!

Re: My Favourite Git Commit

#376

OR you could just write Replace invalid ASCII char. Fixes rake error 'invalid byte sequence in US-ASCII'. I don't want your entire life story in my commit log.

I agree with the sentiment; this message is quite long for an invalid character in a file.

House style in the companies I've worked for is to include a link to a bug report and or code review that provides more context for those who want it. Even without that added context, I'd rather know

Re: My Favourite Git Commit

#377
Adding a test to prevent this error in the future would also be nice to see, something to mention in code review... Which the commit message makes much easier (without explanation this diff is confusing).

Re: My Favourite Git Commit

#378

Earlier quoted context omitted.

You're not filtering him out of the hiring pool, he's filtering you. ;)

Yeah, my own resume isn't (or wasn't, it has been years since i updated it) that flair-y, but it does have a sidebar with screenshots of stuff i worked on (with my face doing a weird look at the top) and is in mostly prose style with bold text for each of the projects i worked on (bold helps to scan for stuff, at least that was the idea). I've been told a few times (by friends) that this isn't how resumes are suppose…

My team is in a full-on hiring spree right now. I've opted out of it because there's no process.

Ultimately, it boils down to people's gut feelings, which is so disgustingly random.

Re: My Favourite Git Commit

#379

Earlier quoted context omitted.

Every commit message must start with JIRA ticket number

I work at a place that used to prescribe this. I dislike it because it adds too much repetitive noise to the abridged git log. (It occurs to me that you may be making this point in a tongue-in-cheek way.) Originally I suggested we put the JIRA number/link in the commit body, but then I learned about git-notes to add metadata to commits and now I kinda want to do this with the semantic labels suggested by the thread O…

Notes kinda bloat the repository with additional objects, and they can be removed independent from the commits, so I'm a bit iffy on using them for this.
Post reply on HN