Live data from Hacker News

A new home and license (AGPL) for Synapse and friends

element.io

301–304 of 304 posts

Re: A new home and license (AGPL) for Synapse and friends

#301
post #131

Earlier quoted context omitted.

> PRs I sent were rewritten, squashed and merged by the Dendrite team, instead of them just doing reviews and asking me to fix what they considered unfitting(substandard/wrong. Core devs rewriting and fixing up PRs typically saves a ton of development effort. We field lots of PRs and while I make my best effort to hold their hand to get tests written and such, at some point it's intensely wasteful of everyone's time…

I second this. As a maintainer, I have a very good understanding of how long it would take (someone familiar with the codebase) to make certain changes. It's far from disrespectful to push before merging when the alternative is to waste both the contributor's time and my own on at least 1 round of purely code style feedback. As a drive-by contributor, I always leave the box checked—the parent commenter seems to be un…

> As a drive-by contributor, I always leave the box checked—the parent commenter seems to be unaware that GitHub gives you this option

I have no idea what this is. Can you share specifics?

Re: A new home and license (AGPL) for Synapse and friends

#302
post #301

Earlier quoted context omitted.

I second this. As a maintainer, I have a very good understanding of how long it would take (someone familiar with the codebase) to make certain changes. It's far from disrespectful to push before merging when the alternative is to waste both the contributor's time and my own on at least 1 round of purely code style feedback. As a drive-by contributor, I always leave the box checked—the parent commenter seems to be un…

> As a drive-by contributor, I always leave the box checked—the parent commenter seems to be unaware that GitHub gives you this option I have no idea what this is. Can you share specifics?

When you open a PR, look for the "Allow edits by maintainers" checkbox beside the "Create pull request" button. For PRs you've made earlier, you can find it in the sidebar under the participants list.

[1]: https://docs.github.com/en/pull-requests/collaborating-with-...

Re: A new home and license (AGPL) for Synapse and friends

#303
post #155

Earlier quoted context omitted.

Yes. That's why you shouldn't contribute to software on permissive licenses. > What difference does it make to the community if Element gets paid for this? Without that, Element would have to either pay people their fair share, or _leave_. They're not a charity, they're not doing this "for us," they're just extracting free labor.

Personally I would never contribute to AGPL software. I don’t want my contribution to forever be stuck in some political movement. I do contribute to permissive licensed software.

That sounds quite sad.

Re: A new home and license (AGPL) for Synapse and friends

#304
post #301

Earlier quoted context omitted.

> As a drive-by contributor, I always leave the box checked—the parent commenter seems to be unaware that GitHub gives you this option I have no idea what this is. Can you share specifics?

When you open a PR, look for the "Allow edits by maintainers" checkbox beside the "Create pull request" button. For PRs you've made earlier, you can find it in the sidebar under the participants list. [1]: https://docs.github.com/en/pull-requests/collaborating-with-...

oh that thing. I've always found the flow for "editiable PRs" in github to be horrendously confusing and difficult to use. we do all of our edits in Gerrit.

I was hoping you meant a checkbox that says, "this contributor is OK with the maintainers taking over this PR to finish it up"

Post reply on HN