Live data from Hacker News

App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

github.com

301–310 of 446 posts

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#301

Earlier quoted context omitted.

The number of people who use whatsapp is an order of magnitude or more than the number of people who consciously use Google drive, as in people who know google drive exists. Even the people who have google drive, most of them have much less intimate data on it than in their private messages on WhatsApp. If we are to take the position that all users are tech literate and should be fully in charge of how their data is…

And you are still avoiding the equivalence that everything you describe is already happening with sms messages at least, and generally much more. None of your arguments carry any weight especially since they don’t explain why it’s ok for data to be unencrypted on your google drive in the first place.

That wasn't the only argument though. If the data was encrypted with a facebook held private key, the user would still not be able to see it. If it was E2E encrypted with the only key being on the device, people will get mad when they reset their phone and get a new one, only to find their messages are gone.

SMS had the same problems forever, but isn't owned by a company, thus you can't blame xyz company if random apps access your SMS. No company got ever investigated by multiple nation states over that.

You still haven't addressed my main question though, how will a random app scraping your WhatsApp be any less of a scandal than Cambridge Analytica?

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#302
post #222

Earlier quoted context omitted.

NSNull is not the null you think

It may not be a conventional null, but I'm not aware of any tech where calling "count" on a Null, .nil? or otherwise null-like construct won't end horribly.

The Facebook SDK is written in obj-c, where calling `count` on `nil` is perfectly valid and returns 0. It only doesn't work on NSNull, which is a weird different thing that does not work like the language's built-in null.

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#303
post #267

Earlier quoted context omitted.

This is a native SDK that is crashing the process. There is nothing an app developer can responsibly do to prevent or recover from this crash. Other than remove the SDK, of course.

So there is no way to try {} catch {} it, right?

If it's an objective C exception, you can catch those with an objective c wrapper function. Ive done that before in my Swift projects.

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#304
post #292

The most popular apps on one of the most popular operating systems just plainly don't even open. What has this industry become? How are we so goddamn inept at writing software? This is an industry where we can automate testing - not many other industries have this capability - and we still don't have a simple test regime of "check if the app opens" for any of those apps. Somehow, at the most valuable software compani…

There is more complexity in this. Proximate Issues The app makers cannot easily prevent the crash since it is happening in Facebook provided code. Perhaps the only thing they could do is to code in kill switches. Another possibility would be to modify the Facebook code. That introduces maintainability issues. The crash happened because of a server side change that triggered roughly the Objective-C equivalent of a nul…

> The crash happened because of a server side change that triggered roughly the Objective-C equivalent of a null pointer exception.

> Objective-C is an old unsafe language.

This was a safe crash, not an unsafe one. Swift can and would crash the same way.

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#305
post #298

Earlier quoted context omitted.

This is a native SDK that is crashing the process. There is nothing an app developer can responsibly do to prevent or recover from this crash. Other than remove the SDK, of course.

Yes there is: a remote kill switch that prevents the third party SDK from loading. That puts you back in control of the software you’re shipping. Fool me once, and all that.

You have to be technically competent enough to know how to dynamically load a framework, though.

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#306

Earlier quoted context omitted.

Maybe lessons will be learned, maybe not. The industry seems to have very low standards. Let's let these mistakes happen over and over and let's just patch them as we go. No long-term thinking. Someone should collect all these horrible incidents and start a university course on just plainly what NOT to do.

Some of the very brightest software engineers in the world work at Facebook. As much as I would love to rip on Facebook, I also understand that integrated software development is hard, and I guarantee you that Facebook is "doing it better" than most. Don't sit in an ivory tower and throw stones in glass houses. Can you guarantee that your own SDLC house is in order? Because it might be, right up until a sneaky edge c…

Isn't Facebook the place that forces engineers to write code in a open bullpen environment? How can high quality code be written in a madhouse?

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#307
post #267

Earlier quoted context omitted.

This is a native SDK that is crashing the process. There is nothing an app developer can responsibly do to prevent or recover from this crash. Other than remove the SDK, of course.

So there is no way to try {} catch {} it, right?

Yes, but 1. it’s hard to inject that as the crash happens very early at launch and 2. Objective-C exceptions of this type are not intended to be caught.

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#308

Earlier quoted context omitted.

How do you defend against abort() in library code?

Don't include libraries which contain such code?

No abort here, the crash is coming from the runtime, which you’re not opting out of if you want your app to work.

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#309

Earlier quoted context omitted.

Maybe lessons will be learned, maybe not. The industry seems to have very low standards. Let's let these mistakes happen over and over and let's just patch them as we go. No long-term thinking. Someone should collect all these horrible incidents and start a university course on just plainly what NOT to do.

Some of the very brightest software engineers in the world work at Facebook. As much as I would love to rip on Facebook, I also understand that integrated software development is hard, and I guarantee you that Facebook is "doing it better" than most. Don't sit in an ivory tower and throw stones in glass houses. Can you guarantee that your own SDLC house is in order? Because it might be, right up until a sneaky edge c…

Bright engineers sometimes do some very stupid, arrogant things.

Re: App suddenly crashing on startup due to FBSDKRestrictiveDataFilterManager.m

#310
post #157

Earlier quoted context omitted.

Do you really need the SDK for Facebook Login? It's just OAuth.

Yes. FB will block your app for implementing FB sign in on iOS/Android without their SDK.

Block you from where?
Post reply on HN