Live data from Hacker News

Linthub: Static code analysis for GitHub pull requests

linthub.io

31–35 of 35 posts

Re: Linthub: Static code analysis for GitHub pull requests

#31
There is a free open source alternative written in Python: https://github.com/justinabrahms/imhotep

It runs on the commit diff with a specified linting tool (used it with pep8 and jshint), it is also fairly easy to add new linters.

Here's a fork that works nicely with Travis: https://github.com/glowdigitalmedia/imhotep

Re: Linthub: Static code analysis for GitHub pull requests

#32
post #24

Earlier quoted context omitted.

Adding a commit status would be nice. It'd fail whilst the most recent commit has had a commit-comment on it.

The commit status have been added :-).

That was quick. Awesome! Do you have a sample pull with the new setup?

Re: Linthub: Static code analysis for GitHub pull requests

#33
post #2

This looks pretty awesome and will just get better as more languages get supported. But, it comments on commits, not on the diff in the PR. I think commeting on the diff looks nicer (you see code snippet with the comment) and in my opinion it's also easyer to find all the comments that way. Instead of clicking the commit hash on the commen each time.

Added Python and Ruby support btw. Supporting 9 languages now.

Re: Linthub: Static code analysis for GitHub pull requests

#34
post #9

Instead of using a service like this one (or Hound) that comments directly on pull requests, we chose to integrate the same tools in our build process with Phare ( https://github.com/mirego/phare ), a command-line tool we built which runs Rubocop, JSHint, JSCS, etc. and exits with a global status. If the code has coding style violations, the build breaks. Exactly like it would if we pushed a failing test. Personally,…

Same for me. I used Hound for a while but it was annoying to see all this comments. So I just added Rubocop check inside `rake test` so build is broken if you have code style issues
Post reply on HN