Live data from Hacker News

Source code of Polish electoral voting system?

github.com

31–40 of 64 posts

Re: Source code of Polish electoral voting system?

#31
https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... - if you can't connect to https://syswyb.kbw.gov.pl/, try an unencrypted connection to http://klk.kbw.gov.pl/.

It also looks like (unless I am missing something) 'liceneses' (signatures of authorised officials as far as I can tell) are checked for common name / organisational unit, but there is no check that the certificate trust chain is anchored on a trusted certificate.

Re: Source code of Polish electoral voting system?

#32
post #30
post #11

Earlier quoted context omitted.

The fact that the programmer is female is mentioned implicitly - the female version of the “programmer” pronoun is used, the fact is not really stated anywhere. So it should not to taken as „the shoulders of a novice, female programmer” (in which the fact that she is female is stated explicitly and could be used to further put down the person's programming abilities) but as „the shoulders of a novice programmer”.

Uhm, no, it is not. Did you miss the "Pani Agnieszko, naprawdę współczujemy, jesteśmy z panią!"("Ms. Agnes, we're really sorry too, we're here for you")(that's a terrible translation, but oh well) part? There's absolutely no ambiguity here.

I meant the “(female)” remarks in the grand-grandparent post.

Re: Source code of Polish electoral voting system?

#33
post #5

Earlier quoted context omitted.

A "more English" translation could read: Based on a cursory analysis of the executable and application development, it's clear that the act of writing the Election Calculator was entrusted to a single (female) student, who was probably working for external contractors. Ms. Agnieszka, we really sympathize, we are with you! Poland is a country in which the fate of thousands of committee members rests on the shoulders o…

To be fair it's a voting system , i.e. a program whose main function is to count , and unless the definition of "novice" these days is not what it used to be, it should be well within the ability of a "novice" programmer to write one.

Given the potential impact of the results, and the incentives in place for the final tally to be something other than the correct sum, the problem is not quite as simple as counting your sheep.

Think of it more like counting your sheep as lean and hungry gentlemen shout random numbers in your ear, dump disguised goats into your flock, continually jog your elbow if you try to write anything down, and toss sheep over the fences in both directions.

And then, just for fun, they stab you in a kidney and take your wallet.

The hard part is not the counting. It's dealing with the potential attacks and still being able to verify precise and accurate results.

Re: Source code of Polish electoral voting system?

#34
post #29
post #25

Haven't we all frowned upon picking on females in tech industry just yesterday?! It is NOT okay to wildly imply that the author of this code is of certain age and gender. EDIT: it was shown by the comment below that it was actually written by someone with a popular Polish female name. I was shaken by the article yesterday and thus oversensitive. Sorry about that.

Well, the implications are pretty well founded: - the binary has strings like `C:\Users\Agnieszka\...\Visual Studio 2013\Projects\Kalkulator1`. Agnieszka is a female Polish name -> the programmer is female. Although nobody really is using this as a discussion point anywhere, but hey, the fact is there if it's interesting to you. - the code logic and layout is pretty convoluted and looks duct taped together, even cons…

I don't know, I wouldn't judge a decompiled code.

Can you give a few examples why is it so bad?

Re: Source code of Polish electoral voting system?

#35
post #29

Earlier quoted context omitted.

Well, the implications are pretty well founded: - the binary has strings like `C:\Users\Agnieszka\...\Visual Studio 2013\Projects\Kalkulator1`. Agnieszka is a female Polish name -> the programmer is female. Although nobody really is using this as a discussion point anywhere, but hey, the fact is there if it's interesting to you. - the code logic and layout is pretty convoluted and looks duct taped together, even cons…

I don't know, I wouldn't judge a decompiled code. Can you give a few examples why is it so bad?

Keep in mind this is decompiled from IL, so the class/method/object mapping and naming remains from the original binary.

Here are a few, in my opinion, ugly examples:

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... and https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... and a few more instances of basically the same logic, copy-pasted (correct me if this might have been optimized from source code, as I'm a reverse engineer and not a C# programmer - but I'm pretty sure it's not)

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul...

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul...

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul...

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... and string-based HTML generation in general. Oh, and this method in general. It doesn't even fit on my screen without scrolling to the right.

I'm not saying it's a goldmine of DailyWTF-worth content - but it's still pretty bad. In general, it doesn't really follow any MVC-separation, the naming is arbitraty at best (and dictated by the IDE at worst - Kalkulator1, anyone?), and DRY principles are vastly ignored.

Re: Source code of Polish electoral voting system?

#36
post #29

Earlier quoted context omitted.

Well, the implications are pretty well founded: - the binary has strings like `C:\Users\Agnieszka\...\Visual Studio 2013\Projects\Kalkulator1`. Agnieszka is a female Polish name -> the programmer is female. Although nobody really is using this as a discussion point anywhere, but hey, the fact is there if it's interesting to you. - the code logic and layout is pretty convoluted and looks duct taped together, even cons…

I don't know, I wouldn't judge a decompiled code. Can you give a few examples why is it so bad?

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... :O

Re: Source code of Polish electoral voting system?

#37
post #29
post #25

Haven't we all frowned upon picking on females in tech industry just yesterday?! It is NOT okay to wildly imply that the author of this code is of certain age and gender. EDIT: it was shown by the comment below that it was actually written by someone with a popular Polish female name. I was shaken by the article yesterday and thus oversensitive. Sorry about that.

Well, the implications are pretty well founded: - the binary has strings like `C:\Users\Agnieszka\...\Visual Studio 2013\Projects\Kalkulator1`. Agnieszka is a female Polish name -> the programmer is female. Although nobody really is using this as a discussion point anywhere, but hey, the fact is there if it's interesting to you. - the code logic and layout is pretty convoluted and looks duct taped together, even cons…

I was not aware of those paths. I give up.

At least she used a fairly recent version Visual Studio...

Re: Source code of Polish electoral voting system?

#38
post #31

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... - if you can't connect to https://syswyb.kbw.gov.pl/ , try an unencrypted connection to http://klk.kbw.gov.pl/ . It also looks like (unless I am missing something) 'liceneses' (signatures of authorised officials as far as I can tell) are checked for common name / organisational unit, but there is no check that the certificate trust chain is anchored on a…

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... Is this correct generation of salt? It looks like someone just c&p an example from http://www.cprogramdevelop.com/1263984/

Re: Source code of Polish electoral voting system?

#39
post #25

Haven't we all frowned upon picking on females in tech industry just yesterday?! It is NOT okay to wildly imply that the author of this code is of certain age and gender. EDIT: it was shown by the comment below that it was actually written by someone with a popular Polish female name. I was shaken by the article yesterday and thus oversensitive. Sorry about that.

See, this is the kind of problem I have with feminism (and a few other things). It was just a feature of the language, exhibited heavily by most slavic languages (which have much richer grammars than English f. eg.) and thus impacting thought process, yet it was your a natural response to "defend the beatnen".

If you position yourself as a victim, don't be surprised when you are treated this way.

Re: Source code of Polish electoral voting system?

#40
post #7

Likely a fake. The company which wrote the system is recruiting just PHP developers, while this is written in C#. Of course this is all speculation. It may be truth and someone reconstruct the original version by decompiling it. e.g.: https://github.com/wybory2014/Kalkulator1/commit/cdff9cb67b8...

Electoral voting system written in PHP. Sounds like a good idea.

It is amazing that I knew your comment was sarcastic. But, a computer parsing this sentence would never be able to tell. This is a reason that humans are special :)
Post reply on HN