31–40 of 65 posts
In my last startup I started to build my own video.js theme, and after a few hours realized it probably wasn't worth my time and stuck with the defaults. Going forward these themes would give me a much better starting point to do something more custom.
Thanks for sharing!
When you click on the video itself, the left and right arrow keys work to scrub the video backwards and forwards. Up and down do nothing.
When you click on the scrubber, the left and right arrow keys stop working. Also, the up and down arrow keys start working to rewind/advance the video a different amount of time.
If you click in void space, e.g. on the Winamp example or the blue bar that looks like windows 98 on the Reelplay example - both of these controls stop working, as well as space to play/pause.
Latest chrome on macos.
There's some weirdness around focus going on here, hopefully this comes across as constructive criticism. All of them have the same problem: When you click on the video itself, the left and right arrow keys work to scrub the video backwards and forwards. Up and down do nothing. When you click on the scrubber, the left and right arrow keys stop working. Also, the up and down arrow keys start working to rewind/advance…
The situation is a little complex with "hot keys" for controlling the video in general (after clicking on the video), accessibility controls for each component, and then general accessibility expectations for the whole page. For example, should we capture the up and down arrows to always control volume when the player is in focus, or should we not do that because people expect that for scrolling the page.
All that said, we definitely have some iteration ahead of us on this front so thanks again for the input.
Player.style is excellent! In my last startup I started to build my own video.js theme, and after a few hours realized it probably wasn't worth my time and stuck with the defaults. Going forward these themes would give me a much better starting point to do something more custom. Thanks for sharing!
An old version of Winamp will load very quickly and run very well on modest hardware. This webpage does not scroll smoothly on a 2019 Mac Book Pro and there's a long delay in loading the gratuitous, confusing video you have on the page. You have created a massive performance regression for no reason.
Yeah, we admittedly have some performance improvements on the site itself. It’s brand new so that will come. The themes themselves are performant, though I don’t know how to compare that to the original Winamp. Thanks for the feedback!
I love it. Just one kindness: could you add subtitle tracks to the wizard? They are quite hard to add for now, since there is no documentation and media-chrome seems to use a different synthax.
If you're seeing something weird around subtitle syntax then there's probably a documentation issue somewhere (or I'm misunderstanding your question). Subtitles themselves should work with a standard `` in the media element, and the only other place we touch them is via the captions button/menu to toggle those tracks.
I love it. Just one kindness: could you add subtitle tracks to the wizard? They are quite hard to add for now, since there is no documentation and media-chrome seems to use a different synthax.
Thank you for the feedback! I'm not quite sure I'm following, though. By the wizard do you mean the framework/element picker within a theme? Would you want the wizard there to be something where you can put in a URL for a subtitle track and we'll add it to the generated tag? If you're seeing something weird around subtitle syntax then there's probably a documentation issue somewhere (or I'm misunderstanding your ques…
As for the synthax question, my point is that your script looks like this
And I just don't know how to interpolate the two
(Edit, checking further, I did manage to mix the two, and I can play subtitles over your demo video, but not over mine so I guess a foolproof sample in the wizard is probably needed :D )
Earlier quoted context omitted.
Thank you for the feedback! I'm not quite sure I'm following, though. By the wizard do you mean the framework/element picker within a theme? Would you want the wizard there to be something where you can put in a URL for a subtitle track and we'll add it to the generated tag? If you're seeing something weird around subtitle syntax then there's probably a documentation issue somewhere (or I'm misunderstanding your ques…
About the wizard, it would help if you just had a "Subtitles" checkbox somewhere which then adds a blank line to the script. As for the synthax question, my point is that your script looks like this And media chorme looks like this And I just don't know how to interpolate the two (Edit, checking further, I did manage to mix the two, and I can play subtitles over your demo video, but not over mine so I guess a foolpro…
Its refreshing to see this kind of work being done. Right now all the framework authors are going berserk about web-components and spewing "th3y suCk" and "w3bcomp0ents are N0T th3 futUr3!". Just nonsense. WC allow better reusability than ANY react-like framework can, and are universal. You can do pretty much anything with them. The hype train right now seem to be on SSR, and its just mad, like WTF we had server side rendering since the 90s, and then it was all about SPA's, and now they want to basically reimplement PHP era websites with SSR, making you pretty much vendor locked in to nodejs.
I take a WC over a bloated npm installed react project with 2345 dependencies any day. A WC that works today WILL work just as good if not better in 2036. Can your react do that?