Earlier quoted context omitted.
> Should Linux also accept North-Korean patches for their ICBMs in mainline? While NK is probably not looking to merge their `char/icbm` driver to the mainline tree, what about the NK military fixing a nasty bug in the memory allocator? Should the patch be rejected even if it improves a non-military subsystem, just because of who wrote it? It's just food-for-thought, personally I do not care one way or the other. As…
Ignoring trust issues (NK inserting a backdoor), I'd say clean bugfixes should probably be accepted. My main point was to nuance the absolutist "code and science should be separate". I don't know enough about this code to make a judgement one way or the other: as I understand the commit message it's a cleanup as a prelude to GMAC and X-GMAC SoC support. Maybe the code is badly in need of some cleanup, or maybe it's e…
For another option, is it possible that patching a legitimate bug could open up a line of attack in an otherwise unrelated piece of code that the bug was somehow blocking? If it is, even legitimate, verified bug fixes, or even bug reports, from non-trusted sources, should be carefully vetted.