Open Source Visitor.js • Hacker News Board

Re: Open Source Visitor.js

#31

Post by jpulgarin » Sat, Jan 07, 2012, 3:13 AM UTC

Localization doesn't seem to work very well. I'm in Waterloo, Canada. This is what the script outputs for me:

> session.locale.country

"US"

> session.locale.location

undefined

Re: Open Source Visitor.js

#32

Post by [deleted] » Sat, Jan 07, 2012, 4:22 AM UTC

gojomo wrote: post #27

The original visitor.js identified my city correctly; this only put me in the USA. Is there a free reliable precise geolocation service that can take as many hits as a script like this could throw at it?

[deleted]

Re: Open Source Visitor.js

#33

Post by [deleted] » Sat, Jan 07, 2012, 4:35 AM UTC

gojomo wrote: post #27

The original visitor.js identified my city correctly; this only put me in the USA. Is there a free reliable precise geolocation service that can take as many hits as a script like this could throw at it?

[deleted]

Re: Open Source Visitor.js

#34

Post by wehriam » Sat, Jan 07, 2012, 5:16 AM UTC

Outstanding! I also was going to have to re-implement this.

Re: Open Source Visitor.js

#35

Post by ryanmahoski » Sat, Jan 07, 2012, 5:58 AM UTC

gojomo wrote: post #27

The original visitor.js identified my city correctly; this only put me in the USA. Is there a free reliable precise geolocation service that can take as many hits as a script like this could throw at it?

Your best bet is html5 geolocation + modernizr.js + a shim. Browsers that support html5 geolocation will return highly accurate results while those that don't support it will fall back to calling the google maps api (ip to geo).

https://github.com/Modernizr/Modernizr/wiki/HTML5-Cross-Brow...

Re: Open Source Visitor.js

#36

Post by codejoust » Sat, Jan 07, 2012, 6:13 AM UTC

desireco42 wrote: post #29

The only thing that would make this better is to have it in coffeescript... :) which I might do for you if you don't.

I thought about doing that. I've used a lot of coffeescript in the past, but I just didn't see it being a big advantage here. The biggest issue with using CoffeeScript here is that I wanted control over the syntax as I wanted to have less code. CoffeeScript (generated) really creates more code than what it's worth.

Re: Open Source Visitor.js

#37

Post by codejoust » Sat, Jan 07, 2012, 6:34 AM UTC

gojomo wrote: post #27

The original visitor.js identified my city correctly; this only put me in the USA. Is there a free reliable precise geolocation service that can take as many hits as a script like this could throw at it?

I added in support for http://ipinfodb.com/ (see bottom of README) which might be better than Google's api, although you need to register for an API key. You might want to give that a shot.

Re: Open Source Visitor.js

#38

Post by DannyPage » Sat, Jan 07, 2012, 6:40 AM UTC

What are the ethical concerns about using this and storing the data? If I wanted to use this on my site, should I let visitors know, or is this data fair game to store? I rather not use the location data (or any of it) if there could be an issue.

Re: Open Source Visitor.js

#39

Post by okal » Sat, Jan 07, 2012, 7:32 AM UTC

jpulgarin wrote: post #31

Localization doesn't seem to work very well. I'm in Waterloo, Canada. This is what the script outputs for me: > session.locale.country "US" > session.locale.location undefined

I'm in Nairobi, Kenya. The output indicates I'm in the US as well.

Re: Open Source Visitor.js

#40

Post by arnoooooo » Sat, Jan 07, 2012, 9:12 AM UTC

jpulgarin wrote: post #31

Localization doesn't seem to work very well. I'm in Waterloo, Canada. This is what the script outputs for me: > session.locale.country "US" > session.locale.location undefined

Are you not confusing

1) session.locale, which is the locale (ie. regional settings) configuration of your browser and might very well be US,

and

2) session.location, which gives your geographic location ?