Live data from Hacker News

Tencent WeChat is now a GitHub secret scanning partner

github.blog

31–40 of 144 posts

Re: Tencent WeChat is now a GitHub secret scanning partner

#31

Why is everyone upset? This is a good thing. Where are you seeing a privacy or security risk?

It’s a combination of missing hyphens (it should be “secret-scanning partners” to avoid adjective ambiguity) and people’s inability to open links and read anything past the title. Sprinkle a bit of Sinophobia and we’re golden.

Re: Tencent WeChat is now a GitHub secret scanning partner

#32

It would be nice of Github if they could publish a transparency repo with all the partners and all the regex along with this initiative. I see a lot of people in this thread worried that "China gets their data" and this transparency repo could alleviate some of that.

I don't think they would release the regex used to validate the API keys since it would help people automate scanning for API keys of all supported providers on public repos on any other site using the regex given by the provider itself.

Re: Tencent WeChat is now a GitHub secret scanning partner

#33
post #27

Why is everyone upset? This is a good thing. Where are you seeing a privacy or security risk?

Tencent provides a list of regexps, and anything matching those regexps is passed to them. As far as I can tell, we don't get to know what those regexps are (and presumably they can be changed at Tencent's whim). Can you not see the issue?

I cannot see the issue because the regex are pre-approved by GitHub. And even then, the service will only return the string, not who wrote it. Unless GitHub approves /Jonh Doe said:.*/ there is no issue whatsoever.

Re: Tencent WeChat is now a GitHub secret scanning partner

#34

Wait, what? So any string (which Github deems an access token) is forwarded to Tencent? Or will Tencent share all their current access tokens with github?

Any string that matches access token regexp provided by Tencent (see https://docs.github.com/en/developers/overview/secret-scanni... ).

For public repositories only though. For private repos it's optional, and when enabled the repo admins get an alert to handle it themselves without it going to the vendor.

Re: Tencent WeChat is now a GitHub secret scanning partner

#35
post #27

Earlier quoted context omitted.

Tencent provides a list of regexps, and anything matching those regexps is passed to them. As far as I can tell, we don't get to know what those regexps are (and presumably they can be changed at Tencent's whim). Can you not see the issue?

I cannot see the issue because the regex are pre-approved by GitHub. And even then, the service will only return the string, not who wrote it. Unless GitHub approves /Jonh Doe said:.*/ there is no issue whatsoever.

I guess I just have a lot less faith in the ability of companies to design perfect processes, and the ability of humans to perfectly carry them out, than you do.

Re: Tencent WeChat is now a GitHub secret scanning partner

#38
post #27

Why is everyone upset? This is a good thing. Where are you seeing a privacy or security risk?

Tencent provides a list of regexps, and anything matching those regexps is passed to them. As far as I can tell, we don't get to know what those regexps are (and presumably they can be changed at Tencent's whim). Can you not see the issue?

We do not know if Tencent can use arbitrary regex to find, I don't know, anti-Chinese sentiment content or just preapproved ones like "tencentToken=([a-zA-Z\d]{15})". Also, it's just for public repositories!

In any case, this announcement changes nothing. If you trusted GitHub with something before that you wouldn't trust them with now, your mental model is wrong. GitHub might allow any kind of partner (customer?) to scan their private or public repos in any way they want without making it public. In other words, if you are someone this announcement is problematic to, you shouldn't have anything on GitHub in the first place.

Re: Tencent WeChat is now a GitHub secret scanning partner

#39
post #27

Earlier quoted context omitted.

Tencent provides a list of regexps, and anything matching those regexps is passed to them. As far as I can tell, we don't get to know what those regexps are (and presumably they can be changed at Tencent's whim). Can you not see the issue?

I cannot see the issue because the regex are pre-approved by GitHub. And even then, the service will only return the string, not who wrote it. Unless GitHub approves /Jonh Doe said:.*/ there is no issue whatsoever.

> I cannot see the issue because the regex are pre-approved by GitHub.

GitHub is a private company with one dual obligation, to prolong its existence and keep increasing its profit margin.

It is not any sort of arbiter for morality - morality being an externality to its central obligation - so it cannot be relief upon to “do the right thing”.

So it is not in any position of authority that would enable it to “approve”, in the moral sense of the word. They can only “allow” for the regex to be ran and the results sent off.

For example, the “right thing” for GH would be to increase profit, while for another entity might instead be to uphold its users’ privacy.

(You may think that it’s only for public repos, so they’re already made public, but isn’t GH here facilitating an aggressive collection and summation of information, that would otherwise be much more difficult and error-prone?)

The power of approval would rather come from an elected entity that would also determine who may request that such searches are executed, and which reasons would be valid.

Otherwise, we get a William Gibson-esque megacorp cyberspace future with clear but corporate Orwellian overtones.

Isn’t this obvious?

(I’m not being snarky at all - I’m genuinely asking: isn’t this glaringly and terrifyingly obvious?)

Re: Tencent WeChat is now a GitHub secret scanning partner

#40
post #3

Earlier quoted context omitted.

No joke. «GitHub will forward access tokens found in public repositories to Tencent WeChat, who will notify affected users.» In other words, Tencent now has access to all of your public repositories. Also, Github now has code recognise Tencent access tokens.

> In other words, Tencent now has access to all of your public repositories. They already did. That's what public means. This is just an optimization to make it harder for WeChat access tokens to be inadvertently compromised without getting noticed. If you're worried about the Chinese government having inappropriate influence over or access to various things outside China, that's in general a valid concern indeed, bu…

I'm shocked by the number of respondents who felt the need to point out what public means.
Post reply on HN