Spent the time on doing such big patch, and not spend the time on learning (5 min max) how to do a pull request... make me think they were forced to do this kind of thing.
So once the code is in, no maintainer from microsoft will be.
Microsoft team submits Redis patch to enable Windows support
31–40 of 103 posts
Re: Microsoft team submits Redis patch to enable Windows support
#32Wow, I'm kind of surprised by the amount of snark ("eww it's 140k lines", "mini git tutorial", "patch file instead of pull request"). It seems it's so big because it contains the libuv. The instructions to compile on Windows don't seem trivial at all and if I cared enough to try this I would appreciate that they wrote it step-by-step. The guys at MS just sat down and made it work while antirez was throwing out sugges…
I couldn't be bothered with writing a rant, so I'm glad somebody put the effort in. You're right... it's a bit off. Just a chance for people to feel superior over the Windoze lusers, I guess :)
I trust that the people behind the patch have got from it what they want, and that if the patch is just sent straight to the recycle bin then it will be no skin off their collective noses.
Re: Microsoft team submits Redis patch to enable Windows support
#33Ok. I got it! They don't want to use git, because git is from Linus ! so they just submit a patch :-P
Re: Microsoft team submits Redis patch to enable Windows support
#34A patch file in a gist instead of a pull request? sigh
can someone please submit a patch to MS to add git pull support to team foundation server or visual sourcesafe (or what are MS guys using these days as version control?)
You might want to check out git tfs. As someone working in a company that relies on tfs I'm going to do the same to keep my sanity..
Re: Microsoft team submits Redis patch to enable Windows support
#35Earlier quoted context omitted.
Not sure what they're going to do regarding fork, but they say this at the end of the gist: TODO Snapshotting (Fork and Write) is not perfect, right now we simply block requests while memory is dumped on disk. We are working on a solution that will give us better performance. An update will be released soon.
So this 146821 line monstrosity isn't even theoretically usable? (You know, I could rewrite Redis in less than 146,000 lines of code...)
[deleted]
Re: Microsoft team submits Redis patch to enable Windows support
#36[Edited for tone which I guess is the reason for the down votes. I appreciate the quick response below.] Most of this patch is adding libuv, which is included in its entirety due to "the version included in the patch is different than the one available on github, some changes have been added to the code". There is also a lot of cleanup. Also a small nit, in the patch instructions: git checkout 3fac86ff1d git checkout…
> 1. cloned redis
> 2. cloned libuv
Re: Microsoft team submits Redis patch to enable Windows support
#37Can somebody more familiar with the Windows environment explain why prn.h is an "invalid file name"? edit:// thanks all! :)
It's reserved for compatibility: "Do not use the following reserved device names for the name of a file: CON, PRN, AUX, NUL, COM1, COM2, COM3, COM4, COM5, COM6, COM7, COM8, COM9, LPT1, LPT2, LPT3, LPT4, LPT5, LPT6, LPT7, LPT8, and LPT9. Also avoid these names followed immediately by an extension; for example, NUL.txt is not recommended."[1] [1] http://msdn.microsoft.com/en-us/library/windows/desktop/aa36...
I once saw some interesting behavior on a Windows 95 machine - my brother printed a drawing for a convention to a file. The printer was a HP LaserJet with plug in module that enabled Postscript. He named the file "con" and when he hit OK on the print dialog the entire screen buffer (over the windowing interface) started filling with Postscript.
Re: Microsoft team submits Redis patch to enable Windows support
#38Earlier quoted context omitted.
I wonder if they contacted Redis author before starting to work on this. You know, with the patch so big and radical, there's a possibility he doesn't even want to accept it. What then, all this effort for basically nothing except a fork, which you then have to continue maintaining etc.
I'd be surprised if he accepted a patch that added a dep; Salvatore seems allergic to deps (something I like about Redis).
(on a mobile and fat-fingered a downvote, sorry)
I wouldn't expect anyone to accept the patch in this state, but I hope that the "who cares about Windows" attitude dies and a dialog to get proper support into redis is started.
It's a shame that we're using an unofficial version on that platform right now.
Re: Microsoft team submits Redis patch to enable Windows support
#39[Edited for tone which I guess is the reason for the down votes. I appreciate the quick response below.] Most of this patch is adding libuv, which is included in its entirety due to "the version included in the patch is different than the one available on github, some changes have been added to the code". There is also a lot of cleanup. Also a small nit, in the patch instructions: git checkout 3fac86ff1d git checkout…
> 1. cloned redis > 2. cloned libuv Of course you mean "fork", not "clone".
[deleted]
Re: Microsoft team submits Redis patch to enable Windows support
#40The snark on this thread is concerning, Microsoft has made a good gesture in trying improve the Redis story on Windows and IMO it's something we all should be encouraging as it can only serve to improve the Redis ecosystem.
Historically Microsoft hasn't been too fond of NoSQL but positive steps like this validates Redis in the eyes of Windows devs which has the potential to attract new devs to the world of Redis and NoSQL.
I personally hope to see this implementation improve so it runs flawlessly on Windows and Azure.