31–40 of 77 posts
What's ironic is that discussion pages, like the one linked here, are broken on mobile. Maybe they should focus on that first. Also, I hate repos that convert issues to discussions. Might as well close the issue, as discussion is usually a graveyard.
'Moved to discussion' seems better to me than 'closed; tagged question'.
I’d settle for them making PRs as useful as they were in 2015, before they messed up some of the most basic functionality: showing the diff, and showing review comments. They hide big diffs behind a “load more” link, and as a result people often fail to code review the most substantial part of a change because they scan right past it, thinking it’s a removed file or binary or something. Then, once you submit a review…
Earlier quoted context omitted.
> They hide big diffs behind a “load more” link, and as a result people often fail to code review the most substantial part of a change because they scan right past it, thinking it’s a removed file or binary or something. This. Every PR I have to do ctrl-F "load diff" and then immediately click on _all_ of the diffs. It's !@#$ing annoying. I've also lost comments when the comment is part of a review and pushed to the…
Might be worth making a bounty for it in refined github[0], similar things have been implemented in the past[1] [0] https://github.com/refined-github/refined-github [1] https://github.com/refined-github/refined-github/issues/2151
Earlier quoted context omitted.
Maybe they're trying to nudge us towards smaller PRs. Many reviewers gloss over 300+ line changes in a single file. Approved with a "LGTM" and no further comment, but perhaps that's more a cultural issue with the team than anything.
Perhaps, but github's PR UI goes to utterly atrocious if you try to do something along the lines of "a series of small atomic changes". In my recent reviewing experience, anything involving multiple commits in a single PR results in the diff more or less lying to you: you get diffs of something , but it's not clear what, and even less clear how to get what I want to actually diff. I think the evidence is pretty clear…
Those who take care to write meaningful per-commit descriptions are actively punished by the eager collapsing. Either reviewers have to (1) spot the ellipsis (2) click on it for each individual commit, or the submitter has to copy-paste all of their commit information into the PR description.
I don’t like scrolling until I see “holy cow wat”.
Earlier quoted context omitted.
> They hide big diffs behind a “load more” link, and as a result people often fail to code review the most substantial part of a change because they scan right past it, thinking it’s a removed file or binary or something. This. Every PR I have to do ctrl-F "load diff" and then immediately click on _all_ of the diffs. It's !@#$ing annoying. I've also lost comments when the comment is part of a review and pushed to the…
Might be worth making a bounty for it in refined github[0], similar things have been implemented in the past[1] [0] https://github.com/refined-github/refined-github [1] https://github.com/refined-github/refined-github/issues/2151
Better to just find a dev-first platform instead.
Earlier quoted context omitted.
Might be worth making a bounty for it in refined github[0], similar things have been implemented in the past[1] [0] https://github.com/refined-github/refined-github [1] https://github.com/refined-github/refined-github/issues/2151
wtf is refined github? A browser extension? Nah, I value my browser more than that
Earlier quoted context omitted.
Maybe they're trying to nudge us towards smaller PRs. Many reviewers gloss over 300+ line changes in a single file. Approved with a "LGTM" and no further comment, but perhaps that's more a cultural issue with the team than anything.
Perhaps, but github's PR UI goes to utterly atrocious if you try to do something along the lines of "a series of small atomic changes". In my recent reviewing experience, anything involving multiple commits in a single PR results in the diff more or less lying to you: you get diffs of something , but it's not clear what, and even less clear how to get what I want to actually diff. I think the evidence is pretty clear…
I'm trying to work on solving this and I have a first iteration of it which I wouldn't mind getting feedback on. If you look at the following PR:
https://oss.gitsense.com/insights/github?bt=open&q=microsoft...
you can easily identify which commit does what. For example, if you select the first two commits and filter by them, the PR tree will show you the files that were changed by those commits and if you click on the commit in the tree, you can view the diff for that commit.
In the future, I want to support what you described and make it very easy to diff any revision.