Live data from Hacker News

Amazon CodeGuru – Preview

aws.amazon.com

31–40 of 209 posts

Re: Amazon CodeGuru – Preview

#31

Earlier quoted context omitted.

exactly. IMO if you're generating code, it should happen at build/compile time not at checkin

What would the rationale be for that?

Generated code is an artifact of the source code. If you need it for something specific, regenerate it from the source when you pull that from your version control system. You're not getting any benefit by storing something that can be generated alongside the means to generate it.

Re: Amazon CodeGuru – Preview

#33

Earlier quoted context omitted.

"CodeGuru’s machine learning models are trained on Amazon’s code bases comprising hundreds of thousands of internal projects, as well as over 10,000 open source projects in GitHub" - from the article.

Oh no, the code quality is going to be shit.

They might be superficial, but if they did any sort of supervised training (I'm assuming they did), then they probably won't be wrong.

Re: Amazon CodeGuru – Preview

#34
post #3

The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.

That’s incredibly cheap, assuming it provides good suggestions. How much time does it take you to review 500 lines of code change, and what’s your time worth? If it takes 10 minutes and your time is worth about $20/hour or more, this service will part for itself immediately.

Although this could certainly supplement a human reviewer, I don't think it could replace one.

Re: Amazon CodeGuru – Preview

#35
post #3

The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.

That’s incredibly cheap, assuming it provides good suggestions. How much time does it take you to review 500 lines of code change, and what’s your time worth? If it takes 10 minutes and your time is worth about $20/hour or more, this service will part for itself immediately.

Our code reviews are far more "is this the right way to solve the problem?" than "hey, you never use that variable you declared." The latter would be picked up by our linter; I'm having a hard time seeing the value proposition here.

>It’s like having a distinguished engineer on call, 24x7

I don't believe that, regardless of how many times they sprinkle in the words "machine" and "learning".

Re: Amazon CodeGuru – Preview

#37
Next step is to provide automated fixes. I've have a side project that does it for Go source code: https://fixmie.com (have plans for other languages and protocols).

But due my Visa situation here in the US (H1B), I'll be never able to monetize it as it's illegal to have a side income. But I think this is just the start and there is an huge opportunity for new startups and projects.

Re: Amazon CodeGuru – Preview

#38
post #3

The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.

Trying to compare it to another code analyzer... https://sonarcloud.io/about/pricing 100k lines for €10/mo.

Is that all code or just the diff, though? 100k lines of code in diffs seems like a lot, all code - not so much.

Re: Amazon CodeGuru – Preview

#39
post #3

The code review feature seems too expensive to run on every PR automatically (to me): $0.75 per 100 lines of code. From their example pricing: "if you have a typical pull request with 500 lines of code, it would only cost $3.75 to run CodeGuru Reviewer on it." I wonder if it's actually good enough to justify that price.

Don't accidentally commit `node_modules` - that'd be a costly mistake!

Re: Amazon CodeGuru – Preview

#40
post #21

I found what it generates. https://github.com/pediredla/Algorithms/pull/3/files It looks like a linter, but maybe there is more.

I've never seen a linter tell me problems with code in this detail before: > You are using a `ConcurrentHashMap`, but your usage of `get()` and `put()` may not be thread-safe at lines: 110, 113, 135, and 137 . Two threads can perform this same check at the same time and one thread can overwrite the value written by the other thread.

staticccheck for Go does _some_ of this kind of thing (documenting improper usage). https://staticcheck.io/docs/checks
Post reply on HN