Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

The GitHub website is slow on Safari

github.com

Post reply on HN
Print view View original

281–290 of 367 posts

Re: The GitHub website is slow on Safari

#281

Post by TheDong »

bapak wrote: post #200
epolanski wrote: post #199

GitHub web used to be great. Then some charlatan thought to embrace the React hype and it became terrible to say the least.

As a hater of React, I don’t think React itself is to blame. Old GitHub was very light on features, whereas the new UIs are way more curated on the surface. Unfortunately all of this brings in tons of complexity. It doesn't help that there are a lot of junior developers working on it, clearly.

What new features has the new UI brought to justify this complexity and slowness?

I haven't been able to load it yet to actually check out these hip new features, it just crashes my browser, but I'm sure they must be great?

Re: The GitHub website is slow on Safari

#282

Post by agos »

throw-the-towel wrote: post #149
agos wrote: post #62

Earlier quoted context omitted.

exactly. I don't want to do a "no true scotsman" to defend React, but circumstantial evidence suggests that they wildly misused the tool

A tool that lends itself to misuse so easily is a bad tool, period.

why do you say "easily"? it took them considerable effort to make that atrocity, I'm pretty sure. The fact that tens of people worked on this and yet this is the result is way more telling of the team and company culture than it is of the specific tool.

Re: The GitHub website is slow on Safari

#283

Post by TheDong »

mwsherman wrote: post #93

Putting on eng manager hat, the problem to solve is that this regression went undetected, not that Safari is slow. The solution is a test that fails when Chrome and Safari have substantially different render times.

> The solution is a test that fails when Chrome and Safari have substantially different render times.

That test will be disabled for being flaky in under a week because the CI runners have contention with other jobs, causing them to randomly be slower and flake, and the frontend team does not want to waste time investigating flakes.

"Just have dedicated runners with guaranteed CPU performance", but that's the CI platform team's issue, the frontend and testing teams can't fix it, and the CI infra team won't prioritize it for a minimum of 5 years.

Re: The GitHub website is slow on Safari

#284

Post by futurecat »

wheybags wrote: post #255
futurecat wrote: post #8

GitHub Actions is such a pain to use just because of how sluggish it feels. I hope they’ll improve performance.

It also continuously fails to scroll down in the log view when watching output of a ci job live, and has done for years. It's so annoying that I made a userscript to force scrolling: https://github.com/wheybags/userscripts/blob/main/github_act...

I feel you. The UX is a gigantic mess. Navigating between jobs and builds is also a terrible experience.

Re: The GitHub website is slow on Safari

#285

Post by guappa »

zerocharge wrote: post #197
xcrunner529 wrote: post #179

Earlier quoted context omitted.

So PHP <6 was a great language?

The front-end is usually just a thin layer on top of a database, sometimes with backend services (queues/processing). Having a bad language on the front-end actually helped. You don't want to write code because of the bad language, you write less code, less code is less bugs. You had to be invested to increase the lines of code. It's like the hard chair of programming languages. If you don't want programmers to dwell…

Have you not seen the internet these past decades?

Re: The GitHub website is slow on Safari

#286

Post by willvarfar »

ssttoo wrote: post #118
PedroBatista wrote: post #11

The Github website is slow everywhere. It is truly a piece of shit software both in terms of performance but also UX/UI and everything in between. It's a product of many cooks and their brilliant ideas and KPIs, a social network for devs and code being the most "brilliant" of them all. For day to day dev operations is something so mediocre even Gitlab looks like the golden standard compared to Github. And no, the pro…

After 10 years of using Phabricator at a previous company I am still shocked how bad GitHub is. This the industry standard?! Too bad Phabricator is maintenance-only now https://en.m.wikipedia.org/wiki/Phabricator

I only used phabricator on a side project that other devs, with meta history, had set up. And although not a heavy user, I rather liked it for being very basic which I thought was a very good thing.

My memory is fuzzy but I think it was on phab that I discovered and loved to use stacked merges. This is where you have a merge request into another open merge request etc. Super useful. Miss that in the git world.

Re: The GitHub website is slow on Safari

#287

Post by arianvanp »

jeroenhd wrote: post #193
arianvanp wrote: post #187

My browser crashed 10 times today trying to copy code in Safari. It's unbearable bad.

While there may be a weird bug affecting Github, the browser crashing is always a browser bug. Github can't fix Safari.

Correction: just the tab crashed

And this is something browsers don't treat as bugs. You can crash any browser's tab by just exhausting its allocated memory

Re: The GitHub website is slow on Safari

#288

Post by guappa »

shadowgovt wrote: post #107
zackmorris wrote: post #57

GitHub moved to a JavaScript rendering mode almost as soon as Microsoft bought it. Previously, I had been able to browse it with JavaScript disabled on my 2011 Mac Mini which Apple stopped allowing upgrades on past macOS 10.13. So even if I enable JavaScript, I can no longer browse GitHub, because they didn't bother to make their build compatible with browser versions as old as mine. It's hard to know which member of…

Turing completeness never says anything about performance. Hypothetically, sure, you could emulate a newer computer on your current computer.

That implies having infinite memory.

Re: The GitHub website is slow on Safari

#289

Post by guappa »

kccqzy wrote: post #213
arresin wrote: post #209

Earlier quoted context omitted.

React is a terrible idea. Everything about it is garbage. The api. State. How they do rendering. The “vdom”. It’s unnecessarily complicated and Byzantine. Like it was designed by someone trying to bill a large company many hours. Svelte is ok. It could have been great but the api for their version of observables is a disaster (which I hope they eventually fix). Sveltekit is half baked and convoluted and I strongly ad…

React is a good idea compared to having to do SPA's without it. Try doing a SPA with only jQuery. VDOM is also a good idea that simplifies the mental model tremendously. Of course these days we can do better than a VDOM. Svelte in fact doesn't use a VDOM. You can say that VDOM is a terrible idea in comparison with Svelte, but that's just anachronistic.

but SPA are a terrible idea

Re: The GitHub website is slow on Safari

#290

Post by itsgabriel »

moffkalast wrote: post #130
patrickmay wrote: post #21

Earlier quoted context omitted.

That seems essentially unreviewable. If you can share without violating an NDA, what kind of PR would involve that many files?

Convert space indents to tabs, as god intended.

as god indented, you mean?
Post reply on HN