Please do not attempt to simplify this code

Post by giancarlostoro » Wed, Aug 07, 2024, 12:27 PM UTC

ChrisMarshallNY wrote: post #253

akira2501 wrote: post #143

Earlier quoted context omitted.

Known bug. The SRR (software readiness review) process happened after development but prior to certification for launch. Most of the bugs were found here and were found to have existed in the code since the beginning of the program. These were overwhelmingly low severity discrepancy reports. If I recall correctly, there was a time when they were finding lots of bugs through SRR, so the main development team started t…

> This made the SRR people angry because they were finding fewer bugs and felt the development team was focusing on competition over bug numbers rather than the code itself. This reminds me of the Quality culture, at my last job, which was a famous Japanese optical corporation. It was deliberately set up, so there was an adversarial relationship between QA, and Development, with QA holding the aces. As a Development…

Post by gilbetron » Wed, Aug 07, 2024, 12:42 PM UTC

jsbg wrote: post #16

> // 1. Every 'if' statement has a matching 'else' (exception: simple error > // checks for a client API call) > // 2. Things that may seem obvious are commented explicitly Honest question: Why invent "safety" practices and ignore every documented software engineering best practice? 2,000 line long modules and 200-line methods with 3-4 if-levels are considered harmful. Comments that say what the code does instead of…

Post by DSMan195276 » Wed, Aug 07, 2024, 1:18 PM UTC

throwaway2037 wrote: post #197

DSMan195276 wrote: post #141

Earlier quoted context omitted.

I agree to a point, but I would separate explicit code from excessive commenting. Explicit code is good because it lets you explain to the reader what you're actually trying to do. Excessive comments (or even comments in general) is less so because compiler cannot check them for correctness, if someone simply forgets to update a comment or writes it incorrectly then the only thing to potentially catch it is a code re…

Do you consider this example as "excessive commenting"?

Post by dijksterhuis » Wed, Aug 07, 2024, 1:55 PM UTC

jgwil2 wrote: post #276

dijksterhuis wrote: post #268

Earlier quoted context omitted.

> humans make mistakes All software is built by humans in some way. All software has mistakes. Perfection is an impossible goal.

Yeah but there's a fundamental difference between something like tests that can be checked automatically and comments, that have to be checked manually. Because of this, it can be assumed that comments will eventually go out of date.

Post by another2another » Wed, Aug 07, 2024, 2:15 PM UTC

ahci8e wrote: post #126

runevault wrote: post #104

Earlier quoted context omitted.

A simple example for anyone who might not appreciate why this can be so nice. In languages where if is a statement (aka returns no value), you'd write code like int value; if(condition) { value = 5; } else { value = 10; } Instead of just int value = if(condition) {5} else {10} Some languages leave ifs as statements but add trinary as a way to get the same effect which is an acceptable workaround, but at least for me…

How would this work if I need to update multiple variables? int value1 = 0; int value2 = 0; if (condition) { value1 = 8; value2 = 16; } else { value1 = 128; value2 = 256; } Would I have to repeat the if expression twice? int value1 = if (condition) { 8 } else { 128 }; int value2 = if (condition) { 16 } else { 256 };

    value1 = 8;

    value2 = 16;

  }