Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

My Favourite Git Commit

fatbusinessman.com

Post reply on HN
Print view View original

241–250 of 389 posts

Re: My Favourite Git Commit

#241

Post by seanbarry »

CharlesColeman wrote: post #237

I really like this commit message. I've found that switching to git from more traditional version control systems requires a lot more discipline in some ways. A lot of people just commit, commit, commit lots of incremental changes with no context or story to them. I've seen pull requests with dozens of tiny commits together make up a cohesive effort, but individually are just useless. I've been really having to push…

Implement and enforce conventional commits: https://www.conventionalcommits.org/en/v1.0.0/

Re: My Favourite Git Commit

#242

Post by mark-r »

ska wrote: post #230
mark-r wrote: post #220

Earlier quoted context omitted.

When locales were invented, it was reasonable to assume that the locale would determine the character set. With the subsequent invention of Unicode that no longer needs to be the case, but code standards live forever.

It wasn't really that reasonable as soon as it was made global. It's exactly the kind of assumption that mostly works but has dark corners from the beginning. Some imaginable version of locales was probably a good approach at the time, but that wasn't what got standardized.

I don't disagree, I've run into those dark corners myself. But the ease of use of globals is undeniable - there's a reason the Singleton pattern is still popular after all the ridicule it attracts.

Re: My Favourite Git Commit

#243

Post by btilly »

beefhash wrote: post #101

I think my favorite (in terms of humor) is a commit from mpv complaining about locales and encodings. You can practically feel the committer's sheer frustration. [1] https://github.com/mpv-player/mpv/commit/1e70e82baa9193f6f02...

Oh. Locales. The remembered pain.

Save a file in Notepad. Open in vi. See that it is different. Find data in the database, no clue the weird characters were originally supposed to be. And so on and so forth.

I once wrote a reasonable program and sent it as a bug report to the maintainer of the Perl module DBD::File. He sent it as a bug report to BerkeleyDB. They said they never thought about it but yes, that would be silent data corruption with no way to recover. The program? Maintain an address book in a BTree sorted in the current locale. Enter names. Change locale and insert something else. Voila! Lost data with no way to recover!

Re: My Favourite Git Commit

#244

Post by generaljelly »

CharlesColeman wrote: post #237

I really like this commit message. I've found that switching to git from more traditional version control systems requires a lot more discipline in some ways. A lot of people just commit, commit, commit lots of incremental changes with no context or story to them. I've seen pull requests with dozens of tiny commits together make up a cohesive effort, but individually are just useless. I've been really having to push…

I'm one of those people. I make lots of little commits, it gives me space to really make a mess of coding going down some rabbit hole and performing 'reset --hard' when I get too away from myself, and track what I'm doing locally. As long as each commit isn't causing a problem with CI/CD, and my pull request to master is well documented what is the value added of cleaning up commits?

(Junior developer here, looking to be convinced!)

Re: My Favourite Git Commit

#245

Post by SamBam »

camochameleon wrote: post #215
SamBam wrote: post #194

Earlier quoted context omitted.

I was reading it and kind of interested, and thought this line was funny: > I have a lot of hope that most of the people using computer vision are just doing happy, good stuff with it, like [...] tracking their cat as it wanders around their house And then suddenly realized I've wanted to do exactly that for a long time. Well... specifically install a camera that can detect my cat on the counter (and not my hands doi…

On the topic of cats vs automation, I'd recommend reading this post [1] describing the arms race created by the writer's cat attempting to break into an automated feeding machine. HN discussion here [2] [1] http://quinndunki.com/blondihacks/?p=3023 [2] https://news.ycombinator.com/item?id=13230904

We had an automated feeder with two chambers, each held down by a rotating, ticking timer switch. You rotate the switch to, say, 12 hours in the future, and 12 hours later the slot lines up and the lid pops over.

After many months, my cat learned to stand on top of the lid and use both paws to rotate the switch forward until the lid popped open.

This blew my mind. The switch was separated from the lid. I could imagine the cat attacking the lid itself, but this separate mechanism, requiring a motion completely distinct from the motion of an opening lid, and requiring patience without instantaneous reward or even evidence that it was going to work.... I just couldn't believe it.

Re: My Favourite Git Commit

#246

Post by mepiethree »

kissgyorgy wrote: post #94

> I don't want your entire life story in my commit log. Then I never want to work with you ever (or any code base you ever touched) because of your laziness and lack of experience working with huge code bases where long commit messages are life-saving. Also you don't care about your colleagues and long-term maintainability. Debugging bugs for months and weeks because of lack of proper commit messages is the most frus…

So you never want to work with... any junior dev ever? I can't think of a single person we have hired out of college who used Git well.

Re: My Favourite Git Commit

#247

Post by matheusmoreira »

powjfjti83 wrote: post #195
SirensOfTitan wrote: post #184

Earlier quoted context omitted.

This comment comes across really mean and judgmental. I didn’t read all of the original commit, but it read to me as informative and passionate with all of the frustrations solving a difficult problem comes with. Honestly, this comment is so over the top I can’t even detect whether you’re serious or not.

Opinions are relative. My over the topness is on purpose. The tone of the commit message resonates with exactly the same tone as my post (to me). The commit comment is filled with judgmental, caustic language toward the efforts of others. Yet my opinions about the persons view of “how to design language” are over the top. So you get my point entirely it seems. Are those people less passionate and deserving of such a…

That commit message may be caustic but there is a lot of knowledge and experience included in it.

Re: My Favourite Git Commit

#248

Post by ska »

mark-r wrote: post #242
ska wrote: post #230

Earlier quoted context omitted.

It wasn't really that reasonable as soon as it was made global. It's exactly the kind of assumption that mostly works but has dark corners from the beginning. Some imaginable version of locales was probably a good approach at the time, but that wasn't what got standardized.

I don't disagree, I've run into those dark corners myself. But the ease of use of globals is undeniable - there's a reason the Singleton pattern is still popular after all the ridicule it attracts.

Sure, it's easy to use. But that isn't the job of standardization bodies, or the right test to use on something as low level as this. It's harder to get right, but it is exactly these sort of failures in standardization that cause the most global pain, because they wend their way through everything.

Re: My Favourite Git Commit

#250

Post by rurp »

camochameleon wrote: post #215
SamBam wrote: post #194

Earlier quoted context omitted.

I was reading it and kind of interested, and thought this line was funny: > I have a lot of hope that most of the people using computer vision are just doing happy, good stuff with it, like [...] tracking their cat as it wanders around their house And then suddenly realized I've wanted to do exactly that for a long time. Well... specifically install a camera that can detect my cat on the counter (and not my hands doi…

On the topic of cats vs automation, I'd recommend reading this post [1] describing the arms race created by the writer's cat attempting to break into an automated feeding machine. HN discussion here [2] [1] http://quinndunki.com/blondihacks/?p=3023 [2] https://news.ycombinator.com/item?id=13230904

I've had good luck using low tech puzzle feeders with my cats. Each one is a bowl with a maze inside or a tower with various windows and trap doors they need to work the food out of to be able to eat. As the food levels get lower the pieces get harder to reach, which allows their laziness to take over and stop them from eating too much.

One example: https://sep.yimg.com/ay/entirelypets/kyjen-dog-games-slo-bow...

Post reply on HN