Live data from Hacker News

Git security vulnerability announced

github.blog

221–230 of 302 posts

Re: Git security vulnerability announced

#221
post #69

Earlier quoted context omitted.

You don't have to trust repos you clone, if I understand correctly. You just need to trust ones you're given in other ways. The difference is, clone won't let you set up arbitrary config (or malformed internal data or etc.)

Can you store a .git/config filepath in a git repository, either via the cli or manually hacking the repo data files?

I hope not!

But, as it was pointed out in https://news.ycombinator.com/item?id=31010522>, you can have nested malicious bare git repos.

Re: Git security vulnerability announced

#222
post #105

Earlier quoted context omitted.

Or create a mercurial repo that contains a .git directory, and rely on finger memory making them run git immediately after cloning...

I’ve done that a few times. I’ve typed “git foo” while mentally thinking about “svn foo”, and after a few hours working on a project that still uses svn I will start making the opposite substitution too.

We use the grunt build tool. More than a handful of times, I've tried to get grunt to do a merge, or git to build the app.

Re: Git security vulnerability announced

#223
post #146

And .... there go probably tens of thousands of person-hours of human effort due to fixing this across huge numbers of systems. It's fascinating to me that we have people out there just casually making these kind of decisions with enormous cost implications with barely any thought to the downstream implications. Then meanwhile, we need approval in our org to claim a $30 taxi voucher as an expense.

It boggles the mind that someone thinks security decisions like these are made casually. Staying sane as an open source maintainer means ignoring such thanklessness as best you can.

Isn’t git Hamano’s day job?

Re: Git security vulnerability announced

#224

> Run the uninstaller under an administrator account rather than as the SYSTEM user How do I run something as SYSTEM? I thought I always ran as "me" or Administrator. Is this only likely to happen for deployment automation tools? > Avoid running the uninstaller until after upgrading Don't leave us with this cliff-hanger... Does the upgrade installer run the uninstaller first? (The original report doesn't have this bu…

Yeah, that's something that should be clarified. I'm almost certain `winget upgrade git` will run the uninstaller first...

Re: Git security vulnerability announced

#225

> Run the uninstaller under an administrator account rather than as the SYSTEM user How do I run something as SYSTEM? I thought I always ran as "me" or Administrator. Is this only likely to happen for deployment automation tools? > Avoid running the uninstaller until after upgrading Don't leave us with this cliff-hanger... Does the upgrade installer run the uninstaller first? (The original report doesn't have this bu…

af

What does that mean?

Re: Git security vulnerability announced

#226
post #83

Earlier quoted context omitted.

The key is the "Git-enabled `PS1`". PS1 is an environment variable recognised by common shell programs (such as bash) that configures the shell prompt. Git often installs its own glue into the prompt that ends up running a Git executable to discover such things as the current branch name and how many changed files. The vulnerability is that it's possible to add malicious things to .git/config that the git executable…

What do you mean by “git often installs”. Git does not install anything. Developers configure their PS1 or install something that does.

> Git does not install anything.

It's literally a Git installer.

Re: Git security vulnerability announced

#227

Interestingly if you're on Windows, then Chocolatey is the better package manager to use. Microsoft's own package manager Winget only has v2.34.1 right now. Chocolatey https://community.chocolatey.org/packages/git#versionhistory Winget https://winget.run/pkg/Git/Git

winget.run isn't up to date, I do see 2.35.2 by running the winget CLI (note that `winget upgrade git` will run the uninstaller first).

$ winget show git.git

    Found Git [Git.Git]
    Version: 2.35.2
    Publisher: The Git Development Community
    Publisher Url: https://gitforwindows.org
    Publisher Support Url: https://github.com/git-for-windows/git/issues
    Author: Johannes Schindelin
    Moniker: git
    Description: Git for Windows focuses on offering a lightweight, native set of tools that bring the full feature set of the Git SCM to Windows while providing appropriate user interfaces for experienced Git users and novices alike.
    Homepage: https://gitforwindows.org
    License: GNU General Public License version 2
    License Url: https://raw.githubusercontent.com/git-for-windows/git/main/COPYING
    Copyright: Copyright (C) 1989, 1991 Free Software Foundation, Inc.
    Copyright Url: https://raw.githubusercontent.com/git-for-windows/git/main/COPYING
    Installer:
    Type: inno
    Download Url: https://github.com/git-for-windows/git/releases/download/v2.35.2.windows.1/Git-2.35.2-64-bit.exe
    SHA256: 8d33512f097e79adf7910d917653e630b3a4446b25fe258f6c3a21bdbde410ca

Re: Git security vulnerability announced

#229
post #41

Earlier quoted context omitted.

Fun :) Going to send an email the old–fashioned way?

Gonna beg in the irc channel for git so they give me access to that bot. God forbid I have to format a patch the way they want me to

You probably know this, but for anyone else following this thread: the bot is https://gitgitgadget.github.io/.
Post reply on HN