You shouldn't be hardcoding CSS/JS into the template files - look into wp_enqueue_style and wp_enqueue_script. Could use a better directory structure, too. Assets should be in a different folder, things like the walker should be in a lib/includes folder. Being a starter theme, it doesn't make sense to just reference the Bootstrap CSS from a CDN. Shouldn't you have the LESS files so people can easily make changes with…
Wordpress Bootstrap 3 Starter Theme – MIT License
21–30 of 45 posts
Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#22Can anyone offer some guidance? Does a framework like Genesis help or hurt in the long-run? Are tools like http://roots.io getting traction?
What are the essential things to require when hiring someone to build a theme for you?
Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#23Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#24Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#25You have great points about the (horrible lack of) code structure. Sue me. Fix it yourself! :) Kidding aside, literally I have about six hours into this, and thought it might be helpful to others.
I really stuck it on github more so that my buddies could use it, than for general consumption... it was just a whim to stick in on here.
I'll pop up a demo site in the next day or two... client work takes a priority. If I had expected to get as much traffic as I am, I would have put it up already... sorry about that!
As for the licensing... I'm not up on it, and shame on me for that... I guess I'll have to do some reading about GPL vs MIT... I just know that I tend to use MIT in the past. Thank you for pointing that out... stay tuned.
Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#26The front page template is hard coded.
Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#27No screenshots? Or am I missing something
There's probably not much to look at, aside from pictures of bbq chicken.
Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#28http://choosealicense.com/licenses/gpl-v2/ Sublicensing is Forbidden
Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#29You shouldn't be hardcoding CSS/JS into the template files - look into wp_enqueue_style and wp_enqueue_script. Could use a better directory structure, too. Assets should be in a different folder, things like the walker should be in a lib/includes folder. Being a starter theme, it doesn't make sense to just reference the Bootstrap CSS from a CDN. Shouldn't you have the LESS files so people can easily make changes with…
Re: Wordpress Bootstrap 3 Starter Theme – MIT License
#30You shouldn't be hardcoding CSS/JS into the template files - look into wp_enqueue_style and wp_enqueue_script. Could use a better directory structure, too. Assets should be in a different folder, things like the walker should be in a lib/includes folder. Being a starter theme, it doesn't make sense to just reference the Bootstrap CSS from a CDN. Shouldn't you have the LESS files so people can easily make changes with…
Ok, all snarky responses aside, you're absolutely right on your points. The way I look at it is, I have six hours into it, realized it might be useful for others, and have alot of the tough parts out of the way. I am not selling it, so if it rubs you the wrong way, say your piece, and move along. This is not for you, right now.
I hadn't heard of Roots before, and obviously didn't find it in my searching. Looking at the site, you might want to make it clear what versions of both WordPress and Bootstrap you are using... I believe I was searching on something like "Wordpress bootstrap 3 theme", and it didn't show up.
Take care man, and keep doing what you're doing... it looks solid!
-Ben